PMD Results
The following document contains the results of PMD 5.3.2.
Files
ks-client - eu/fbk/knowledgestore/client/Client.java
| Violation | Line |
|---|---|
| Possible God class (WMC=94, ATFD=143, TCC=0.013257575757575758) | 1–742 |
| When instantiating a SimpleDateFormat object, specify a Locale | 79 |
| Use block level rather than method level synchronization | 132–135 |
| Document empty method body | 167–168 |
| Document empty method body | 172–173 |
| Return an empty array rather than null. | 176–178 |
| The class 'SessionImpl' has a Standard Cyclomatic Complexity of 4 (Highest = 31). | 243–674 |
| The class 'SessionImpl' has a Cyclomatic Complexity of 4 (Highest = 35). | 243–674 |
| The class 'SessionImpl' has a Modified Cyclomatic Complexity of 4 (Highest = 31). | 243–674 |
| Ensure that resources like this Statement object are closed after use | 353 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 446 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 447–450 |
| Parameter 'statements' is not assigned and could be declared final | 466 |
| Parameter 'timeout' is not assigned and could be declared final | 466 |
| Local variable 'entityEntity' could be declared final | 469 |
| Parameter 'statements' is not assigned and could be declared final | 474 |
| Parameter 'timeout' is not assigned and could be declared final | 474 |
| Local variable 'entityEntity' could be declared final | 477 |
| Avoid appending characters as strings in StringBuffer.append. | 504 |
| The method 'invoke' has a Cyclomatic Complexity of 35. | 531–673 |
| The method 'invoke' has a Standard Cyclomatic Complexity of 31. | 531–673 |
| The method invoke() has an NPath complexity of 621963520 | 531–673 |
| The method 'invoke' has a Modified Cyclomatic Complexity of 31. | 531–673 |
| Avoid really long methods. | 531–673 |
| Prefer StringBuffer over += for concatenating strings | 556 |
| Prefer StringBuffer over += for concatenating strings | 645 |
| Avoid instantiation through private constructors from outside of the constructors class. | 737 |
ks-client - eu/fbk/knowledgestore/client/ProxyConfig.java
| Violation | Line |
|---|---|
| Position literals first in String comparisons | 34 |
| Position literals first in String comparisons | 34 |
| New exception is thrown in catch block, original stack trace may be lost | 37 |
ks-core - eu/fbk/knowledgestore/AbstractKnowledgeStore.java
| Violation | Line |
|---|---|
| Use block level rather than method level synchronization | 26–28 |
| Use block level rather than method level synchronization | 31–39 |
| Use block level rather than method level synchronization | 42–57 |
| Use block level rather than method level synchronization | 66–68 |
| Document empty method body | 88–89 |
ks-core - eu/fbk/knowledgestore/AbstractSession.java
| Violation | Line |
|---|---|
| Possible God class (WMC=134, ATFD=45, TCC=0.0030303030303030303) | 1–813 |
| The class 'AbstractSession' has a Standard Cyclomatic Complexity of 3 (Highest = 11). | 24–813 |
| The class 'AbstractSession' has a Cyclomatic Complexity of 3 (Highest = 13). | 24–813 |
| Too many fields | 24–813 |
| The class 'AbstractSession' has a Modified Cyclomatic Complexity of 3 (Highest = 11). | 24–813 |
| Avoid using redundant field initializer for 'invocationCounter' | 34 |
| Avoid empty catch blocks | 121–123 |
| These nested if statements could be combined | 159–165 |
| Avoid empty catch blocks | 162–164 |
| Call Thread.notifyAll() rather than Thread.notify() | 177 |
| The method 'filter' has a Standard Cyclomatic Complexity of 10. | 204–240 |
| The method 'filter' has a Modified Cyclomatic Complexity of 10. | 204–240 |
| The method 'filter' has a Cyclomatic Complexity of 10. | 204–240 |
| Avoid instantiating new objects inside loops | 247 |
| The method outcome() has an NPath complexity of 396 | 271–308 |
| The method 'outcome' has a Modified Cyclomatic Complexity of 11. | 271–308 |
| The method 'outcome' has a Cyclomatic Complexity of 13. | 271–308 |
| The method 'outcome' has a Standard Cyclomatic Complexity of 11. | 271–308 |
| These nested if statements could be combined | 295–297 |
| The method 'logResponse' has a Modified Cyclomatic Complexity of 10. | 339–365 |
| The method 'logResponse' has a Standard Cyclomatic Complexity of 10. | 339–365 |
| The method 'logResponse' has a Cyclomatic Complexity of 10. | 339–365 |
| Parameter 'timeout' is not assigned and could be declared final | 668 |
| Parameter 'statements' is not assigned and could be declared final | 668 |
| Parameter 'statements' is not assigned and could be declared final | 691 |
| Parameter 'timeout' is not assigned and could be declared final | 691 |
| Document empty method body | 810–811 |
ks-core - eu/fbk/knowledgestore/KnowledgeStore.java
| Violation | Line |
|---|---|
| Avoid unused imports such as 'org.openrdf.model.URI' | 7 |
ks-core - eu/fbk/knowledgestore/Operation.java
| Violation | Line |
|---|---|
| Possible God class (WMC=195, ATFD=31, TCC=0.0) | 1–1277 |
| Avoid unused imports such as 'eu.fbk.knowledgestore.Outcome.Status' | 27 |
| Use block level rather than method level synchronization | 69–72 |
| Use block level rather than method level synchronization | 83–87 |
| Use block level rather than method level synchronization | 205–207 |
| Use block level rather than method level synchronization | 217–221 |
| Use block level rather than method level synchronization | 230–233 |
| Use block level rather than method level synchronization | 243–245 |
| Use block level rather than method level synchronization | 356–360 |
| Use block level rather than method level synchronization | 369–371 |
| Use block level rather than method level synchronization | 405–407 |
| Use block level rather than method level synchronization | 409–413 |
| Use block level rather than method level synchronization | 415–420 |
| Use block level rather than method level synchronization | 422–426 |
| Use block level rather than method level synchronization | 428–430 |
| Use block level rather than method level synchronization | 432–435 |
| Use block level rather than method level synchronization | 437–439 |
| Use block level rather than method level synchronization | 485–487 |
| Use block level rather than method level synchronization | 489–493 |
| Use block level rather than method level synchronization | 495–500 |
| Use block level rather than method level synchronization | 502–506 |
| Use block level rather than method level synchronization | 508–510 |
| Use block level rather than method level synchronization | 512–515 |
| Use block level rather than method level synchronization | 519–521 |
| Use block level rather than method level synchronization | 523–527 |
| Use block level rather than method level synchronization | 529–532 |
| Use block level rather than method level synchronization | 534–537 |
| Use block level rather than method level synchronization | 539–542 |
| Use block level rather than method level synchronization | 574–577 |
| Use block level rather than method level synchronization | 579–583 |
| Use block level rather than method level synchronization | 585–587 |
| Use block level rather than method level synchronization | 593–596 |
| Use block level rather than method level synchronization | 598–601 |
| Use block level rather than method level synchronization | 636–639 |
| Use block level rather than method level synchronization | 641–645 |
| Use block level rather than method level synchronization | 647–649 |
| Use block level rather than method level synchronization | 651–656 |
| Use block level rather than method level synchronization | 658–662 |
| Use block level rather than method level synchronization | 664–666 |
| Use block level rather than method level synchronization | 668–671 |
| Use block level rather than method level synchronization | 673–677 |
| Use block level rather than method level synchronization | 720–722 |
| Use block level rather than method level synchronization | 724–728 |
| Use block level rather than method level synchronization | 730–735 |
| Use block level rather than method level synchronization | 737–741 |
| Use block level rather than method level synchronization | 743–745 |
| Use block level rather than method level synchronization | 747–750 |
| Use block level rather than method level synchronization | 752–755 |
| Use block level rather than method level synchronization | 757–759 |
| Use block level rather than method level synchronization | 761–766 |
| Use block level rather than method level synchronization | 768–772 |
| Use block level rather than method level synchronization | 774–777 |
| Use block level rather than method level synchronization | 779–784 |
| Use block level rather than method level synchronization | 786–790 |
| Use block level rather than method level synchronization | 826–828 |
| Use block level rather than method level synchronization | 830–834 |
| Use block level rather than method level synchronization | 836–841 |
| Use block level rather than method level synchronization | 843–847 |
| Use block level rather than method level synchronization | 849–851 |
| Use block level rather than method level synchronization | 853–856 |
| Use block level rather than method level synchronization | 858–860 |
| Use block level rather than method level synchronization | 862–865 |
| Use block level rather than method level synchronization | 867–871 |
| Use block level rather than method level synchronization | 910–913 |
| Use block level rather than method level synchronization | 915–924 |
| Use block level rather than method level synchronization | 926–932 |
| Use block level rather than method level synchronization | 934–940 |
| Use block level rather than method level synchronization | 942–945 |
| Use block level rather than method level synchronization | 947–956 |
| Use block level rather than method level synchronization | 960–963 |
| Use block level rather than method level synchronization | 965–974 |
| Use block level rather than method level synchronization | 976–982 |
| Use block level rather than method level synchronization | 1007–1010 |
| Use block level rather than method level synchronization | 1012–1016 |
| Use block level rather than method level synchronization | 1018–1020 |
| Use block level rather than method level synchronization | 1037–1040 |
| Use block level rather than method level synchronization | 1042–1046 |
| Use block level rather than method level synchronization | 1048–1050 |
| Use block level rather than method level synchronization | 1133–1135 |
| Use block level rather than method level synchronization | 1146–1150 |
| Use block level rather than method level synchronization | 1161–1163 |
| Use block level rather than method level synchronization | 1174–1177 |
| Use block level rather than method level synchronization | 1186–1189 |
| Use block level rather than method level synchronization | 1199–1202 |
| Use block level rather than method level synchronization | 1214–1217 |
| Local variable 'arg' could be declared final | 1255 |
| New exception is thrown in catch block, original stack trace may be lost | 1265–1266 |
ks-core - eu/fbk/knowledgestore/OperationException.java
| Violation | Line |
|---|---|
| Avoid appending characters as strings in StringBuffer.append. | 84 |
ks-core - eu/fbk/knowledgestore/Outcome.java
| Violation | Line |
|---|---|
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 230 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 231 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 234 |
| Avoid using redundant field initializer for 'uriToStatusMap' | 428 |
| Singleton is not thread safe | 506–512 |
ks-core - eu/fbk/knowledgestore/Session.java
| Violation | Line |
|---|---|
| Avoid unused imports such as 'eu.fbk.knowledgestore.vocabulary.KS' | 7 |
ks-core - eu/fbk/knowledgestore/data/Criteria.java
| Violation | Line |
|---|---|
| Possible God class (WMC=82, ATFD=27, TCC=0.1) | 1–650 |
| The class 'Criteria' has a Cyclomatic Complexity of 2 (Highest = 11). | 93–643 |
| The method 'parse' has a Cyclomatic Complexity of 11. | 136–176 |
| Avoid instantiating new objects inside loops | 148 |
| This call to String.startsWith can be rewritten using String.charAt(0) | 152 |
| Avoid instantiating new objects inside loops | 157 |
| Avoid appending characters as strings in StringBuffer.append. | 442 |
| Avoid appending characters as strings in StringBuffer.append. | 444 |
ks-core - eu/fbk/knowledgestore/data/Data.java
| Violation | Line |
|---|---|
| Possible God class (WMC=418, ATFD=226, TCC=0.001488095238095238) | 1–1875 |
| The class 'Data' has a Standard Cyclomatic Complexity of 6 (Highest = 29). | 102–1875 |
| The class 'Data' has a Modified Cyclomatic Complexity of 6 (Highest = 29). | 102–1875 |
| The class 'Data' has a Cyclomatic Complexity of 8 (Highest = 37). | 102–1875 |
| Avoid instantiating new objects inside loops | 140 |
| Avoid empty catch blocks | 204–206 |
| The method 'hash' has a Modified Cyclomatic Complexity of 14. | 503–543 |
| The method 'hash' has a Cyclomatic Complexity of 14. | 503–543 |
| The method 'hash' has a Standard Cyclomatic Complexity of 14. | 503–543 |
| The method 'convertObject' has a Standard Cyclomatic Complexity of 16. | 666–703 |
| The method 'convertObject' has a Modified Cyclomatic Complexity of 16. | 666–703 |
| The method 'convertObject' has a Cyclomatic Complexity of 16. | 666–703 |
| The method 'convertLiteral' has a Cyclomatic Complexity of 24. | 714–749 |
| The method 'convertLiteral' has a Standard Cyclomatic Complexity of 14. | 714–749 |
| The method 'convertLiteral' has a Modified Cyclomatic Complexity of 14. | 714–749 |
| The method 'convertString' has a Modified Cyclomatic Complexity of 29. | 764–820 |
| The method 'convertString' has a Standard Cyclomatic Complexity of 29. | 764–820 |
| The method 'convertString' has a Cyclomatic Complexity of 37. | 764–820 |
| The method 'convertNumber' has a Modified Cyclomatic Complexity of 21. | 823–868 |
| The method 'convertNumber' has a Standard Cyclomatic Complexity of 21. | 823–868 |
| The method 'convertNumber' has a Cyclomatic Complexity of 29. | 823–868 |
| Avoid creating BigDecimal with a decimal (float/double) literal. Use a String literal | 954 |
| The method 'normalize' has a Cyclomatic Complexity of 11. | 992–1020 |
| The method 'normalize' has a Cyclomatic Complexity of 16. | 1042–1083 |
| The method 'normalize' has a Modified Cyclomatic Complexity of 16. | 1042–1083 |
| The method 'normalize' has a Standard Cyclomatic Complexity of 16. | 1042–1083 |
| The method 'validateIRI' has a Cyclomatic Complexity of 26. | 1093–1124 |
| Avoid empty if statements | 1111–1113 |
| The method 'cleanIRI' has a Cyclomatic Complexity of 26. | 1136–1173 |
| The method 'cleanURI' has a Cyclomatic Complexity of 21. | 1190–1235 |
| The method 'parseValue' has a Modified Cyclomatic Complexity of 15. | 1252–1310 |
| The method 'parseValue' has a Cyclomatic Complexity of 18. | 1252–1310 |
| The method 'parseValue' has a Standard Cyclomatic Complexity of 15. | 1252–1310 |
| This call to String.startsWith can be rewritten using String.charAt(0) | 1261 |
| String.indexOf(char) is faster than String.indexOf(String). | 1265 |
| Avoid empty catch blocks | 1281–1283 |
| This call to String.startsWith can be rewritten using String.charAt(0) | 1290 |
| An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type. | 1307 |
| Ensure that resources like this Statement object are closed after use | 1336 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 1344 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 1346 |
| Avoid appending characters as strings in StringBuffer.append. | 1348 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 1350 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 1399 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 1406 |
| The class 'TotalOrdering' has a Cyclomatic Complexity of 11 (Highest = 29). | 1420–1593 |
| The class 'TotalOrdering' has a Modified Cyclomatic Complexity of 7 (Highest = 20). | 1420–1593 |
| The class 'TotalOrdering' has a Standard Cyclomatic Complexity of 8 (Highest = 25). | 1420–1593 |
| Ensure that resources like this Statement object are closed after use | 1457 |
| The method 'compareLiteral' has a Modified Cyclomatic Complexity of 20. | 1476–1539 |
| The method 'compareLiteral' has a Standard Cyclomatic Complexity of 25. | 1476–1539 |
| The method 'compareLiteral' has a Cyclomatic Complexity of 29. | 1476–1539 |
| The method compareLiteral() has an NPath complexity of 4200 | 1476–1539 |
| The method 'classifyDatatype' has a Cyclomatic Complexity of 23. | 1566–1591 |
| Document empty method body | 1865–1866 |
ks-core - eu/fbk/knowledgestore/data/Dictionary.java
| Violation | Line |
|---|---|
| Possible God class (WMC=93, ATFD=12, TCC=0.004329004329004329) | 1–582 |
| The class 'Dictionary' has a Cyclomatic Complexity of 3 (Highest = 10). | 42–582 |
| This call to String.startsWith can be rewritten using String.charAt(0) | 88 |
| Prefer StringBuffer over += for concatenating strings | 89 |
| Use block level rather than method level synchronization | 282–326 |
| New exception is thrown in catch block, original stack trace may be lost | 309–310 |
| New exception is thrown in catch block, original stack trace may be lost | 313–315 |
| Use block level rather than method level synchronization | 328–377 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 334 |
| The method readWithBackup() has an NPath complexity of 216 | 379–421 |
| The method 'readWithBackup' has a Cyclomatic Complexity of 10. | 379–421 |
| Prefer StringBuffer over += for concatenating strings | 567 |
| Prefer StringBuffer over += for concatenating strings | 569 |
ks-core - eu/fbk/knowledgestore/data/Record.java
| Violation | Line |
|---|---|
| Possible God class (WMC=183, ATFD=85, TCC=0.01097560975609756) | 1–1302 |
| The class 'Record' has a Cyclomatic Complexity of 3 (Highest = 12). | 123–1302 |
| The class 'Record' has a Modified Cyclomatic Complexity of 3 (Highest = 12). | 123–1302 |
| The class 'Record' has a Standard Cyclomatic Complexity of 3 (Highest = 12). | 123–1302 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 162 |
| Avoid instantiating new objects inside loops | 168 |
| The method doSet() has an NPath complexity of 240 | 253–302 |
| The method 'doSet' has a Modified Cyclomatic Complexity of 12. | 253–302 |
| The method 'doSet' has a Cyclomatic Complexity of 12. | 253–302 |
| The method 'doSet' has a Standard Cyclomatic Complexity of 12. | 253–302 |
| Use block level rather than method level synchronization | 354–356 |
| Use block level rather than method level synchronization | 365–368 |
| Use block level rather than method level synchronization | 379–389 |
| Use block level rather than method level synchronization | 397–399 |
| Use block level rather than method level synchronization | 408–410 |
| Use block level rather than method level synchronization | 419–421 |
| Use block level rather than method level synchronization | 473–475 |
| Use block level rather than method level synchronization | 746–760 |
| Use block level rather than method level synchronization | 771–782 |
| Use block level rather than method level synchronization | 832–867 |
| Use block level rather than method level synchronization | 882–914 |
| The method toString() has an NPath complexity of 560 | 882–914 |
| The class 'Encoder' has a Cyclomatic Complexity of 3 (Highest = 12). | 1002–1080 |
| The class 'Encoder' has a Modified Cyclomatic Complexity of 3 (Highest = 10). | 1002–1080 |
| The class 'Encoder' has a Standard Cyclomatic Complexity of 3 (Highest = 10). | 1002–1080 |
| The method 'emit' has a Modified Cyclomatic Complexity of 10. | 1022–1062 |
| The method 'emit' has a Standard Cyclomatic Complexity of 10. | 1022–1062 |
| The method 'emit' has a Cyclomatic Complexity of 12. | 1022–1062 |
| Ensure that resources like this Statement object are closed after use | 1047 |
| The class 'Decoder' has a Cyclomatic Complexity of 5 (Highest = 11). | 1082–1300 |
| The method 'handle' has a Cyclomatic Complexity of 11. | 1111–1151 |
| Ensure that resources like this Statement object are closed after use | 1118 |
| Ensure that resources like this Statement object are closed after use | 1261 |
| Ensure that resources like this Statement object are closed after use | 1285 |
ks-core - eu/fbk/knowledgestore/data/Representation.java
| Violation | Line |
|---|---|
| Possible God class (WMC=63, ATFD=48, TCC=0.0) | 1–574 |
| Avoid unused imports such as 'org.openrdf.model.URI' | 31 |
| The class 'Representation' has a Standard Cyclomatic Complexity of 2 (Highest = 13). | 95–574 |
| The class 'Representation' has a Cyclomatic Complexity of 3 (Highest = 14). | 95–574 |
| The class 'Representation' has a Modified Cyclomatic Complexity of 2 (Highest = 13). | 95–574 |
| Local variable 'bytes' could be declared final | 179 |
| New exception is thrown in catch block, original stack trace may be lost | 195 |
| New exception is thrown in catch block, original stack trace may be lost | 197 |
| The method 'create' has a Modified Cyclomatic Complexity of 13. | 216–296 |
| The method 'create' has a Standard Cyclomatic Complexity of 13. | 216–296 |
| The method create() has an NPath complexity of 484 | 216–296 |
| The method 'create' has a Cyclomatic Complexity of 14. | 216–296 |
| Avoid empty catch blocks | 291–293 |
ks-core - eu/fbk/knowledgestore/data/Serializer.java
| Violation | Line |
|---|---|
| Possible God class (WMC=109, ATFD=53, TCC=0.007352941176470588) | 1–538 |
| The class 'Serializer' has a Standard Cyclomatic Complexity of 6 (Highest = 30). | 43–538 |
| The class 'Serializer' has a Cyclomatic Complexity of 6 (Highest = 30). | 43–538 |
| The class 'Serializer' has a Modified Cyclomatic Complexity of 5 (Highest = 25). | 43–538 |
| The method 'writeObject' has a Standard Cyclomatic Complexity of 25. | 160–264 |
| The method 'writeObject' has a Modified Cyclomatic Complexity of 25. | 160–264 |
| The method 'writeObject' has a Cyclomatic Complexity of 26. | 160–264 |
| Avoid really long methods. | 160–264 |
| The method writeObject() has an NCSS line count of 107 | 160–264 |
| Ensure that resources like this Statement object are closed after use | 253 |
| The method 'writeNumber' has a Cyclomatic Complexity of 10. | 306–326 |
| The method 'readObject' has a Standard Cyclomatic Complexity of 30. | 336–459 |
| The method readObject() has an NPath complexity of 682 | 336–459 |
| Avoid really long methods. | 336–459 |
| The method 'readObject' has a Cyclomatic Complexity of 30. | 336–459 |
| The method 'readObject' has a Modified Cyclomatic Complexity of 11. | 336–459 |
| The method 'readNumber' has a Standard Cyclomatic Complexity of 10. | 484–508 |
| The method 'readNumber' has a Modified Cyclomatic Complexity of 10. | 484–508 |
| The method 'readNumber' has a Cyclomatic Complexity of 10. | 484–508 |
ks-core - eu/fbk/knowledgestore/data/Smaz.java
| Violation | Line |
|---|---|
| The class 'Smaz' has a Modified Cyclomatic Complexity of 6 (Highest = 15). | 29–277 |
| The class 'Smaz' has a Cyclomatic Complexity of 7 (Highest = 20). | 29–277 |
| The class 'Smaz' has a Standard Cyclomatic Complexity of 6 (Highest = 15). | 29–277 |
| The method 'compress' has a Modified Cyclomatic Complexity of 15. | 107–208 |
| The method 'compress' has a Standard Cyclomatic Complexity of 15. | 107–208 |
| The method compress() has an NPath complexity of 4226 | 107–208 |
| The method 'compress' has a Cyclomatic Complexity of 20. | 107–208 |
| Avoid really long methods. | 107–208 |
ks-core - eu/fbk/knowledgestore/data/Stream.java
| Violation | Line |
|---|---|
| Possible God class (WMC=301, ATFD=23, TCC=0.001397624039133473) | 1–2214 |
| Avoid empty catch blocks | 817–819 |
| These nested if statements could be combined | 943–945 |
| Avoid appending characters as strings in StringBuffer.append. | 1080 |
| Avoid appending characters as strings in StringBuffer.append. | 1080 |
| Document empty method body | 1171–1172 |
| Avoid using redundant field initializer for 'closed' | 1202 |
| Document empty method body | 1236–1237 |
| Avoid appending characters as strings in StringBuffer.append. | 1549 |
| The class 'ProcessingStream' has a Standard Cyclomatic Complexity of 4 (Highest = 13). | 1630–1817 |
| The class 'ProcessingStream' has a Cyclomatic Complexity of 5 (Highest = 14). | 1630–1817 |
| The class 'ProcessingStream' has a Modified Cyclomatic Complexity of 4 (Highest = 13). | 1630–1817 |
| The method 'doIteratorParallel' has a Standard Cyclomatic Complexity of 10. | 1670–1709 |
| The method 'doIteratorParallel' has a Cyclomatic Complexity of 11. | 1670–1709 |
| The method 'doIteratorParallel' has a Modified Cyclomatic Complexity of 10. | 1670–1709 |
| Avoid empty catch blocks | 1700–1702 |
| Avoid using redundant field initializer for 'done' | 1723 |
| The method 'doToHandlerParallel' has a Cyclomatic Complexity of 14. | 1748–1798 |
| The method 'doToHandlerParallel' has a Modified Cyclomatic Complexity of 13. | 1748–1798 |
| The method 'doToHandlerParallel' has a Standard Cyclomatic Complexity of 13. | 1748–1798 |
| Avoid using redundant field initializer for 'done' | 1753 |
| The method 'handle' has a Modified Cyclomatic Complexity of 10. | 1757–1786 |
| The method 'handle' has a Standard Cyclomatic Complexity of 10. | 1757–1786 |
| The method 'handle' has a Cyclomatic Complexity of 11. | 1757–1786 |
| Avoid empty catch blocks | 1793–1795 |
| The class 'TransformPathStream' has a Modified Cyclomatic Complexity of 7 (Highest = 17). | 1908–1973 |
| The class 'TransformPathStream' has a Standard Cyclomatic Complexity of 7 (Highest = 17). | 1908–1973 |
| The class 'TransformPathStream' has a Cyclomatic Complexity of 7 (Highest = 18). | 1908–1973 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 1917 |
| The method 'path' has a Standard Cyclomatic Complexity of 17. | 1932–1971 |
| The method 'path' has a Cyclomatic Complexity of 18. | 1932–1971 |
| The method 'path' has a Modified Cyclomatic Complexity of 17. | 1932–1971 |
| Avoid using redundant field initializer for 'count' | 2111 |
| Avoid using redundant field initializer for 'count' | 2134 |
| The class 'PathComparator' has a Modified Cyclomatic Complexity of 7 (Highest = 16). | 2152–2212 |
| The class 'PathComparator' has a Standard Cyclomatic Complexity of 7 (Highest = 16). | 2152–2212 |
| The class 'PathComparator' has a Cyclomatic Complexity of 8 (Highest = 17). | 2152–2212 |
| The method 'path' has a Modified Cyclomatic Complexity of 16. | 2180–2210 |
| The method 'path' has a Cyclomatic Complexity of 17. | 2180–2210 |
| The method 'path' has a Standard Cyclomatic Complexity of 16. | 2180–2210 |
ks-core - eu/fbk/knowledgestore/data/XPath.java
| Violation | Line |
|---|---|
| Possible God class (WMC=279, ATFD=142, TCC=0.0) | 1–1450 |
| The class 'XPath' has a Modified Cyclomatic Complexity of 6 (Highest = 35). | 126–1450 |
| The class 'XPath' has a Cyclomatic Complexity of 8 (Highest = 56). | 126–1450 |
| The class 'XPath' has a Standard Cyclomatic Complexity of 6 (Highest = 35). | 126–1450 |
| The method 'compose' has a Modified Cyclomatic Complexity of 25. | 178–265 |
| The method 'compose' has a Standard Cyclomatic Complexity of 25. | 178–265 |
| The method compose() has an NPath complexity of 14433 | 178–265 |
| The method 'compose' has a Cyclomatic Complexity of 30. | 178–265 |
| When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 181 |
| New exception is thrown in catch block, original stack trace may be lost | 381–382 |
| The method 'rewriteEscapedURIs' has a Modified Cyclomatic Complexity of 10. | 414–468 |
| The method 'rewriteEscapedURIs' has a Standard Cyclomatic Complexity of 10. | 414–468 |
| The method 'rewriteEscapedURIs' has a Cyclomatic Complexity of 20. | 414–468 |
| The method 'rewriteLiterals' has a Modified Cyclomatic Complexity of 18. | 470–573 |
| Avoid really long methods. | 470–573 |
| The method 'rewriteLiterals' has a Standard Cyclomatic Complexity of 18. | 470–573 |
| The method 'rewriteLiterals' has a Cyclomatic Complexity of 50. | 470–573 |
| The method 'analyzeExpr' has a Standard Cyclomatic Complexity of 16. | 575–639 |
| The method 'analyzeExpr' has a Cyclomatic Complexity of 19. | 575–639 |
| The method 'analyzeExpr' has a Modified Cyclomatic Complexity of 16. | 575–639 |
| The method 'encode' has a Modified Cyclomatic Complexity of 20. | 661–718 |
| The method encode() has an NPath complexity of 213 | 661–718 |
| The method 'encode' has a Standard Cyclomatic Complexity of 20. | 661–718 |
| The method 'encode' has a Cyclomatic Complexity of 22. | 661–718 |
| Avoid really long methods. | 1065–1184 |
| The method 'decompose' has a Modified Cyclomatic Complexity of 35. | 1065–1184 |
| The method 'decompose' has a Standard Cyclomatic Complexity of 35. | 1065–1184 |
| The method 'decompose' has a Cyclomatic Complexity of 56. | 1065–1184 |
| The method decompose() has an NPath complexity of 507336 | 1065–1184 |
| These nested if statements could be combined | 1165–1168 |
| The method 'extractValue' has a Modified Cyclomatic Complexity of 15. | 1188–1229 |
| The method 'extractValue' has a Cyclomatic Complexity of 30. | 1188–1229 |
| The method extractValue() has an NPath complexity of 206 | 1188–1229 |
| The method 'extractValue' has a Standard Cyclomatic Complexity of 15. | 1188–1229 |
| Position literals first in String comparisons | 1212 |
| Position literals first in String comparisons | 1214 |
| These nested if statements could be combined | 1241–1243 |
| The method 'toCNF' has a Cyclomatic Complexity of 11. | 1252–1303 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 1429 |
| Avoid appending characters as strings in StringBuffer.append. | 1430 |
| Avoid appending characters as strings in StringBuffer.append. | 1430 |
ks-core - eu/fbk/knowledgestore/data/XPathNavigator.java
| Violation | Line |
|---|---|
| Possible God class (WMC=60, ATFD=8, TCC=0.0) | 1–317 |
| Avoid using a branching statement as the last in a loop. | 270 |
ks-core - eu/fbk/knowledgestore/internal/CommandLine.java
| Violation | Line |
|---|---|
| Possible God class (WMC=79, ATFD=44, TCC=0.05263157894736842) | 1–472 |
| The class 'Parser' has a Cyclomatic Complexity of 3 (Highest = 15). | 166–377 |
| The class 'Parser' has a Modified Cyclomatic Complexity of 3 (Highest = 15). | 166–377 |
| The class 'Parser' has a Standard Cyclomatic Complexity of 3 (Highest = 15). | 166–377 |
| The method 'parse' has a Standard Cyclomatic Complexity of 15. | 254–331 |
| The method 'parse' has a Modified Cyclomatic Complexity of 15. | 254–331 |
| The method 'parse' has a Cyclomatic Complexity of 15. | 254–331 |
| The method parse() has an NPath complexity of 973 | 254–331 |
| New exception is thrown in catch block, original stack trace may be lost | 273 |
| Avoid empty catch blocks | 280–282 |
| Avoid instantiation through private constructors from outside of the constructors class. | 326 |
| The class 'Type' has a Cyclomatic Complexity of 10(Highest = 17). | 393–470 |
| The class 'Type' has a Standard Cyclomatic Complexity of 8(Highest = 13). | 393–470 |
| The class 'Type' has a Modified Cyclomatic Complexity of 8(Highest = 13). | 393–470 |
| The method 'validate' has a Modified Cyclomatic Complexity of 13. | 422–468 |
| The method 'validate' has a Standard Cyclomatic Complexity of 13. | 422–468 |
| The method 'validate' has a Cyclomatic Complexity of 17. | 422–468 |
ks-core - eu/fbk/knowledgestore/internal/Compression.java
| Violation | Line |
|---|---|
| Possible God class (WMC=86, ATFD=35, TCC=0.06060606060606061) | 1–553 |
| The class 'Compression' has a Standard Cyclomatic Complexity of 3 (Highest = 11). | 35–553 |
| The class 'Compression' has a Cyclomatic Complexity of 4 (Highest = 13). | 35–553 |
| The class 'Compression' has a Modified Cyclomatic Complexity of 3 (Highest = 11). | 35–553 |
| An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type. | 158 |
| An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type. | 195 |
| An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type. | 235 |
| An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type. | 272 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 300 |
| Avoid appending characters as strings in StringBuffer.append. | 305 |
| When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 354 |
| Use block level rather than method level synchronization | 392–397 |
| When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 403 |
| The method 'tokenize' has a Standard Cyclomatic Complexity of 11. | 421–455 |
| The method 'tokenize' has a Cyclomatic Complexity of 13. | 421–455 |
| The method 'tokenize' has a Modified Cyclomatic Complexity of 11. | 421–455 |
| Avoid empty catch blocks | 494–496 |
ks-core - eu/fbk/knowledgestore/internal/Logging.java
| Violation | Line |
|---|---|
| Possible God class (WMC=62, ATFD=28, TCC=0.0) | 1–350 |
| Use block level rather than method level synchronization | 119–121 |
| Use block level rather than method level synchronization | 123–129 |
| Use block level rather than method level synchronization | 131–133 |
| Use block level rather than method level synchronization | 135–141 |
| Use block level rather than method level synchronization | 145–190 |
| Avoid empty catch blocks | 176–178 |
| Use block level rather than method level synchronization | 193–207 |
| Use block level rather than method level synchronization | 210–224 |
| The user-supplied array 'status' is stored directly. | 259 |
ks-core - eu/fbk/knowledgestore/internal/Util.java
| Violation | Line |
|---|---|
| Possible God class (WMC=70, ATFD=40, TCC=0.11384615384615385) | 1–420 |
| All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 46–420 |
| This call to String.startsWith can be rewritten using String.charAt(0) | 53 |
| Avoid empty catch blocks | 58–60 |
| Avoid empty catch blocks | 66–68 |
| New exception is thrown in catch block, original stack trace may be lost | 73 |
ks-core - eu/fbk/knowledgestore/internal/jaxrs/Protocol.java
| Violation | Line |
|---|---|
| All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 16–176 |
| Do not add empty strings | 37 |
| Do not add empty strings | 51 |
| Do not add empty strings | 59 |
| Avoid empty catch blocks | 169–171 |
ks-core - eu/fbk/knowledgestore/internal/jaxrs/Serializer.java
| Violation | Line |
|---|---|
| Possible God class (WMC=54, ATFD=95, TCC=0.009523809523809525) | 1–469 |
| When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 337 |
| Avoid empty catch blocks | 424–426 |
| Avoid appending characters as strings in StringBuffer.append. | 431 |
| Avoid appending characters as strings in StringBuffer.append. | 449 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 451 |
ks-core - eu/fbk/knowledgestore/internal/rdf/CompactBindingSet.java
| Violation | Line |
|---|---|
| Possible God class (WMC=83, ATFD=8, TCC=0.023715415019762844) | 1–496 |
| The class 'CompactBindingSet' has a Cyclomatic Complexity of 3 (Highest = 10). | 26–496 |
| The method 'equals' has a Cyclomatic Complexity of 10. | 96–127 |
| Avoid appending characters as strings in StringBuffer.append. | 164 |
| Avoid instantiating new objects inside loops | 257–258 |
| Avoid instantiating new objects inside loops | 259 |
| Avoid instantiating new objects inside loops | 319 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 483 |
| The user-supplied array 'values' is stored directly. | 483 |
ks-core - eu/fbk/knowledgestore/internal/rdf/CompactValueFactory.java
| Violation | Line |
|---|---|
| Possible God class (WMC=109, ATFD=68, TCC=0.0) | 1–573 |
| The class 'CompactValueFactory' has a Cyclomatic Complexity of 3 (Highest = 25). | 35–573 |
| The class 'CompactValueFactory' has a Modified Cyclomatic Complexity of 2 (Highest = 15). | 35–573 |
| The class 'CompactValueFactory' has a Standard Cyclomatic Complexity of 2 (Highest = 15). | 35–573 |
| The method 'normalize' has a Cyclomatic Complexity of 15. | 93–119 |
| The method 'normalize' has a Standard Cyclomatic Complexity of 11. | 93–119 |
| The method 'normalize' has a Modified Cyclomatic Complexity of 11. | 93–119 |
| Ensure that resources like this Statement object are closed after use | 96 |
| These nested if statements could be combined | 110–116 |
| The method 'createLiteral' has a Cyclomatic Complexity of 25. | 153–193 |
| The method 'createLiteral' has a Modified Cyclomatic Complexity of 15. | 153–193 |
| The method 'createLiteral' has a Standard Cyclomatic Complexity of 15. | 153–193 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 386 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 387 |
| StringBuffer (or StringBuilder).append is called 4 consecutive times with literal Strings. Use a single append with a single combined String. | 388 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 388 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 389 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 390 |
ks-core - eu/fbk/knowledgestore/internal/rdf/HtmlSparql.java
| Violation | Line |
|---|---|
| Document empty method body | 105–106 |
| Document empty method body | 109–110 |
| Document empty method body | 124–125 |
ks-core - eu/fbk/knowledgestore/internal/rdf/RDFUtil.java
| Violation | Line |
|---|---|
| Possible God class (WMC=177, ATFD=178, TCC=0.0) | 1–1158 |
| The class 'RDFUtil' has a Standard Cyclomatic Complexity of 5 (Highest = 14). | 92–1158 |
| The class 'RDFUtil' has a Cyclomatic Complexity of 6 (Highest = 15). | 92–1158 |
| The class 'RDFUtil' has a Modified Cyclomatic Complexity of 5 (Highest = 14). | 92–1158 |
| Avoid using redundant field initializer for 'jsonldDisabled' | 96 |
| The method 'toHtml' has a Cyclomatic Complexity of 10. | 98–135 |
| The method 'toHtml' has a Modified Cyclomatic Complexity of 10. | 98–135 |
| The method 'toHtml' has a Standard Cyclomatic Complexity of 10. | 98–135 |
| The method 'detectSparqlProlog' has a Cyclomatic Complexity of 12. | 192–211 |
| Position literals first in String comparisons | 219 |
| Position literals first in String comparisons | 219 |
| Position literals first in String comparisons | 220 |
| Position literals first in String comparisons | 220 |
| Avoid using redundant field initializer for 'started' | 238 |
| Avoid using redundant field initializer for 'count' | 240 |
| The method 'writeRDF' has a Cyclomatic Complexity of 10. | 377–428 |
| Avoid using redundant field initializer for 'started' | 400 |
| Avoid using redundant field initializer for 'count' | 402 |
| The method 'readRDF' has a Standard Cyclomatic Complexity of 14. | 566–649 |
| The method readRDF() has an NPath complexity of 840 | 566–649 |
| The method 'readRDF' has a Cyclomatic Complexity of 15. | 566–649 |
| The method 'readRDF' has a Modified Cyclomatic Complexity of 14. | 566–649 |
| Avoid instantiating new objects inside loops | 606–631 |
| The method 'readRDFHelper' has a Cyclomatic Complexity of 12. | 651–695 |
| The method 'readRDFHelper' has a Modified Cyclomatic Complexity of 12. | 651–695 |
| The method 'readRDFHelper' has a Standard Cyclomatic Complexity of 12. | 651–695 |
| The method readRDFHelper() has an NPath complexity of 486 | 651–695 |
| An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type. | 682 |
| An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type. | 684 |
| An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type. | 686 |
| Use block level rather than method level synchronization | 795–800 |
| Use block level rather than method level synchronization | 803–805 |
| Use block level rather than method level synchronization | 808–811 |
| Use block level rather than method level synchronization | 814–817 |
| Use block level rather than method level synchronization | 820–825 |
| Use block level rather than method level synchronization | 857–895 |
| Use block level rather than method level synchronization | 923–943 |
| Ensure that resources like this Statement object are closed after use | 1055 |
| Avoid using redundant field initializer for 'totalCounter' | 1083 |
| Avoid using redundant field initializer for 'lastCounter' | 1087 |
| Non-static initializers are confusing | 1153–1156 |
| Do not add empty strings | 1155 |
ks-core - org/jaxen/expr/DefaultRelationalExpr.java
| Violation | Line |
|---|---|
| Avoid unused method parameters such as 'nav'. | 72 |
ks-populator-naf - eu/fbk/knowledgestore/populator/naf/Consumer.java
| Violation | Line |
|---|---|
| The class 'Consumer' has a Standard Cyclomatic Complexity of 7 (Highest = 15). | 14–181 |
| The class 'Consumer' has a Modified Cyclomatic Complexity of 7 (Highest = 15). | 14–181 |
| The class 'Consumer' has a Cyclomatic Complexity of 8 (Highest = 15). | 14–181 |
| Private field 'queue' could be made final; it is only initialized in the declaration or constructor. | 16 |
| Parameter 'q' is not assigned and could be declared final | 18 |
| Avoid using redundant field initializer for 'called' | 21 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 21 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 22 |
| Avoid unused local variables such as 'cN'. | 28 |
| Local variable 'cN' could be declared final | 28 |
| Local variable 'obl' could be declared final | 38 |
| The method 'submitCollectedData' has a Modified Cyclomatic Complexity of 15. | 86–150 |
| Parameter 'mentions' is not assigned and could be declared final | 86 |
| Parameter 'session' is not assigned and could be declared final | 86 |
| The method 'submitCollectedData' has a Cyclomatic Complexity of 15. | 86–150 |
| The method 'submitCollectedData' has a Standard Cyclomatic Complexity of 15. | 86–150 |
| Local variable 'className' could be declared final | 89 |
| Local variable 'clazz' could be declared final | 90 |
| Local variable 'parameters' could be declared final | 91 |
| Local variable 'method' could be declared final | 92 |
| Local variable 'obj' could be declared final | 93 |
| Local variable 'status' could be declared final | 97 |
| Avoid empty if statements | 98–99 |
| Local variable 'mentmp' could be declared final | 102 |
| Local variable 'rc' could be declared final | 103 |
| Local variable 'status2' could be declared final | 106–107 |
| Local variable 'vl' could be declared final | 123 |
| Prefer StringBuffer over += for concatenating strings | 124 |
| Prefer StringBuffer over += for concatenating strings | 126 |
| Local variable 'vl' could be declared final | 132 |
| Prefer StringBuffer over += for concatenating strings | 133 |
| Prefer StringBuffer over += for concatenating strings | 135 |
| Local variable 'vl' could be declared final | 141 |
| Prefer StringBuffer over += for concatenating strings | 142 |
| Prefer StringBuffer over += for concatenating strings | 144 |
| Parameter 'mentions' is not assigned and could be declared final | 152 |
| Local variable 'mn' could be declared final | 154 |
| Local variable 'naf_file_path' could be declared final | 155 |
| Local variable 'stats' could be declared final | 156 |
| Local variable 'mnMen' could be declared final | 169 |
ks-populator-naf - eu/fbk/knowledgestore/populator/naf/KSPresentation.java
| Violation | Line |
|---|---|
| Avoid unused imports such as 'java.util.Collection' | 3 |
| Avoid using redundant field initializer for 'foundInKS' | 15 |
| Parameter 'foundInKS' is not assigned and could be declared final | 22 |
| Parameter 'stats' is not assigned and could be declared final | 32 |
| Parameter 'naf' is not assigned and could be declared final | 40 |
| Parameter 'newsResource' is not assigned and could be declared final | 46 |
| Parameter 'news' is not assigned and could be declared final | 52 |
| Parameter 'naf_file_path' is not assigned and could be declared final | 58 |
| Parameter 'mentionListHash' is not assigned and could be declared final | 64 |
ks-populator-naf - eu/fbk/knowledgestore/populator/naf/NAFRunner.java
| Violation | Line |
|---|---|
| Possible God class (WMC=66, ATFD=87, TCC=0.0) | 1–422 |
| Avoid unused imports such as 'java.io.BufferedWriter' | 4 |
| Avoid unused imports such as 'java.io.OutputStreamWriter' | 11 |
| Avoid unused imports such as 'org.slf4j.Logger' | 26 |
| The class 'NAFRunner' has a Modified Cyclomatic Complexity of 9 (Highest = 22). | 28–422 |
| The class 'NAFRunner' has a Standard Cyclomatic Complexity of 9 (Highest = 22). | 28–422 |
| The class 'NAFRunner' has a Cyclomatic Complexity of 11 (Highest = 24). | 28–422 |
| The method 'generate' has a Standard Cyclomatic Complexity of 22. | 30–241 |
| Avoid really long methods. | 30–241 |
| The method 'generate' has a Modified Cyclomatic Complexity of 22. | 30–241 |
| The method 'generate' has a Cyclomatic Complexity of 24. | 30–241 |
| Local variable 'in' could be declared final | 36 |
| Local variable 'reader' could be declared final | 37 |
| Local variable 'br' could be declared final | 38 |
| Local variable 'fileslist' could be declared final | 40 |
| Avoid instantiating new objects inside loops | 48 |
| Local variable 'e' could be declared final | 48 |
| Avoid using if...else statements without curly braces | 50 |
| Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 57 |
| Local variable 'ZIP_OUTPUT_DIR' could be declared final | 66 |
| Local variable 'buffer' could be declared final | 67 |
| Local variable 'fileslist' could be declared final | 68 |
| Useless parentheses. | 69 |
| Local variable 'multipleFileFlag' could be declared final | 69 |
| Local variable 'zipDir' could be declared final | 72 |
| Local variable 'zis' could be declared final | 78 |
| Avoid empty if statements | 86–93 |
| Local variable 'zeName' could be declared final | 95 |
| Local variable 'tmpFile' could be declared final | 98 |
| Avoid instantiating new objects inside loops | 98 |
| Local variable 'basename' could be declared final | 99 |
| Local variable 'extractedFile' could be declared final | 101 |
| Avoid instantiating new objects inside loops | 101 |
| Local variable 'extractedPath' could be declared final | 102 |
| Avoid instantiating new objects inside loops | 108 |
| Local variable 'fos' could be declared final | 108 |
| Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 139 |
| Useless parentheses. | 139 |
| Local variable 'TAR_OUTPUT_DIR' could be declared final | 153 |
| Local variable 'buffer' could be declared final | 154 |
| Local variable 'fileslist' could be declared final | 155 |
| Local variable 'multipleFileFlag' could be declared final | 156 |
| Useless parentheses. | 156 |
| Local variable 'tgzDir' could be declared final | 159 |
| Local variable 'is' could be declared final | 165 |
| Avoid empty if statements | 173–180 |
| Local variable 'teName' could be declared final | 182 |
| Avoid instantiating new objects inside loops | 185 |
| Local variable 'tmpFile' could be declared final | 185 |
| Local variable 'basename' could be declared final | 186 |
| Avoid instantiating new objects inside loops | 188 |
| Local variable 'extractedFile' could be declared final | 188 |
| Local variable 'extractedPath' could be declared final | 189 |
| Local variable 'outputFileStream' could be declared final | 195 |
| Avoid instantiating new objects inside loops | 195 |
| Useless parentheses. | 222 |
| Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 222 |
| Parameter 'disabledItems' is not assigned and could be declared final | 243 |
| The method 'RunSystemOnList' has a Standard Cyclomatic Complexity of 10. | 243–285 |
| The method 'RunSystemOnList' has a Cyclomatic Complexity of 16. | 243–285 |
| Parameter 'rec' is not assigned and could be declared final | 243 |
| Parameter 'fileslist' is not assigned and could be declared final | 243 |
| The method 'RunSystemOnList' has a Modified Cyclomatic Complexity of 10. | 243–285 |
| Local variable 'mentions' could be declared final | 246 |
| Local variable 'filePath' could be declared final | 248 |
| Local variable 'listOfFiles' could be declared final | 251 |
| Useless parentheses. | 267 |
| Useless parentheses. | 267 |
| Useless parentheses. | 282 |
| Parameter 'mentions' is not assigned and could be declared final | 290 |
| Useless parentheses. | 291 |
| Useless parentheses. | 291 |
| Useless parentheses. | 291 |
| Avoid reassigning parameters such as 'mentions' | 299 |
| The method 'analyzePathAndRunSystem' has a Cyclomatic Complexity of 17. | 307–387 |
| The method analyzePathAndRunSystem() has an NPath complexity of 205 | 307–387 |
| Parameter 'path' is not assigned and could be declared final | 307 |
| The method 'analyzePathAndRunSystem' has a Standard Cyclomatic Complexity of 11. | 307–387 |
| Parameter 'disabledItems' is not assigned and could be declared final | 307 |
| Parameter 'rec' is not assigned and could be declared final | 307 |
| The method 'analyzePathAndRunSystem' has a Modified Cyclomatic Complexity of 11. | 307–387 |
| Local variable 'filePath' could be declared final | 310 |
| Local variable 'listOfFiles' could be declared final | 315 |
| Avoid instantiating new objects inside loops | 336 |
| Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 342 |
| Useless parentheses. | 380 |
| Parameter 'mentions' is not assigned and could be declared final | 391 |
| Parameter 'disabledItems' is not assigned and could be declared final | 391 |
| Parameter 'path' is not assigned and could be declared final | 391 |
| Local variable 'className' could be declared final | 396 |
| Local variable 'clazz' could be declared final | 397 |
| Local variable 'parameters' could be declared final | 398 |
| Local variable 'method' could be declared final | 399 |
| Local variable 'obj' could be declared final | 400 |
| Local variable 'as' could be declared final | 402–403 |
ks-populator-naf - eu/fbk/knowledgestore/populator/naf/Producer.java
| Violation | Line |
|---|---|
| Avoid unused imports such as 'java.io.IOException' | 2 |
| Avoid unused imports such as 'java.io.Writer' | 3 |
| Avoid unused imports such as 'org.slf4j.Logger' | 7 |
| Possible unsafe assignment to a non-final static field in a constructor. | 11 |
| Parameter 'q' is not assigned and could be declared final | 13 |
| Local variable 'msg' could be declared final | 20 |
ks-populator-naf - eu/fbk/knowledgestore/populator/naf/connection/KnowledgestoreServer.java
| Violation | Line |
|---|---|
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 54 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 57 |
| Parameter 'value' is not assigned and could be declared final | 79 |
| Parameter 'value' is not assigned and could be declared final | 103 |
| Parameter 'value' is not assigned and could be declared final | 127 |
ks-populator-naf - eu/fbk/knowledgestore/populator/naf/connection/ObjectFactory.java
| Violation | Line |
|---|---|
| Document empty constructor | 36–37 |
ks-populator-naf - eu/fbk/knowledgestore/populator/naf/finalizeThread.java
| Violation | Line |
|---|---|
| Local variable 'tmp' could be declared final | 26 |
| Avoid using if statements without curly braces | 27–28 |
ks-populator-naf - eu/fbk/knowledgestore/populator/naf/getToBeProcessed.java
| Violation | Line |
|---|---|
| Avoid unused imports such as 'java.util.Set' | 10 |
| All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 12–87 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 18 |
| Parameter 'args' is not assigned and could be declared final | 18 |
| Local variable 'all' could be declared final | 19 |
| Local variable 'sub' could be declared final | 20 |
| Local variable 'intersect' could be declared final | 21 |
| Local variable 'ap' could be declared final | 22–24 |
| Local variable 'sp' could be declared final | 25–27 |
| Local variable 'intersectp' could be declared final | 28–30 |
| Parameter 'intersectp' is not assigned and could be declared final | 37 |
| Parameter 'all' is not assigned and could be declared final | 37 |
| Parameter 'intersect' is not assigned and could be declared final | 38 |
| Parameter 'sub' is not assigned and could be declared final | 38 |
| Local variable 'file' could be declared final | 40 |
| Local variable 'fw' could be declared final | 47 |
| Local variable 'bw' could be declared final | 48 |
| Local variable 'link' could be declared final | 49 |
| Avoid using if statements without curly braces | 53–54 |
| Parameter 'fls' is not assigned and could be declared final | 62 |
| Parameter 'filepath' is not assigned and could be declared final | 62 |
| Avoid using if statements without curly braces | 80 |
ks-populator-naf - eu/fbk/knowledgestore/populator/naf/groupTxtF.java
| Violation | Line |
|---|---|
| Avoid unused imports such as 'java.io.BufferedWriter' | 3 |
| Avoid unused imports such as 'java.io.OutputStreamWriter' | 10 |
| Avoid unused imports such as 'java.io.Writer' | 11 |
| All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 15–81 |
| Parameter 'args' is not assigned and could be declared final | 27 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 27 |
| Parameter 'path' is not assigned and could be declared final | 31 |
| Local variable 'filePath' could be declared final | 32 |
| Local variable 'listOfFiles' could be declared final | 37 |
| Parameter 'source' is not assigned and could be declared final | 59 |
| Avoid using if statements without curly braces | 60–61 |
| Local variable 'inStream' could be declared final | 64 |
| Local variable 'buffer' could be declared final | 66 |
ks-populator-naf - eu/fbk/knowledgestore/populator/naf/model/Chunk.java
| Violation | Line |
|---|---|
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 39 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 42 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 45 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 48 |
| Parameter 'value' is not assigned and could be declared final | 72 |
| Parameter 'value' is not assigned and could be declared final | 96 |
| Parameter 'value' is not assigned and could be declared final | 120 |
| Parameter 'value' is not assigned and could be declared final | 144 |
ks-populator-naf - eu/fbk/knowledgestore/populator/naf/model/Clink.java
| Violation | Line |
|---|---|
| Avoid unused imports such as 'javax.xml.bind.annotation.XmlIDREF' | 15 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 34 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 41 |
| Parameter 'value' is not assigned and could be declared final | 63 |
| Parameter 'from' is not assigned and could be declared final | 73 |
| Parameter 'to' is not assigned and could be declared final | 81 |
| Parameter 'value' is not assigned and could be declared final | 105 |
ks-populator-naf - eu/fbk/knowledgestore/populator/naf/model/Component.java
| Violation | Line |
|---|---|
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 39 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 42 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 45 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 48 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 51 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 54 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 57 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 60 |
| Parameter 'value' is not assigned and could be declared final | 88 |
| Parameter 'value' is not assigned and could be declared final | 112 |
| Parameter 'value' is not assigned and could be declared final | 136 |
| Parameter 'value' is not assigned and could be declared final | 160 |
| Parameter 'value' is not assigned and could be declared final | 184 |
| Parameter 'value' is not assigned and could be declared final | 208 |
| Parameter 'value' is not assigned and could be declared final | 232 |
| Parameter 'value' is not assigned and could be declared final | 256 |
ks-populator-naf - eu/fbk/knowledgestore/populator/naf/model/Coref.java
| Violation | Line |
|---|---|
| Avoid unused imports such as 'java.util.ArrayList' | 11 |
| Avoid unused imports such as 'javax.xml.bind.annotation.XmlElements' | 17 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 39 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 42 |
| Parameter 'value' is not assigned and could be declared final | 68 |
| Parameter 'value' is not assigned and could be declared final | 92 |
| Parameter 'externalReferences' is not assigned and could be declared final | 102 |
| Parameter 'span' is not assigned and could be declared final | 110 |
ks-populator-naf - eu/fbk/knowledgestore/populator/naf/model/Dates.java
| Violation | Line |
|---|---|
| Parameter 'value' is not assigned and could be declared final | 51 |
ks-populator-naf - eu/fbk/knowledgestore/populator/naf/model/Dep.java
| Violation | Line |
|---|---|
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 31 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 34 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 37 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 40 |
| Parameter 'value' is not assigned and could be declared final | 62 |
| Parameter 'value' is not assigned and could be declared final | 86 |
| Parameter 'value' is not assigned and could be declared final | 110 |
| Parameter 'value' is not assigned and could be declared final | 134 |
ks-populator-naf - eu/fbk/knowledgestore/populator/naf/model/Edge.java
| Violation | Line |
|---|---|
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 34 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 37 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 40 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 43 |
| Parameter 'value' is not assigned and could be declared final | 65 |
| Parameter 'value' is not assigned and could be declared final | 89 |
| Parameter 'value' is not assigned and could be declared final | 113 |
| Parameter 'value' is not assigned and could be declared final | 137 |
ks-populator-naf - eu/fbk/knowledgestore/populator/naf/model/Entity.java
| Violation | Line |
|---|---|
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 39 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 42 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 45 |
| Parameter 'value' is not assigned and could be declared final | 72 |
| Parameter 'value' is not assigned and could be declared final | 96 |
| Parameter 'value' is not assigned and could be declared final | 120 |
ks-populator-naf - eu/fbk/knowledgestore/populator/naf/model/ExternalRef.java
| Violation | Line |
|---|---|
| Avoid unused imports such as 'java.util.ArrayList' | 11 |
| Avoid unused imports such as 'javax.xml.bind.annotation.XmlElements' | 18 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 37 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 40 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 43 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 46 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 49 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 52 |
| Parameter 'value' is not assigned and could be declared final | 79 |
| Parameter 'value' is not assigned and could be declared final | 103 |
| Parameter 'value' is not assigned and could be declared final | 127 |
| Parameter 'value' is not assigned and could be declared final | 151 |
| Parameter 'value' is not assigned and could be declared final | 175 |
| Parameter 'value' is not assigned and could be declared final | 199 |
| Parameter 'externalRef' is not assigned and could be declared final | 207 |
| Parameter 'sentiment' is not assigned and could be declared final | 215 |
ks-populator-naf - eu/fbk/knowledgestore/populator/naf/model/FactVal.java
| Violation | Line |
|---|---|
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 30 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 33 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 36 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 39 |
| Parameter 'value' is not assigned and could be declared final | 61 |
| Parameter 'value' is not assigned and could be declared final | 85 |
| Parameter 'value' is not assigned and could be declared final | 109 |
| Parameter 'value' is not assigned and could be declared final | 133 |
ks-populator-naf - eu/fbk/knowledgestore/populator/naf/model/Factuality.java
| Violation | Line |
|---|---|
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 38 |
| Parameter 'value' is not assigned and could be declared final | 64 |
| Parameter 'value' is not assigned and could be declared final | 88 |
ks-populator-naf - eu/fbk/knowledgestore/populator/naf/model/Factvalue.java
| Violation | Line |
|---|---|
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 31 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 34 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 37 |
| Parameter 'value' is not assigned and could be declared final | 59 |
| Parameter 'value' is not assigned and could be declared final | 83 |
| Parameter 'value' is not assigned and could be declared final | 107 |
ks-populator-naf - eu/fbk/knowledgestore/populator/naf/model/FileDesc.java
| Violation | Line |
|---|---|
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 30 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 33 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 36 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 39 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 42 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 45 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 48 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 51 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 54 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 57 |
| Parameter 'value' is not assigned and could be declared final | 79 |
| Parameter 'value' is not assigned and could be declared final | 103 |
| Parameter 'value' is not assigned and could be declared final | 127 |
| Parameter 'value' is not assigned and could be declared final | 151 |
| Parameter 'value' is not assigned and could be declared final | 175 |
| Parameter 'value' is not assigned and could be declared final | 199 |
| Parameter 'section' is not assigned and could be declared final | 207 |
| Parameter 'magazine' is not assigned and could be declared final | 215 |
| Parameter 'location' is not assigned and could be declared final | 223 |
| Parameter 'publisher' is not assigned and could be declared final | 231 |
ks-populator-naf - eu/fbk/knowledgestore/populator/naf/model/LinguisticProcessors.java
| Violation | Line |
|---|---|
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 35 |
| Parameter 'value' is not assigned and could be declared final | 59 |
ks-populator-naf - eu/fbk/knowledgestore/populator/naf/model/Locations.java
| Violation | Line |
|---|---|
| Parameter 'value' is not assigned and could be declared final | 51 |
ks-populator-naf - eu/fbk/knowledgestore/populator/naf/model/Lp.java
| Violation | Line |
|---|---|
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 30 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 33 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 36 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 39 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 42 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 45 |
| Parameter 'value' is not assigned and could be declared final | 67 |
| Parameter 'value' is not assigned and could be declared final | 91 |
| Parameter 'value' is not assigned and could be declared final | 115 |
| Parameter 'value' is not assigned and could be declared final | 139 |
| Parameter 'value' is not assigned and could be declared final | 163 |
| Parameter 'value' is not assigned and could be declared final | 187 |
ks-populator-naf - eu/fbk/knowledgestore/populator/naf/model/Mark.java
| Violation | Line |
|---|---|
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 39 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 42 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 45 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 48 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 51 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 54 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 57 |
| Parameter 'value' is not assigned and could be declared final | 85 |
| Parameter 'value' is not assigned and could be declared final | 109 |
| Parameter 'value' is not assigned and could be declared final | 133 |
| Parameter 'value' is not assigned and could be declared final | 157 |
| Parameter 'value' is not assigned and could be declared final | 181 |
| Parameter 'value' is not assigned and could be declared final | 205 |
| Parameter 'value' is not assigned and could be declared final | 229 |
ks-populator-naf - eu/fbk/knowledgestore/populator/naf/model/NAF.java
| Violation | Line |
|---|---|
| Possible God class (WMC=68, ATFD=26, TCC=0.017959183673469388) | 9–377 |
| Avoid unused imports such as 'java.util.ArrayList' | 11 |
| Avoid unused imports such as 'java.util.List' | 12 |
| Avoid unused imports such as 'javax.xml.bind.annotation.XmlElements' | 18 |
| No need to import a type that lives in the same package | 23 |
| Too many fields | 34–377 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 38 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 41 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 45 |
| Parameter 'value' is not assigned and could be declared final | 111 |
| Parameter 'value' is not assigned and could be declared final | 135 |
| Parameter 'value' is not assigned and could be declared final | 159 |
| Parameter 'nafHeader' is not assigned and could be declared final | 167 |
| Parameter 'raw' is not assigned and could be declared final | 175 |
| Avoid using if statements without curly braces | 180–181 |
| Parameter 'topics' is not assigned and could be declared final | 185 |
| Parameter 'text' is not assigned and could be declared final | 193 |
| Parameter 'terms' is not assigned and could be declared final | 201 |
| Avoid using if statements without curly braces | 206–207 |
| Parameter 'deps' is not assigned and could be declared final | 211 |
| Avoid using if statements without curly braces | 216–217 |
| Parameter 'chunks' is not assigned and could be declared final | 221 |
| Avoid using if statements without curly braces | 226–227 |
| Parameter 'entities' is not assigned and could be declared final | 231 |
| Avoid using if statements without curly braces | 236–237 |
| Parameter 'coreferences' is not assigned and could be declared final | 241 |
| Avoid using if statements without curly braces | 246–247 |
| Parameter 'constituency' is not assigned and could be declared final | 251 |
| Avoid using if statements without curly braces | 256–257 |
| Parameter 'srl' is not assigned and could be declared final | 261 |
| Avoid using if statements without curly braces | 266–267 |
| Parameter 'opinions' is not assigned and could be declared final | 271 |
| Avoid using if statements without curly braces | 276–277 |
| Parameter 'timeExpressions' is not assigned and could be declared final | 281 |
| Avoid using if statements without curly braces | 286–287 |
| Parameter 'factualitylayer' is not assigned and could be declared final | 291 |
| Avoid using if statements without curly braces | 296–297 |
| Parameter 'tunits' is not assigned and could be declared final | 301 |
| Avoid using if statements without curly braces | 306–307 |
| Parameter 'locations' is not assigned and could be declared final | 311 |
| Avoid using if statements without curly braces | 316–317 |
| Parameter 'dates' is not assigned and could be declared final | 321 |
| Avoid using if statements without curly braces | 326–327 |
| Parameter 'temporalRelations' is not assigned and could be declared final | 331 |
| Avoid using if statements without curly braces | 336–337 |
| Parameter 'causalRelations' is not assigned and could be declared final | 341 |
| Avoid using if statements without curly braces | 346–347 |
| Parameter 'markables' is not assigned and could be declared final | 351 |
| Avoid using if statements without curly braces | 356–357 |
| Parameter 'attribution' is not assigned and could be declared final | 361 |
| Avoid using if statements without curly braces | 366–367 |
| Parameter 'factualities' is not assigned and could be declared final | 371 |
ks-populator-naf - eu/fbk/knowledgestore/populator/naf/model/NafHeader.java
| Violation | Line |
|---|---|
| Parameter 'value' is not assigned and could be declared final | 57 |
| Parameter 'value' is not assigned and could be declared final | 81 |
ks-populator-naf - eu/fbk/knowledgestore/populator/naf/model/Nt.java
| Violation | Line |
|---|---|
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 33 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 36 |
| Parameter 'value' is not assigned and could be declared final | 58 |
| Parameter 'value' is not assigned and could be declared final | 82 |
ks-populator-naf - eu/fbk/knowledgestore/populator/naf/model/ObjectFactory.java
| Violation | Line |
|---|---|
| Document empty constructor | 36–37 |
ks-populator-naf - eu/fbk/knowledgestore/populator/naf/model/Opinion.java
| Violation | Line |
|---|---|
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 38 |
| Parameter 'value' is not assigned and could be declared final | 66 |
ks-populator-naf - eu/fbk/knowledgestore/populator/naf/model/OpinionExpression.java
| Violation | Line |
|---|---|
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 35 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 38 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 41 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 44 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 47 |
| Parameter 'value' is not assigned and could be declared final | 71 |
| Parameter 'value' is not assigned and could be declared final | 95 |
| Parameter 'value' is not assigned and could be declared final | 119 |
| Parameter 'value' is not assigned and could be declared final | 143 |
| Parameter 'value' is not assigned and could be declared final | 167 |
ks-populator-naf - eu/fbk/knowledgestore/populator/naf/model/OpinionHolder.java
| Violation | Line |
|---|---|
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 35 |
| Parameter 'value' is not assigned and could be declared final | 59 |
ks-populator-naf - eu/fbk/knowledgestore/populator/naf/model/OpinionTarget.java
| Violation | Line |
|---|---|
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 35 |
| Parameter 'value' is not assigned and could be declared final | 59 |
ks-populator-naf - eu/fbk/knowledgestore/populator/naf/model/Predicate.java
| Violation | Line |
|---|---|
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 39 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 42 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 45 |
| Parameter 'value' is not assigned and could be declared final | 75 |
| Parameter 'value' is not assigned and could be declared final | 99 |
| Parameter 'value' is not assigned and could be declared final | 123 |
| Parameter 'span' is not assigned and could be declared final | 162 |
ks-populator-naf - eu/fbk/knowledgestore/populator/naf/model/PredicateAnchor.java
| Violation | Line |
|---|---|
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 38 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 41 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 44 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 47 |
| Parameter 'value' is not assigned and could be declared final | 71 |
| Parameter 'value' is not assigned and could be declared final | 95 |
| Parameter 'value' is not assigned and could be declared final | 119 |
| Parameter 'value' is not assigned and could be declared final | 143 |
ks-populator-naf - eu/fbk/knowledgestore/populator/naf/model/Public.java
| Violation | Line |
|---|---|
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 30 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 33 |
| Parameter 'value' is not assigned and could be declared final | 55 |
| Parameter 'value' is not assigned and could be declared final | 79 |
ks-populator-naf - eu/fbk/knowledgestore/populator/naf/model/Raw.java
| Violation | Line |
|---|---|
| Parameter 'value' is not assigned and could be declared final | 51 |
ks-populator-naf - eu/fbk/knowledgestore/populator/naf/model/Role.java
| Violation | Line |
|---|---|
| Avoid unused imports such as 'javax.xml.bind.annotation.XmlElements' | 18 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 40 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 43 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 46 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 49 |
| Parameter 'value' is not assigned and could be declared final | 75 |
| Parameter 'value' is not assigned and could be declared final | 99 |
| Parameter 'value' is not assigned and could be declared final | 123 |
| Parameter 'value' is not assigned and could be declared final | 147 |
| Parameter 'externalReferences' is not assigned and could be declared final | 158 |
| Parameter 'span' is not assigned and could be declared final | 166 |
ks-populator-naf - eu/fbk/knowledgestore/populator/naf/model/Sentiment.java
| Violation | Line |
|---|---|
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 30 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 33 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 36 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 39 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 42 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 45 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 48 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 51 |
| Parameter 'value' is not assigned and could be declared final | 73 |
| Parameter 'value' is not assigned and could be declared final | 97 |
| Parameter 'value' is not assigned and could be declared final | 121 |
| Parameter 'value' is not assigned and could be declared final | 145 |
| Parameter 'value' is not assigned and could be declared final | 169 |
| Parameter 'value' is not assigned and could be declared final | 193 |
| Parameter 'value' is not assigned and could be declared final | 217 |
| Parameter 'value' is not assigned and could be declared final | 241 |
ks-populator-naf - eu/fbk/knowledgestore/populator/naf/model/Statement.java
| Violation | Line |
|---|---|
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 38 |
| Parameter 'value' is not assigned and could be declared final | 66 |
ks-populator-naf - eu/fbk/knowledgestore/populator/naf/model/StatementCue.java
| Violation | Line |
|---|---|
| Parameter 'value' is not assigned and could be declared final | 51 |
ks-populator-naf - eu/fbk/knowledgestore/populator/naf/model/StatementSource.java
| Violation | Line |
|---|---|
| Parameter 'value' is not assigned and could be declared final | 51 |
ks-populator-naf - eu/fbk/knowledgestore/populator/naf/model/StatementTarget.java
| Violation | Line |
|---|---|
| Parameter 'value' is not assigned and could be declared final | 51 |
ks-populator-naf - eu/fbk/knowledgestore/populator/naf/model/T.java
| Violation | Line |
|---|---|
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 35 |
| Parameter 'value' is not assigned and could be declared final | 59 |
| Parameter 'value' is not assigned and could be declared final | 83 |
ks-populator-naf - eu/fbk/knowledgestore/populator/naf/model/Target.java
| Violation | Line |
|---|---|
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 31 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 34 |
| Parameter 'value' is not assigned and could be declared final | 56 |
| Parameter 'value' is not assigned and could be declared final | 80 |
ks-populator-naf - eu/fbk/knowledgestore/populator/naf/model/TemporalRelations.java
| Violation | Line |
|---|---|
| Avoid unused imports such as 'javax.xml.bind.annotation.XmlElements' | 16 |
| Parameter 'tlink' is not assigned and could be declared final | 39 |
| Avoid using if statements without curly braces | 43–44 |
| Parameter 'predicateAnchor' is not assigned and could be declared final | 47 |
ks-populator-naf - eu/fbk/knowledgestore/populator/naf/model/Term.java
| Violation | Line |
|---|---|
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 39 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 42 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 45 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 48 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 51 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 54 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 57 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 60 |
| Parameter 'value' is not assigned and could be declared final | 89 |
| Parameter 'value' is not assigned and could be declared final | 113 |
| Parameter 'value' is not assigned and could be declared final | 137 |
| Parameter 'value' is not assigned and could be declared final | 161 |
| Parameter 'value' is not assigned and could be declared final | 185 |
| Parameter 'value' is not assigned and could be declared final | 209 |
| Parameter 'value' is not assigned and could be declared final | 233 |
| Parameter 'value' is not assigned and could be declared final | 257 |
ks-populator-naf - eu/fbk/knowledgestore/populator/naf/model/Timex3.java
| Violation | Line |
|---|---|
| Avoid unused imports such as 'java.util.ArrayList' | 11 |
| Avoid unused imports such as 'java.util.List' | 12 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 40 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 43 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 46 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 49 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 52 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 55 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 58 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 61 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 64 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 67 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 70 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 73 |
| Parameter 'value' is not assigned and could be declared final | 98 |
| Parameter 'value' is not assigned and could be declared final | 122 |
| Parameter 'value' is not assigned and could be declared final | 146 |
| Parameter 'value' is not assigned and could be declared final | 170 |
| Parameter 'value' is not assigned and could be declared final | 194 |
| Parameter 'value' is not assigned and could be declared final | 218 |
| Parameter 'value' is not assigned and could be declared final | 242 |
| Parameter 'value' is not assigned and could be declared final | 266 |
| Parameter 'value' is not assigned and could be declared final | 290 |
| Parameter 'value' is not assigned and could be declared final | 314 |
| Parameter 'value' is not assigned and could be declared final | 338 |
| Parameter 'value' is not assigned and could be declared final | 362 |
| Avoid using if statements without curly braces | 367–368 |
| Parameter 'span' is not assigned and could be declared final | 372 |
ks-populator-naf - eu/fbk/knowledgestore/populator/naf/model/Tlink.java
| Violation | Line |
|---|---|
| Avoid unused imports such as 'javax.xml.bind.annotation.XmlIDREF' | 15 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 34 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 41 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 44 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 47 |
| Parameter 'value' is not assigned and could be declared final | 69 |
| Parameter 'from' is not assigned and could be declared final | 80 |
| Parameter 'to' is not assigned and could be declared final | 88 |
| Parameter 'value' is not assigned and could be declared final | 112 |
| Parameter 'value' is not assigned and could be declared final | 136 |
| Parameter 'value' is not assigned and could be declared final | 160 |
ks-populator-naf - eu/fbk/knowledgestore/populator/naf/model/Topic.java
| Violation | Line |
|---|---|
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 33 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 36 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 39 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 42 |
| Parameter 'value' is not assigned and could be declared final | 66 |
| Parameter 'value' is not assigned and could be declared final | 90 |
| Parameter 'value' is not assigned and could be declared final | 114 |
| Parameter 'value' is not assigned and could be declared final | 138 |
| Parameter 'value' is not assigned and could be declared final | 162 |
ks-populator-naf - eu/fbk/knowledgestore/populator/naf/model/Tree.java
| Violation | Line |
|---|---|
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 36 |
| Parameter 'value' is not assigned and could be declared final | 64 |
ks-populator-naf - eu/fbk/knowledgestore/populator/naf/model/Tunits.java
| Violation | Line |
|---|---|
| Parameter 'value' is not assigned and could be declared final | 51 |
ks-populator-naf - eu/fbk/knowledgestore/populator/naf/model/Wf.java
| Violation | Line |
|---|---|
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 36 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 39 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 42 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 45 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 48 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 51 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 54 |
| Parameter 'value' is not assigned and could be declared final | 78 |
| Parameter 'value' is not assigned and could be declared final | 102 |
| Parameter 'value' is not assigned and could be declared final | 126 |
| Parameter 'value' is not assigned and could be declared final | 150 |
| Parameter 'value' is not assigned and could be declared final | 174 |
| Parameter 'value' is not assigned and could be declared final | 198 |
| Parameter 'value' is not assigned and could be declared final | 222 |
| Parameter 'value' is not assigned and could be declared final | 246 |
ks-populator-naf - eu/fbk/knowledgestore/populator/naf/nafPopulator.java
| Violation | Line |
|---|---|
| The class 'nafPopulator' has a Standard Cyclomatic Complexity of 7 (Highest = 32). | 24–411 |
| All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 24–411 |
| The class 'nafPopulator' has a Modified Cyclomatic Complexity of 7 (Highest = 32). | 24–411 |
| Too many fields | 24–411 |
| The class 'nafPopulator' has a Cyclomatic Complexity of 10 (Highest = 50). | 24–411 |
| Avoid using redundant field initializer for 'printToFile' | 32 |
| Avoid using redundant field initializer for 'recursion' | 32 |
| Avoid using redundant field initializer for 'JobFinished' | 32 |
| Avoid using redundant field initializer for 'store_partial_info' | 33 |
| Avoid using redundant field initializer for 'FInFile' | 34 |
| Avoid using redundant field initializer for 'ZInFile' | 35 |
| Avoid using redundant field initializer for 'TInFile' | 36 |
| Avoid using redundant field initializer for 'timeout' | 37 |
| Avoid using redundant field initializer for 'session' | 42 |
| Avoid using redundant field initializer for 'store' | 43 |
| The method 'main' has a Cyclomatic Complexity of 50. | 63–254 |
| Parameter 'args' is not assigned and could be declared final | 63 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 63 |
| The method 'main' has a Standard Cyclomatic Complexity of 32. | 63–254 |
| The method 'main' has a Modified Cyclomatic Complexity of 32. | 63–254 |
| Avoid really long methods. | 63–254 |
| The method main() has an NPath complexity of 1364787202 | 63–254 |
| The method main() has an NCSS line count of 116 | 63–254 |
| Local variable 'COM_SUN_JERSEY_LOGGER' could be declared final | 111 |
| Local variable 'tst' could be declared final | 153 |
| Local variable 'tst' could be declared final | 163 |
| Useless parentheses. | 184 |
| Avoid instantiating new objects inside loops | 230 |
| Local variable 'a' could be declared final | 230 |
| Local variable 'finalizeThreadObj' could be declared final | 236 |
| Parameter 'options' is not assigned and could be declared final | 299 |
| Local variable 'WIDTH' could be declared final | 300 |
| Parameter 'st' is not assigned and could be declared final | 313 |
| Local variable 'resourceName' could be declared final | 347 |
| Local variable 'url' could be declared final | 348 |
| Local variable 'jc' could be declared final | 350 |
| Local variable 'unmarshaller' could be declared final | 351 |
| Local variable 'myFile' could be declared final | 353–354 |
| Position literals first in String comparisons | 356 |
| The method 'checkSession' has a Cyclomatic Complexity of 12. | 369–399 |
| Singleton is not thread safe | 371–374 |
| Singleton is not thread safe | 375–378 |
ks-populator-naf - eu/fbk/knowledgestore/populator/naf/processNAF.java
| Violation | Line |
|---|---|
| Possible God class (WMC=385, ATFD=637, TCC=0.0) | 1–2240 |
| The class 'processNAF' has a Standard Cyclomatic Complexity of 7 (Highest = 51). | 27–2240 |
| The class 'processNAF' has a Modified Cyclomatic Complexity of 7 (Highest = 51). | 27–2240 |
| All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 27–2240 |
| The class 'processNAF' has a Cyclomatic Complexity of 8 (Highest = 55). | 27–2240 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 29 |
| Parameter 'args' is not assigned and could be declared final | 29 |
| Local variable 'vars' could be declared final | 44 |
| Parameter 'fPath' is not assigned and could be declared final | 49 |
| Parameter 'disabled_Items' is not assigned and could be declared final | 49 |
| Parameter 'inout' is not assigned and could be declared final | 49 |
| Parameter 'store_partical_info' is not assigned and could be declared final | 50 |
| Local variable 'vars' could be declared final | 51 |
| Local variable 'returned' could be declared final | 58 |
| Parameter 'disabled_Items' is not assigned and could be declared final | 72 |
| Parameter 'vars' is not assigned and could be declared final | 72 |
| Parameter 'path' is not assigned and could be declared final | 72 |
| Local variable 'listOfFiles' could be declared final | 79 |
| Parameter 'disabled_Items' is not assigned and could be declared final | 101 |
| Parameter 'vars' is not assigned and could be declared final | 101 |
| Parameter 'filepath' is not assigned and could be declared final | 101 |
| Local variable 'header' could be declared final | 114 |
| Local variable 'raw' could be declared final | 116 |
| Local variable 'st' could be declared final | 135 |
| The method getEntitiesMentions() has an NCSS line count of 152 | 166–435 |
| The method 'getEntitiesMentions' has a Standard Cyclomatic Complexity of 44. | 166–435 |
| Parameter 'disabledItems' is not assigned and could be declared final | 166 |
| Avoid really long methods. | 166–435 |
| The method 'getEntitiesMentions' has a Cyclomatic Complexity of 55. | 166–435 |
| The method getEntitiesMentions() has an NPath complexity of 162906 | 166–435 |
| The method 'getEntitiesMentions' has a Modified Cyclomatic Complexity of 44. | 166–435 |
| Parameter 'obj' is not assigned and could be declared final | 166 |
| Local variable 'entObj' could be declared final | 173 |
| Local variable 'generalEntObj' could be declared final | 180 |
| Local variable 'spansObj' could be declared final | 194 |
| Local variable 'm' could be declared final | 203 |
| Prefer StringBuffer over += for concatenating strings | 204 |
| Prefer StringBuffer over += for concatenating strings | 206 |
| Prefer StringBuffer over += for concatenating strings | 211 |
| Prefer StringBuffer over += for concatenating strings | 216 |
| Local variable 'dbpedia' could be declared final | 222 |
| Local variable 'keepEntityTypeProvidedByNaf' could be declared final | 222 |
| Use equals() to compare strings instead of '==' or '!=' | 225 |
| Local variable 'dynamicTypeUri' could be declared final | 233–234 |
| Prefer StringBuffer over += for concatenating strings | 236 |
| Prefer StringBuffer over += for concatenating strings | 243 |
| Local variable 'dynamicTypeUri' could be declared final | 278–279 |
| Prefer StringBuffer over += for concatenating strings | 281 |
| These nested if statements could be combined | 287–311 |
| Local variable 'charS2' could be declared final | 288–289 |
| Position literals first in String comparisons for EqualsIgnoreCase | 291 |
| Position literals first in String comparisons for EqualsIgnoreCase | 294 |
| Position literals first in String comparisons for EqualsIgnoreCase | 297 |
| Position literals first in String comparisons for EqualsIgnoreCase | 300 |
| Position literals first in String comparisons for EqualsIgnoreCase | 303 |
| Position literals first in String comparisons for EqualsIgnoreCase | 306 |
| Position literals first in String comparisons for EqualsIgnoreCase | 306 |
| Local variable 'externalRefs' could be declared final | 322 |
| Avoid unused local variables such as 'firstTimeFlag'. | 333 |
| Local variable 'firstTimeFlag' could be declared final | 333 |
| Local variable 'exRObj' could be declared final | 341 |
| Local variable 'referenceValue' could be declared final | 354 |
| Avoid instantiating new objects inside loops | 355 |
| Avoid instantiating String objects; this is usually unnecessary. | 355 |
| Local variable 'exrEn' could be declared final | 361 |
| Avoid instantiating new objects inside loops | 361 |
| Avoid instantiating new objects inside loops | 362 |
| Local variable 'exrEs' could be declared final | 362 |
| Local variable 'exrIt' could be declared final | 363 |
| Avoid instantiating new objects inside loops | 363 |
| Local variable 'exrNl' could be declared final | 364 |
| Avoid instantiating new objects inside loops | 364 |
| Local variable 'exRObj' could be declared final | 366 |
| Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 374 |
| Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 376 |
| Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 378 |
| Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 380 |
| Avoid instantiating String objects; this is usually unnecessary. | 385 |
| Avoid instantiating new objects inside loops | 385 |
| Local variable 'chosenReferenceURI' could be declared final | 411 |
| Avoid instantiating new objects inside loops | 411 |
| Prefer StringBuffer over += for concatenating strings | 416 |
| Prefer StringBuffer over += for concatenating strings | 420 |
| The method 'getAllLayersOfExternalReferences' has a Modified Cyclomatic Complexity of 11. | 437–482 |
| The method 'getAllLayersOfExternalReferences' has a Cyclomatic Complexity of 16. | 437–482 |
| Parameter 'exrEn' is not assigned and could be declared final | 437 |
| Parameter 'modeactive' is not assigned and could be declared final | 437 |
| The method 'getAllLayersOfExternalReferences' has a Standard Cyclomatic Complexity of 14. | 437–482 |
| Parameter 'exRObj' is not assigned and could be declared final | 438 |
| Parameter 'exrEs' is not assigned and could be declared final | 438 |
| Parameter 'exrIt' is not assigned and could be declared final | 438 |
| Parameter 'exrNl' is not assigned and could be declared final | 439 |
| Parameter 'vars' is not assigned and could be declared final | 439 |
| Switch statements should have a default label | 443–456 |
| Local variable 'ff' could be declared final | 476 |
| Parameter 'exrl' is not assigned and could be declared final | 485 |
| Local variable 'tmp' could be declared final | 488 |
| Local variable 'co' could be declared final | 489 |
| The method 'getTimeExpressionsMentions' has a Standard Cyclomatic Complexity of 17. | 507–604 |
| The method 'getTimeExpressionsMentions' has a Modified Cyclomatic Complexity of 17. | 507–604 |
| The method getTimeExpressionsMentions() has an NPath complexity of 110594 | 507–604 |
| The method 'getTimeExpressionsMentions' has a Cyclomatic Complexity of 21. | 507–604 |
| Parameter 'obj' is not assigned and could be declared final | 507 |
| Local variable 'tmxObj' could be declared final | 513 |
| Local variable 'tmxSpan' could be declared final | 515 |
| Local variable 'tmxTypeUC' could be declared final | 516 |
| Local variable 'keepTimeTypeProvidedByNaf' could be declared final | 517 |
| Useless parentheses. | 520 |
| Useless parentheses. | 520 |
| Local variable 'm' could be declared final | 526 |
| Prefer StringBuffer over += for concatenating strings | 529 |
| Local variable 'wordsL' could be declared final | 531 |
| Prefer StringBuffer over += for concatenating strings | 533 |
| Local variable 'dynamicTypeUri' could be declared final | 536–537 |
| When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 537 |
| Prefer StringBuffer over += for concatenating strings | 539 |
| Prefer StringBuffer over += for concatenating strings | 546 |
| Prefer StringBuffer over += for concatenating strings | 556 |
| Prefer StringBuffer over += for concatenating strings | 560 |
| Prefer StringBuffer over += for concatenating strings | 564 |
| Prefer StringBuffer over += for concatenating strings | 568 |
| Prefer StringBuffer over += for concatenating strings | 572 |
| Prefer StringBuffer over += for concatenating strings | 576 |
| Prefer StringBuffer over += for concatenating strings | 580 |
| Prefer StringBuffer over += for concatenating strings | 584 |
| Prefer StringBuffer over += for concatenating strings | 588 |
| Prefer StringBuffer over += for concatenating strings | 592 |
| Local variable 'addedNew' could be declared final | 595 |
| Local variable 'charS2' could be declared final | 600–601 |
| Parameter 'obj' is not assigned and could be declared final | 606 |
| Avoid unused private methods such as 'getFactualityMentions(Factualitylayer,processNAFVariables)'. | 606 |
| Local variable 'fvObj' could be declared final | 612 |
| Local variable 'm' could be declared final | 614 |
| Prefer StringBuffer over += for concatenating strings | 617 |
| Local variable 'tarlist' could be declared final | 619 |
| Avoid instantiating new objects inside loops | 619 |
| Avoid instantiating new objects inside loops | 620 |
| Local variable 'tmp' could be declared final | 620 |
| Local variable 'wordsL' could be declared final | 623 |
| Prefer StringBuffer over += for concatenating strings | 625 |
| Prefer StringBuffer over += for concatenating strings | 631 |
| Local variable 'addedNew' could be declared final | 634 |
| Local variable 'charS2' could be declared final | 639–640 |
| Parameter 'factualities' is not assigned and could be declared final | 647 |
| Local variable 'fvObj' could be declared final | 653 |
| Local variable 'm' could be declared final | 656 |
| Prefer StringBuffer over += for concatenating strings | 659 |
| Local variable 'tarlist' could be declared final | 661 |
| Avoid instantiating new objects inside loops | 661 |
| Local variable 't' could be declared final | 662 |
| Local variable 'wordsL' could be declared final | 665 |
| Prefer StringBuffer over += for concatenating strings | 667 |
| Local variable 'tts' could be declared final | 669 |
| Local variable 'addedNew' could be declared final | 675 |
| Local variable 'charS2' could be declared final | 680–681 |
| Parameter 'causalRelations' is not assigned and could be declared final | 687 |
| Local variable 'fvObj' could be declared final | 693 |
| Local variable 'm' could be declared final | 696 |
| Prefer StringBuffer over += for concatenating strings | 699 |
| Avoid instantiating new objects inside loops | 702 |
| Local variable 'tarlist' could be declared final | 702 |
| Local variable 'from' could be declared final | 703 |
| Local variable 'to' could be declared final | 704 |
| Local variable 'fromwl' could be declared final | 708 |
| Local variable 'mtest1' could be declared final | 709 |
| Local variable 'towl' could be declared final | 713 |
| Local variable 'mtest2' could be declared final | 714 |
| Local variable 'wordsL' could be declared final | 718 |
| Prefer StringBuffer over += for concatenating strings | 720 |
| Local variable 'addedNew' could be declared final | 723 |
| Parameter 'temporalRelations' is not assigned and could be declared final | 733 |
| The method getTLinksMentions() has an NPath complexity of 13832 | 733–842 |
| Avoid really long methods. | 733–842 |
| The method 'getTLinksMentions' has a Cyclomatic Complexity of 17. | 733–842 |
| The method 'getTLinksMentions' has a Standard Cyclomatic Complexity of 17. | 733–842 |
| The method 'getTLinksMentions' has a Modified Cyclomatic Complexity of 17. | 733–842 |
| Local variable 'fvObj' could be declared final | 748 |
| Local variable 'm' could be declared final | 751 |
| Prefer StringBuffer over += for concatenating strings | 754 |
| Local variable 'tarlist' could be declared final | 757 |
| Avoid instantiating new objects inside loops | 757 |
| Avoid instantiating new objects inside loops | 758 |
| Avoid instantiating new objects inside loops | 759 |
| Avoid instantiating new objects inside loops | 775 |
| Avoid instantiating new objects inside loops | 776 |
| Local variable 'mtest2' could be declared final | 796 |
| Local variable 'returned' could be declared final | 798–799 |
| Local variable 'mtest1' could be declared final | 808 |
| Local variable 'returned' could be declared final | 810–811 |
| Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 819 |
| Local variable 'mtest1' could be declared final | 820 |
| Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 824 |
| Local variable 'mtest2' could be declared final | 825 |
| Prefer StringBuffer over += for concatenating strings | 831 |
| Local variable 'addedNew' could be declared final | 834 |
| Parameter 'value' is not assigned and could be declared final | 844 |
| Parameter 'key' is not assigned and could be declared final | 844 |
| Parameter 'mention' is not assigned and could be declared final | 845 |
| Parameter 'vars' is not assigned and could be declared final | 845 |
| Local variable 'charS' could be declared final | 846–847 |
| Parameter 'list' is not assigned and could be declared final | 855 |
| Parameter 'vars' is not assigned and could be declared final | 856 |
| Local variable 'tmp' could be declared final | 857 |
| Local variable 'wftmp' could be declared final | 859 |
| Parameter 'tmxId' is not assigned and could be declared final | 876 |
| Parameter 'vars' is not assigned and could be declared final | 876 |
| Local variable 'tmp' could be declared final | 877 |
| Local variable 'tms' could be declared final | 878 |
| Local variable 't' could be declared final | 880 |
| Parameter 'predicateId' is not assigned and could be declared final | 889 |
| Parameter 'vars' is not assigned and could be declared final | 890 |
| Local variable 'pr' could be declared final | 891 |
| Parameter 'value' is not assigned and could be declared final | 899 |
| Parameter 'type' is not assigned and could be declared final | 899 |
| Position literals first in String comparisons for EqualsIgnoreCase | 901 |
| Position literals first in String comparisons for EqualsIgnoreCase | 903 |
| Position literals first in String comparisons for EqualsIgnoreCase | 905 |
| Position literals first in String comparisons for EqualsIgnoreCase | 907 |
| Position literals first in String comparisons for EqualsIgnoreCase | 909 |
| The method 'getSRLMentions' has a Cyclomatic Complexity of 54. | 919–1331 |
| The method getSRLMentions() has an NCSS line count of 213 | 919–1331 |
| Avoid really long methods. | 919–1331 |
| The method 'getSRLMentions' has a Standard Cyclomatic Complexity of 51. | 919–1331 |
| The method 'getSRLMentions' has a Modified Cyclomatic Complexity of 51. | 919–1331 |
| The method getSRLMentions() has an NPath complexity of 109109622 | 919–1331 |
| Local variable 'obj' could be declared final | 920 |
| Useless parentheses. | 927 |
| Useless parentheses. | 927 |
| Local variable 'prdObj' could be declared final | 934 |
| Local variable 'predicateID' could be declared final | 937 |
| Local variable 'eventTermList' could be declared final | 942 |
| Avoid instantiating new objects inside loops | 942 |
| Local variable 'tars' could be declared final | 960 |
| Local variable 'eventTerm' could be declared final | 962 |
| Prefer StringBuffer over += for concatenating strings | 966 |
| Local variable 'posVal' could be declared final | 969–972 |
| Useless parentheses. | 969–970 |
| Prefer StringBuffer over += for concatenating strings | 974 |
| Prefer StringBuffer over += for concatenating strings | 978 |
| Local variable 'prds' could be declared final | 986 |
| Local variable 'tprd' could be declared final | 987 |
| Local variable 'wfL' could be declared final | 990–992 |
| Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 993 |
| Local variable 'mtest1' could be declared final | 994 |
| Local variable 'wfL' could be declared final | 1001–1003 |
| Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 1004 |
| Local variable 'mtest1' could be declared final | 1005 |
| Local variable 'wfL' could be declared final | 1012–1013 |
| Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 1014 |
| Local variable 'mtest1' could be declared final | 1015 |
| Prefer StringBuffer over += for concatenating strings | 1021 |
| Local variable 'prdGObj' could be declared final | 1026 |
| Local variable 'exrObj' could be declared final | 1038 |
| Local variable 'resourceValue' could be declared final | 1042 |
| Local variable 'referenceValue' could be declared final | 1043 |
| Position literals first in String comparisons for EqualsIgnoreCase | 1049 |
| When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 1059 |
| Avoid instantiating new objects inside loops | 1060–1061 |
| When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 1061 |
| Prefer StringBuffer over += for concatenating strings | 1064 |
| Prefer StringBuffer over += for concatenating strings | 1079 |
| Prefer StringBuffer over += for concatenating strings | 1096 |
| Local variable 'addedNew' could be declared final | 1101 |
| Local variable 'charS2' could be declared final | 1110–1111 |
| Avoid unused local variables such as 'MenCreated'. | 1135 |
| Local variable 'roleSpan' could be declared final | 1140 |
| Local variable 'roleCharSpan' could be declared final | 1141 |
| Local variable 'semRole' could be declared final | 1146 |
| Useless parentheses. | 1147 |
| Useless parentheses. | 1147 |
| These nested if statements could be combined | 1166–1189 |
| Local variable 'roleM' could be declared final | 1167 |
| Avoid instantiating new objects inside loops | 1173 |
| Local variable 'rspnTar' could be declared final | 1174 |
| Local variable 'ttmp' could be declared final | 1175 |
| Local variable 'relationM' could be declared final | 1199 |
| Avoid instantiating new objects inside loops | 1205 |
| Prefer StringBuffer over += for concatenating strings | 1206 |
| Local variable 'roleId' could be declared final | 1216 |
| Prefer StringBuffer over += for concatenating strings | 1226 |
| Prefer StringBuffer over += for concatenating strings | 1228 |
| Prefer StringBuffer over += for concatenating strings | 1232 |
| Avoid instantiating new objects inside loops | 1241 |
| Local variable 'rspnTar' could be declared final | 1242 |
| Local variable 'ttmp' could be declared final | 1243 |
| Prefer StringBuffer over += for concatenating strings | 1249 |
| Local variable 'create' could be declared final | 1250 |
| Local variable 'roleGOBJ' could be declared final | 1287 |
| Local variable 'rexRefObj' could be declared final | 1288 |
| Local variable 'resourceValue' could be declared final | 1292 |
| Local variable 'referenceValue' could be declared final | 1293 |
| When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 1306 |
| Avoid instantiating new objects inside loops | 1307–1308 |
| When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 1308 |
| Prefer StringBuffer over += for concatenating strings | 1313 |
| Parameter 'id' is not assigned and could be declared final | 1333 |
| Parameter 'vars' is not assigned and could be declared final | 1334 |
| Local variable 'tmp' could be declared final | 1335 |
| Local variable 'pas' could be declared final | 1336 |
| Local variable 't' could be declared final | 1337 |
| Local variable 'tm' could be declared final | 1338 |
| The method 'getNAFHEADERMentions' has a Cyclomatic Complexity of 24. | 1349–1487 |
| Parameter 'vars' is not assigned and could be declared final | 1349 |
| The method 'getNAFHEADERMentions' has a Modified Cyclomatic Complexity of 23. | 1349–1487 |
| The method 'getNAFHEADERMentions' has a Standard Cyclomatic Complexity of 23. | 1349–1487 |
| Avoid really long methods. | 1349–1487 |
| Parameter 'obj' is not assigned and could be declared final | 1349 |
| The method getNAFHEADERMentions() has an NPath complexity of 1394000 | 1349–1487 |
| Local variable 'publicProp' could be declared final | 1352 |
| Local variable 'newsFile' could be declared final | 1354 |
| Local variable 'nafFile' could be declared final | 1355 |
| Prefer StringBuffer over += for concatenating strings | 1360 |
| Prefer StringBuffer over += for concatenating strings | 1362 |
| Prefer StringBuffer over += for concatenating strings | 1369 |
| Local variable 'preStr' could be declared final | 1378 |
| Local variable 'postStr' could be declared final | 1379 |
| Local variable 'srcUrlstr' could be declared final | 1380 |
| Prefer StringBuffer over += for concatenating strings | 1390 |
| Prefer StringBuffer over += for concatenating strings | 1394 |
| Prefer StringBuffer over += for concatenating strings | 1403 |
| Prefer StringBuffer over += for concatenating strings | 1407 |
| Prefer StringBuffer over += for concatenating strings | 1411 |
| Prefer StringBuffer over += for concatenating strings | 1416 |
| Prefer StringBuffer over += for concatenating strings | 1421 |
| Prefer StringBuffer over += for concatenating strings | 1426 |
| Prefer StringBuffer over += for concatenating strings | 1431 |
| Prefer StringBuffer over += for concatenating strings | 1436 |
| Prefer StringBuffer over += for concatenating strings | 1441 |
| Prefer StringBuffer over += for concatenating strings | 1446 |
| Local variable 'lpObj' could be declared final | 1451 |
| Prefer StringBuffer over += for concatenating strings | 1452 |
| Prefer StringBuffer over += for concatenating strings | 1457 |
| Local variable 'lpO' could be declared final | 1464 |
| Prefer StringBuffer over += for concatenating strings | 1465 |
| Local variable 'r3' could be declared final | 1466 |
| Prefer StringBuffer over += for concatenating strings | 1469 |
| Prefer StringBuffer over += for concatenating strings | 1473 |
| Local variable 'namuri' could be declared final | 1475 |
| Local variable 'uri' could be declared final | 1476–1477 |
| Avoid instantiating new objects inside loops | 1479 |
| Local variable 'rId' could be declared final | 1479 |
| Prefer StringBuffer over += for concatenating strings | 1482 |
| Avoid really long methods. | 1489–1637 |
| The method getCoreferencesMentions() has an NPath complexity of 82994 | 1489–1637 |
| The method 'getCoreferencesMentions' has a Modified Cyclomatic Complexity of 23. | 1489–1637 |
| The method 'getCoreferencesMentions' has a Cyclomatic Complexity of 27. | 1489–1637 |
| The method 'getCoreferencesMentions' has a Standard Cyclomatic Complexity of 23. | 1489–1637 |
| Parameter 'obj' is not assigned and could be declared final | 1489 |
| Local variable 'corefObj' could be declared final | 1500 |
| Local variable 'corefType' could be declared final | 1513 |
| Local variable 'corefSpan' could be declared final | 1523 |
| Local variable 'corefCharSpan' could be declared final | 1524 |
| Local variable 'retArray' could be declared final | 1525 |
| Local variable 'inclFlag' could be declared final | 1526 |
| Useless parentheses. | 1527 |
| Useless parentheses. | 1527 |
| Local variable 'includedMentionCharSpan' could be declared final | 1529 |
| Local variable 'corefSpan' could be declared final | 1541 |
| Local variable 'corefCharSpan' could be declared final | 1542 |
| Local variable 'm' could be declared final | 1550 |
| Prefer StringBuffer over += for concatenating strings | 1552 |
| Prefer StringBuffer over += for concatenating strings | 1555 |
| Prefer StringBuffer over += for concatenating strings | 1561 |
| Prefer StringBuffer over += for concatenating strings | 1566 |
| Local variable 'spTar' could be declared final | 1579 |
| Local variable 'eventTerm' could be declared final | 1581 |
| Prefer StringBuffer over += for concatenating strings | 1583 |
| Local variable 'posVal' could be declared final | 1585–1588 |
| Useless parentheses. | 1585–1586 |
| Prefer StringBuffer over += for concatenating strings | 1590 |
| Prefer StringBuffer over += for concatenating strings | 1599 |
| Prefer StringBuffer over += for concatenating strings | 1607 |
| Local variable 'addedNew' could be declared final | 1610 |
| Local variable 'charS2' could be declared final | 1629–1630 |
| Avoid unused private methods such as 'mergeTwoTermLists(LinkedList,LinkedList,processNAFVariables)'. | 1639–1640 |
| Parameter 'eventTermList' is not assigned and could be declared final | 1639 |
| Parameter 'vars' is not assigned and could be declared final | 1640 |
| Parameter 'roleTermList' is not assigned and could be declared final | 1640 |
| Local variable 'merged' could be declared final | 1642 |
| Local variable 'evn' could be declared final | 1646 |
| Local variable 'rol' could be declared final | 1649 |
| Parameter 'charSpan' is not assigned and could be declared final | 1660 |
| Parameter 'vars' is not assigned and could be declared final | 1660 |
| Parameter 'vars' is not assigned and could be declared final | 1670 |
| Parameter 'charSpan' is not assigned and could be declared final | 1670 |
| Local variable 'fields' could be declared final | 1680 |
| Local variable 'spanBeginC' could be declared final | 1681 |
| Local variable 'spanEndC' could be declared final | 1682 |
| Local variable 'keys' could be declared final | 1684 |
| Local variable 'key' could be declared final | 1689 |
| Useless parentheses. | 1693 |
| Useless parentheses. | 1693 |
| Avoid instantiating new objects inside loops | 1694 |
| Parameter 'vars' is not assigned and could be declared final | 1707 |
| Parameter 'sp' is not assigned and could be declared final | 1707 |
| Local variable 'wordsL' could be declared final | 1708 |
| Local variable 'begin' could be declared final | 1709 |
| Local variable 'lastW' could be declared final | 1710 |
| Local variable 'end' could be declared final | 1711 |
| Local variable 'charSpan' could be declared final | 1712 |
| Consider simply returning the value vs storing it in local variable 'charSpan' | 1713 |
| Parameter 'charSpan' is not assigned and could be declared final | 1718 |
| Parameter 'vars' is not assigned and could be declared final | 1718 |
| Parameter 'vars' is not assigned and could be declared final | 1728 |
| Parameter 'charSpan' is not assigned and could be declared final | 1728 |
| Parameter 'vars' is not assigned and could be declared final | 1742 |
| Parameter 'm' is not assigned and could be declared final | 1742 |
| Local variable 'charS' could be declared final | 1743 |
| Local variable 'chk' could be declared final | 1748 |
| Local variable 'types' could be declared final | 1762 |
| Local variable 'types' could be declared final | 1778 |
| Local variable 'mit' could be declared final | 1784 |
| Local variable 'mittmp' could be declared final | 1786 |
| Local variable 'pit' could be declared final | 1788 |
| Parameter 'vars' is not assigned and could be declared final | 1810 |
| Local variable 'keys' could be declared final | 1811 |
| Local variable 'key' could be declared final | 1813 |
| Local variable 'm' could be declared final | 1814 |
| Local variable 'csList' could be declared final | 1818 |
| Local variable 'cStart' could be declared final | 1819 |
| Local variable 'cEnd' could be declared final | 1820 |
| Local variable 'extentStr' could be declared final | 1821 |
| Parameter 'list' is not assigned and could be declared final | 1826 |
| Local variable 'll' could be declared final | 1828 |
| Prefer StringBuffer over += for concatenating strings | 1829 |
| Prefer StringBuffer over += for concatenating strings | 1831 |
| Parameter 'm' is not assigned and could be declared final | 1835 |
| Parameter 'm2' is not assigned and could be declared final | 1835 |
| Local variable 'types' could be declared final | 1836 |
| Local variable 'types1' could be declared final | 1837 |
| Local variable 'tytmp' could be declared final | 1838 |
| Parameter 'oldM' is not assigned and could be declared final | 1846 |
| Parameter 'newM' is not assigned and could be declared final | 1846 |
| Local variable 'typesOld' could be declared final | 1852 |
| Local variable 'typesNew' could be declared final | 1853 |
| Useless parentheses. | 1854–1855 |
| Local variable 'isGenericOldM' could be declared final | 1854–1855 |
| Useless parentheses. | 1856–1857 |
| Useless parentheses. | 1856–1859 |
| Useless parentheses. | 1856–1857 |
| Local variable 'isSpecificNewM' could be declared final | 1856–1859 |
| Avoid unnecessary if..then..else statements when returning booleans | 1864–1868 |
| Parameter 'publicProp' is not assigned and could be declared final | 1871 |
| Parameter 'vars' is not assigned and could be declared final | 1871 |
| Local variable 'uri' could be declared final | 1877 |
| Local variable 'nafuri' could be declared final | 1881 |
| Local variable 'nurl' could be declared final | 1888 |
| Local variable 'p' could be declared final | 1889 |
| Parameter 'wordsL' is not assigned and could be declared final | 1897 |
| Parameter 'm' is not assigned and could be declared final | 1897 |
| Parameter 'vars' is not assigned and could be declared final | 1897 |
| Local variable 'begin' could be declared final | 1898 |
| Local variable 'end' could be declared final | 1899–1900 |
| Local variable 'tmpid' could be declared final | 1903 |
| Local variable 'mId' could be declared final | 1904 |
| Parameter 'vars' is not assigned and could be declared final | 1908 |
| Parameter 'error' is not assigned and could be declared final | 1908 |
| Parameter 'vars' is not assigned and could be declared final | 1919 |
| Parameter 'error' is not assigned and could be declared final | 1919 |
| Parameter 'vars' is not assigned and could be declared final | 1925 |
| Parameter 'error' is not assigned and could be declared final | 1925 |
| Parameter 'vars' is not assigned and could be declared final | 1929 |
| Parameter 'vars' is not assigned and could be declared final | 1941 |
| Parameter 'vars' is not assigned and could be declared final | 1945 |
| Parameter 'm' is not assigned and could be declared final | 1949 |
| Parameter 'spansObj' is not assigned and could be declared final | 1949 |
| Parameter 'vars' is not assigned and could be declared final | 1949 |
| Local variable 'wordsL' could be declared final | 1950 |
| Local variable 'begin' could be declared final | 1951 |
| Local variable 'end' could be declared final | 1952–1953 |
| Local variable 'muri' could be declared final | 1956 |
| Local variable 'mId' could be declared final | 1957 |
| Parameter 'eventTermList' is not assigned and could be declared final | 1964 |
| Parameter 'roleTermList' is not assigned and could be declared final | 1965 |
| Parameter 'vars' is not assigned and could be declared final | 1966 |
| Parameter 'm' is not assigned and could be declared final | 1966 |
| Local variable 'eventWordList' could be declared final | 1967 |
| Local variable 'roleWordList' could be declared final | 1968 |
| Local variable 'charStartOfEvent' could be declared final | 1970 |
| Local variable 'charEndOfEvent' could be declared final | 1971–1972 |
| Local variable 'charStartOfRole' could be declared final | 1973 |
| Local variable 'charEndOfRole' could be declared final | 1974–1975 |
| Local variable 'muri' could be declared final | 1988 |
| Local variable 'mId' could be declared final | 1989 |
| Avoid unused private methods such as 'getExtentOfParticipationMention(LinkedList,LinkedList,processNAFVariables)'. | 1996–1997 |
| Parameter 'eventTermList' is not assigned and could be declared final | 1996 |
| Parameter 'roleTermList' is not assigned and could be declared final | 1997 |
| Parameter 'vars' is not assigned and could be declared final | 1997 |
| Local variable 'eventWordList' could be declared final | 1998 |
| Local variable 'roleWordList' could be declared final | 1999 |
| Local variable 'mergedWordList' could be declared final | 2001 |
| Local variable 'charStartOfEvent' could be declared final | 2003 |
| Local variable 'charStartOfRole' could be declared final | 2004 |
| Local variable 'w' could be declared final | 2014 |
| Local variable 'w' could be declared final | 2019 |
| Local variable 'extent' could be declared final | 2025 |
| Local variable 'w' could be declared final | 2026 |
| Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). | 2027 |
| Local variable 'sExtent' could be declared final | 2029 |
| Parameter 'vars' is not assigned and could be declared final | 2036 |
| Avoid unused private methods such as 'checkDuplicate(String,processNAFVariables)'. | 2036 |
| Parameter 'muri' is not assigned and could be declared final | 2036 |
| Local variable 'keys' could be declared final | 2038 |
| Parameter 'vars' is not assigned and could be declared final | 2048 |
| Parameter 'termId' is not assigned and could be declared final | 2048 |
| Local variable 'ltmp' could be declared final | 2054 |
| Parameter 'list' is not assigned and could be declared final | 2064 |
| Parameter 'vars' is not assigned and could be declared final | 2064 |
| Local variable 'returned' could be declared final | 2065 |
| Local variable 'wordsIDL' could be declared final | 2066 |
| Local variable 'ltmp' could be declared final | 2067 |
| Local variable 'wftmp' could be declared final | 2073 |
| Local variable 'prop' could be declared final | 2083 |
| Local variable 'wftmp' could be declared final | 2085 |
| The method getTheWFListByThereTermsFromTargetList() has an NPath complexity of 240 | 2099–2183 |
| The method 'getTheWFListByThereTermsFromTargetList' has a Standard Cyclomatic Complexity of 21. | 2099–2183 |
| The method 'getTheWFListByThereTermsFromTargetList' has a Cyclomatic Complexity of 21. | 2099–2183 |
| Parameter 'targetTermList' is not assigned and could be declared final | 2099 |
| The method 'getTheWFListByThereTermsFromTargetList' has a Modified Cyclomatic Complexity of 21. | 2099–2183 |
| Parameter 'vars' is not assigned and could be declared final | 2100 |
| Local variable 'returned' could be declared final | 2101 |
| Local variable 'wordsIDL' could be declared final | 2102 |
| Avoid unused local variables such as 'spanTermFound'. | 2103 |
| Local variable 'termtmp' could be declared final | 2106 |
| Local variable 'spansl' could be declared final | 2108–2109 |
| Local variable 'spantmp' could be declared final | 2111 |
| Local variable 'targtmp' could be declared final | 2114 |
| Local variable 'prop' could be declared final | 2123 |
| Local variable 'termtmp' could be declared final | 2125 |
| Local variable 'spansl' could be declared final | 2127–2129 |
| Local variable 'spantmp' could be declared final | 2131 |
| Local variable 'targtmp' could be declared final | 2134 |
| Local variable 'wftmp' could be declared final | 2149 |
| Local variable 'prop' could be declared final | 2164 |
| Local variable 'wftmp' could be declared final | 2166 |
| Parameter 'list' is not assigned and could be declared final | 2185 |
| Parameter 'vars' is not assigned and could be declared final | 2185 |
| Local variable 'targetTermList' could be declared final | 2187 |
| Local variable 'targetList' could be declared final | 2188 |
| Local variable 'tarm' could be declared final | 2190 |
| Local variable 'corrispondingWf' could be declared final | 2193 |
| Consider simply returning the value vs storing it in local variable 'corrispondingWf' | 2194 |
| Parameter 'naf' is not assigned and could be declared final | 2197 |
| Parameter 'vars' is not assigned and could be declared final | 2197 |
| Local variable 'jc' could be declared final | 2200 |
| Local variable 'unmarshaller' could be declared final | 2201 |
| Local variable 'bytes' could be declared final | 2202 |
| Local variable 'mb' could be declared final | 2221 |
| Local variable 'runtime' could be declared final | 2224 |
ks-populator-naf - eu/fbk/knowledgestore/populator/naf/processNAFVariables.java
| Violation | Line |
|---|---|
| Avoid unused imports such as 'java.util.LinkedList' | 6 |
| Too many fields | 20–248 |
| Avoid using redundant field initializer for 'mentionCounter' | 24 |
| Avoid using redundant field initializer for 'corefMentionEvent' | 54 |
| Avoid using redundant field initializer for 'srlMention' | 54 |
| Avoid using redundant field initializer for 'timeMention' | 54 |
| Avoid using redundant field initializer for 'entityMen' | 54 |
| Avoid using redundant field initializer for 'corefMention' | 54 |
| Avoid using redundant field initializer for 'entityMen2' | 54 |
| Avoid using redundant field initializer for 'corefMentionNotEvent' | 54 |
| Avoid using redundant field initializer for 'timeMention2' | 55 |
| Avoid using redundant field initializer for 'corefMention2' | 55 |
| Avoid using redundant field initializer for 'srlMention2' | 55 |
| Avoid using redundant field initializer for 'rolewithEntity' | 55 |
| Avoid using redundant field initializer for 'rolewithEntity2' | 56 |
| Avoid using redundant field initializer for 'rolewithoutEntity' | 56 |
| Avoid using redundant field initializer for 'factualityMentions' | 56 |
| Avoid using redundant field initializer for 'factualityMentions2' | 57 |
| Avoid using redundant field initializer for 'roleMentions' | 57 |
| Avoid using redundant field initializer for 'LOC' | 58 |
| Avoid using redundant field initializer for 'ORG' | 58 |
| Avoid using redundant field initializer for 'tlinkMentions' | 58 |
| Avoid using redundant field initializer for 'fin' | 58 |
| Avoid using redundant field initializer for 'mix' | 58 |
| Avoid using redundant field initializer for 'PER' | 58 |
| Avoid using redundant field initializer for 'clinkMentions' | 58 |
| Avoid using redundant field initializer for 'no_mapping' | 58 |
| Avoid using redundant field initializer for 'PRO' | 58 |
| Avoid using redundant field initializer for 'storePartialInforInCaseOfError' | 61 |
| Avoid using redundant field initializer for 'filePath' | 62 |
| Avoid using redundant field initializer for 'tlinkMentionsDiscarded' | 63 |
| Avoid using redundant field initializer for 'clinkMentionsDiscarded' | 64 |
| Avoid using redundant field initializer for 'tlinkMentionsEnriched' | 65 |
| The constructor with 0 parameters has an NCSS line count of 160 | 66–247 |
ks-populator-naf - eu/fbk/knowledgestore/populator/naf/runPopoulator.java
| Violation | Line |
|---|---|
| Avoid unused imports such as 'java.io.File' | 3 |
| Avoid unused imports such as 'java.io.PrintStream' | 5 |
| All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 9–58 |
| Parameter 'args' is not assigned and could be declared final | 21 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 21 |
| Local variable 'argt' could be declared final | 31–53 |
| Local variable 'tt' could be declared final | 54 |
ks-populator-naf - eu/fbk/knowledgestore/populator/naf/statistics.java
| Violation | Line |
|---|---|
| Avoid using redundant field initializer for 'timex' | 5 |
| Avoid using redundant field initializer for 'objectMention' | 5 |
| Avoid using redundant field initializer for 'srl' | 5 |
| Avoid using redundant field initializer for 'entity' | 5 |
| Avoid using redundant field initializer for 'coref' | 5 |
| Avoid using redundant field initializer for 'timeMention' | 6 |
| Avoid using redundant field initializer for 'participationMention' | 6 |
| Avoid using redundant field initializer for 'eventMention' | 6 |
| Avoid using redundant field initializer for 'rolewithEntity' | 6 |
| Avoid using redundant field initializer for 'corefMentionNotEvent' | 7 |
| Avoid using redundant field initializer for 'rolewithoutEntity' | 7 |
| Avoid using redundant field initializer for 'corefMentionEvent' | 7 |
| Avoid using redundant field initializer for 'role' | 7 |
| Avoid using redundant field initializer for 'factuality' | 7 |
| Avoid using redundant field initializer for 'tlinkMention' | 8 |
| Avoid using redundant field initializer for 'tlinkMentionsEnriched' | 8 |
| Avoid using redundant field initializer for 'clinkMentionDiscarded' | 8 |
| Avoid using redundant field initializer for 'clinkMention' | 8 |
| Avoid using redundant field initializer for 'tlinkMentionDiscarded' | 8 |
| Parameter 'tlinkMentionsEnriched' is not assigned and could be declared final | 22 |
| Parameter 'clinkMention' is not assigned and could be declared final | 28 |
| Parameter 'tlinkMention' is not assigned and could be declared final | 40 |
| Parameter 'clinkMentionDiscarded' is not assigned and could be declared final | 52 |
| Parameter 'tlinkMentionDiscarded' is not assigned and could be declared final | 64 |
| Parameter 'corefMentionEvent' is not assigned and could be declared final | 76 |
| Parameter 'corefMentionNotEvent' is not assigned and could be declared final | 88 |
| Avoid using redundant field initializer for 'PRO' | 92 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 92 |
| Avoid using redundant field initializer for 'LOC' | 92 |
| Avoid using redundant field initializer for 'fin' | 92 |
| Avoid using redundant field initializer for 'ORG' | 92 |
| Avoid using redundant field initializer for 'no_mapping' | 92 |
| Avoid using redundant field initializer for 'PER' | 92 |
| Avoid using redundant field initializer for 'mix' | 92 |
| Parameter 'role' is not assigned and could be declared final | 99 |
| Prefer StringBuffer over += for concatenating strings | 105 |
| Prefer StringBuffer over += for concatenating strings | 114 |
| Prefer StringBuffer over += for concatenating strings | 117 |
| Prefer StringBuffer over += for concatenating strings | 118 |
| Prefer StringBuffer over += for concatenating strings | 120 |
| Parameter 'entity' is not assigned and could be declared final | 128 |
| Parameter 'coref' is not assigned and could be declared final | 136 |
| Parameter 'timex' is not assigned and could be declared final | 144 |
| Parameter 'srl' is not assigned and could be declared final | 152 |
| Parameter 'objectMention' is not assigned and could be declared final | 160 |
| Parameter 'timeMention' is not assigned and could be declared final | 168 |
| Parameter 'eventMention' is not assigned and could be declared final | 176 |
| Parameter 'rolewithEntity' is not assigned and could be declared final | 184 |
| Parameter 'participationMention' is not assigned and could be declared final | 192 |
| Parameter 'rolewithoutEntity' is not assigned and could be declared final | 200 |
| Parameter 'factuality' is not assigned and could be declared final | 208 |
| Parameter 'pER' is not assigned and could be declared final | 216 |
| Parameter 'lOC' is not assigned and could be declared final | 224 |
| Parameter 'oRG' is not assigned and could be declared final | 232 |
| Parameter 'pRO' is not assigned and could be declared final | 240 |
| Parameter 'fin' is not assigned and could be declared final | 248 |
| Parameter 'mix' is not assigned and could be declared final | 256 |
| Parameter 'no_mapping' is not assigned and could be declared final | 264 |
ks-populator-naf - eu/fbk/knowledgestore/populator/naf/submitKS.java
| Violation | Line |
|---|---|
| Possible God class (WMC=51, ATFD=46, TCC=0.0) | 1–268 |
| Avoid unused imports such as 'java.io.Writer' | 5 |
| Avoid unused imports such as 'java.util.Iterator' | 7 |
| Avoid unused imports such as 'org.openrdf.model.impl.URIImpl' | 12 |
| All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 23–268 |
| Parameter 'session' is not assigned and could be declared final | 26 |
| Parameter 'batchList' is not assigned and could be declared final | 26 |
| Parameter 'store_partical_info' is not assigned and could be declared final | 26 |
| Local variable 'submittedFiles' could be declared final | 44 |
| Local variable 'ksF' could be declared final | 45 |
| Parameter 'tmp' is not assigned and could be declared final | 82 |
| Avoid using if statements without curly braces | 84–85 |
| Avoid using if statements without curly braces | 86–87 |
| Avoid empty if statements | 89–91 |
| Parameter 'batchList' is not assigned and could be declared final | 99 |
| Parameter 'session' is not assigned and could be declared final | 99 |
| Local variable 'tmp' could be declared final | 101 |
| Local variable 'record' could be declared final | 103–104 |
| Local variable 'correctlyPopulated' could be declared final | 105 |
| Avoid using if...else statements without curly braces | 108 |
| Avoid using if...else statements without curly braces | 110 |
| Parameter 'mentions' is not assigned and could be declared final | 123 |
| Parameter 'resources' is not assigned and could be declared final | 123 |
| Parameter 'session' is not assigned and could be declared final | 123 |
| Local variable 'rID' could be declared final | 129 |
| Local variable 'rID' could be declared final | 136 |
| Parameter 'session' is not assigned and could be declared final | 150 |
| Parameter 'batchList' is not assigned and could be declared final | 150 |
| Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 152 |
| Avoid using if statements without curly braces | 152–154 |
| Parameter 'batchList' is not assigned and could be declared final | 163 |
| Parameter 'session' is not assigned and could be declared final | 163 |
| Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 165 |
| Avoid using if statements without curly braces | 165–167 |
| Parameter 'session' is not assigned and could be declared final | 174 |
| Parameter 'batchList' is not assigned and could be declared final | 174 |
| Local variable 'FILE_RESOURCES' could be declared final | 175 |
| Avoid instantiating new objects inside loops | 179 |
| Parameter 'batchList' is not assigned and could be declared final | 195 |
| Parameter 'session' is not assigned and could be declared final | 195 |
| Local variable 'FILE_RESOURCES' could be declared final | 196 |
| Parameter 'batchList' is not assigned and could be declared final | 212 |
| Local variable 'temp' could be declared final | 213 |
| Local variable 'tmp' could be declared final | 214 |
| Parameter 'batchList' is not assigned and could be declared final | 228 |
| Local variable 'temp' could be declared final | 229 |
| Local variable 'tmp' could be declared final | 230 |
| Parameter 'batchList' is not assigned and could be declared final | 238 |
| Local variable 'temp' could be declared final | 239 |
| Local variable 'tmp' could be declared final | 240 |
| Parameter 'batchList' is not assigned and could be declared final | 248 |
| Local variable 'temp' could be declared final | 249 |
| Local variable 'tmp' could be declared final | 250 |
| Parameter 'batchList' is not assigned and could be declared final | 257 |
| Local variable 'temp' could be declared final | 258 |
| Local variable 'tmp' could be declared final | 259 |
ks-populator-naf - eu/fbk/knowledgestore/populator/naf/sumStatistics.java
| Violation | Line |
|---|---|
| Avoid unused imports such as 'java.io.BufferedWriter' | 4 |
| Avoid unused imports such as 'java.io.File' | 5 |
| Avoid unused imports such as 'java.io.FileNotFoundException' | 7 |
| Avoid unused imports such as 'java.io.FileOutputStream' | 8 |
| Avoid unused imports such as 'java.util.Hashtable' | 12 |
| Avoid unused imports such as 'java.util.LinkedList' | 13 |
| The class 'sumStatistics' has a Cyclomatic Complexity of 9 (Highest = 15). | 15–86 |
| The class 'sumStatistics' has a Standard Cyclomatic Complexity of 9 (Highest = 15). | 15–86 |
| All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 15–86 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 21 |
| The method 'main' has a Standard Cyclomatic Complexity of 15. | 21–74 |
| The method 'main' has a Cyclomatic Complexity of 15. | 21–74 |
| Parameter 'args' is not assigned and could be declared final | 21 |
| Local variable 'inputFile' could be declared final | 23 |
| Local variable 'in' could be declared final | 26 |
| Local variable 'reader' could be declared final | 27 |
| Local variable 'br' could be declared final | 28 |
| Local variable 'Timex' could be declared final | 37 |
| Switch statements should have a default label | 44–55 |
| Avoid using if...else statements without curly braces | 57 |
| Avoid using if...else statements without curly braces | 59 |
| Parameter 'head' is not assigned and could be declared final | 76 |
| Avoid reassigning parameters such as 'line' | 76 |
ks-populator-rdf - eu/fbk/knowledgestore/populator/rdf/Decoder.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'globalURI'. | 19 |
| Perhaps 'globalURI' could be replaced by a local variable. | 19 |
| Avoid empty if statements | 32–34 |
ks-populator-rdf - eu/fbk/knowledgestore/populator/rdf/RDFPopulator.java
| Violation | Line |
|---|---|
| Possible God class (WMC=85, ATFD=56, TCC=0.0) | 1–599 |
| All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 63–599 |
| The class 'RDFPopulator' has a Modified Cyclomatic Complexity of 5 (Highest = 14). | 63–599 |
| The class 'RDFPopulator' has a Standard Cyclomatic Complexity of 5 (Highest = 14). | 63–599 |
| The class 'RDFPopulator' has a Cyclomatic Complexity of 5 (Highest = 15). | 63–599 |
| The method main() has an NPath complexity of 39003 | 79–174 |
| The method 'main' has a Standard Cyclomatic Complexity of 14. | 79–174 |
| The method 'main' has a Cyclomatic Complexity of 15. | 79–174 |
| The method 'main' has a Modified Cyclomatic Complexity of 14. | 79–174 |
| Avoid instantiating new objects inside loops | 301 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 394 |
| The method 'checkFileParseable' has a Cyclomatic Complexity of 10. | 500–524 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 511 |
| Avoid empty catch blocks | 533–535 |
ks-server-elastic - eu/fbk/knowledgestore/elastic/DataStoreElastic.java
| Violation | Line |
|---|---|
| Parameter 'path' is not assigned and could be declared final | 59 |
| Local variable 'addresses' could be declared final | 69 |
| Parameter 'readOnly' is not assigned and could be declared final | 90 |
| Avoid using if statements without curly braces | 92–94 |
| Parameter 'indexName' is not assigned and could be declared final | 124 |
| Local variable 'request' could be declared final | 126 |
| Local variable 'response' could be declared final | 127 |
| Parameter 'client' is not assigned and could be declared final | 136 |
| Use block level rather than method level synchronization | 136–203 |
| Local variable 'weakCompressionPath' could be declared final | 143 |
| Avoid using if statements without curly braces | 144–145 |
| Local variable 'parser0' could be declared final | 156 |
| Local variable 'parser1' could be declared final | 159 |
| Local variable 'strongCompressionPath' could be declared final | 167 |
| Avoid using if statements without curly braces | 168–169 |
| Local variable 'startTime' could be declared final | 177 |
| Local variable 'request' could be declared final | 186 |
| Local variable 'response' could be declared final | 188 |
| Avoid idempotent operations (like assigning a variable to itself). | 197 |
| Parameter 'req' is not assigned and could be declared final | 205 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 205 |
| Parameter 'jsons' is not assigned and could be declared final | 205 |
| Parameter 'types' is not assigned and could be declared final | 205 |
| Avoid using if statements without curly braces | 210 |
| Parameter 'types' is not assigned and could be declared final | 216 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 216 |
| Avoid unused private methods such as 'setMappings(String,String)'. | 216 |
| Parameter 'jsons' is not assigned and could be declared final | 216 |
| Avoid using if statements without curly braces | 218–219 |
| Local variable 'mappingMentionResponse' could be declared final | 223–224 |
| Avoid using if statements without curly braces | 225–226 |
| Parameter 'fileName' is not assigned and could be declared final | 231 |
| Local variable 'url' could be declared final | 233 |
| Avoid reassigning parameters such as 'set' | 251 |
| Parameter 'map' is not assigned and could be declared final | 251 |
| Local variable 'propStrings' could be declared final | 252 |
| Local variable 'propStr' could be declared final | 253 |
| Local variable 'propUri' could be declared final | 255 |
| Avoid instantiating new objects inside loops | 256 |
| Local variable 'propNamespace' could be declared final | 256 |
| Avoid empty catch blocks | 258–260 |
| Local variable 'value' could be declared final | 261 |
| Parameter 'fileName' is not assigned and could be declared final | 269 |
| Parameter 'set' is not assigned and could be declared final | 269 |
| Local variable 'url' could be declared final | 271 |
| Local variable 'propStr' could be declared final | 286 |
| Local variable 'propUri' could be declared final | 287 |
| Parameter 'map' is not assigned and could be declared final | 293 |
| Local variable 'destMap' could be declared final | 294 |
| Parameter 'destMap' is not assigned and could be declared final | 297 |
| Parameter 'sourceMap' is not assigned and could be declared final | 297 |
| Local variable 'uriKey' could be declared final | 304 |
ks-server-elastic - eu/fbk/knowledgestore/elastic/DataTransactionElastic.java
| Violation | Line |
|---|---|
| Possible God class (WMC=61, ATFD=68, TCC=0.06535947712418301) | 2–477 |
| The class 'DataTransactionElastic' has a Modified Cyclomatic Complexity of 4 (Highest = 11). | 52–477 |
| The class 'DataTransactionElastic' has a Cyclomatic Complexity of 4 (Highest = 13). | 52–477 |
| The class 'DataTransactionElastic' has a Standard Cyclomatic Complexity of 4 (Highest = 11). | 52–477 |
| Parameter 'client' is not assigned and could be declared final | 68 |
| Parameter 'mapper' is not assigned and could be declared final | 68 |
| Parameter 'configs' is not assigned and could be declared final | 68 |
| Parameter 'uriHandler' is not assigned and could be declared final | 68 |
| Parameter 'type' is not assigned and could be declared final | 82 |
| Avoid using if statements without curly braces | 83 |
| Avoid using if statements without curly braces | 84 |
| Local variable 'builder' could be declared final | 96–122 |
| Parameter 'br' is not assigned and could be declared final | 98 |
| Parameter 'l' is not assigned and could be declared final | 98 |
| Parameter 'l' is not assigned and could be declared final | 104 |
| Parameter 'br' is not assigned and could be declared final | 104 |
| Parameter 'br1' is not assigned and could be declared final | 104 |
| Avoid using if statements without curly braces | 109–110 |
| Prefer StringBuffer over += for concatenating strings | 110 |
| Parameter 'l' is not assigned and could be declared final | 118 |
| Parameter 'br' is not assigned and could be declared final | 118 |
| Parameter 'thrwbl' is not assigned and could be declared final | 118 |
| Avoid using if statements without curly braces | 124 |
| Avoid using if statements without curly braces | 126 |
| Local variable 'exception' could be declared final | 132 |
| Avoid using if statements without curly braces | 134–135 |
| Parameter 'time' is not assigned and could be declared final | 146 |
| Avoid using if statements without curly braces | 151–152 |
| Local variable 'fr' could be declared final | 156 |
| Parameter 'type' is not assigned and could be declared final | 183 |
| Parameter 'ids' is not assigned and could be declared final | 183 |
| Parameter 'properties' is not assigned and could be declared final | 183 |
| Local variable 'request' could be declared final | 192 |
| Local variable 'typeName' could be declared final | 194 |
| Local variable 'id' could be declared final | 196 |
| Local variable 'item' could be declared final | 197 |
| Avoid instantiating new objects inside loops | 197 |
| Local variable 'response' could be declared final | 204 |
| Local variable 'records' could be declared final | 205 |
| Local variable 'item' could be declared final | 207 |
| Local variable 'failure' could be declared final | 209 |
| Local variable 'tmp' could be declared final | 212 |
| Avoid using if statements without curly braces | 215–216 |
| Parameter 'condition' is not assigned and could be declared final | 230 |
| The method 'buildFilter' has a Standard Cyclomatic Complexity of 11. | 230–283 |
| Parameter 'partialAccept' is not assigned and could be declared final | 230 |
| The method 'buildFilter' has a Cyclomatic Complexity of 13. | 230–283 |
| The method 'buildFilter' has a Modified Cyclomatic Complexity of 11. | 230–283 |
| Local variable 'map' could be declared final | 232 |
| Local variable 'remain' could be declared final | 233 |
| Useless parentheses. | 235 |
| Local variable 'filters' could be declared final | 239 |
| Local variable 'el' could be declared final | 241 |
| Avoid using if...else statements without curly braces | 245 |
| Avoid using if statements without curly braces | 253 |
| Local variable 'tmpFilters' could be declared final | 257 |
| Avoid instantiating new objects inside loops | 257 |
| Local variable 'item' could be declared final | 259 |
| Avoid using if statements without curly braces | 272 |
| Avoid using if statements without curly braces | 279–280 |
| Parameter 'condition' is not assigned and could be declared final | 296 |
| Parameter 'type' is not assigned and could be declared final | 296 |
| Parameter 'properties' is not assigned and could be declared final | 296 |
| Local variable 'typeName' could be declared final | 302 |
| Local variable 'response' could be declared final | 327 |
| Parameter 'type' is not assigned and could be declared final | 352 |
| Parameter 'condition' is not assigned and could be declared final | 352 |
| Local variable 'typeName' could be declared final | 360 |
| Local variable 'mainFilter' could be declared final | 369 |
| Local variable 'mainQuery' could be declared final | 371 |
| Local variable 'stream' could be declared final | 377 |
| Local variable 'response' could be declared final | 382 |
| Parameter 'ids' is not assigned and could be declared final | 387 |
| Parameter 'properties' is not assigned and could be declared final | 387 |
| Parameter 'conditions' is not assigned and could be declared final | 387 |
| Parameter 'record' is not assigned and could be declared final | 399 |
| Parameter 'type' is not assigned and could be declared final | 399 |
| Avoid using if statements without curly braces | 401–402 |
| Local variable 'typeName' could be declared final | 404 |
| Local variable 'source' could be declared final | 406 |
| Local variable 'indexRequest' could be declared final | 408 |
| Local variable 'updateRequest' could be declared final | 409 |
| Parameter 'type' is not assigned and could be declared final | 421 |
| Parameter 'id' is not assigned and could be declared final | 421 |
| Local variable 'typeName' could be declared final | 425 |
| Local variable 'indexName' could be declared final | 426 |
| Local variable 'idStr' could be declared final | 427 |
| Local variable 'deleteRequest' could be declared final | 428 |
| Avoid using if statements without curly braces | 430–431 |
| Parameter 'commit' is not assigned and could be declared final | 443 |
| Parameter 'segNumber' is not assigned and could be declared final | 457 |
| Avoid using if statements without curly braces | 463–464 |
| Avoid using if statements without curly braces | 474–475 |
ks-server-elastic - eu/fbk/knowledgestore/elastic/ElasticConfigurations.java
| Violation | Line |
|---|---|
| Parameter 'path' is not assigned and could be declared final | 69 |
| Local variable 'url' could be declared final | 72 |
| Parameter 'addresses' is not assigned and could be declared final | 138 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 138 |
| Avoid using if statements without curly braces | 141 |
| Local variable 'splitted' could be declared final | 145 |
| Avoid instantiating new objects inside loops | 152 |
| Returning 'addresses' may expose an internal array. | 193 |
ks-server-elastic - eu/fbk/knowledgestore/elastic/MappingHandler.java
| Violation | Line |
|---|---|
| The class 'MappingHandler' has a Standard Cyclomatic Complexity of 4 (Highest = 11). | 36–127 |
| The class 'MappingHandler' has a Cyclomatic Complexity of 4 (Highest = 11). | 36–127 |
| Parameter 'mappings' is not assigned and could be declared final | 45 |
| Local variable 'keyRoot' could be declared final | 48 |
| Local variable 'openMap' could be declared final | 49 |
| Local variable 'key' could be declared final | 50 |
| Parameter 'propName' is not assigned and could be declared final | 60 |
| Local variable 'res' could be declared final | 61 |
| Parameter 'map' is not assigned and could be declared final | 69 |
| Local variable 'typeMapping' could be declared final | 70 |
| Local variable 'key' could be declared final | 71 |
| Local variable 'typeMappingValue' could be declared final | 72 |
| Local variable 'propertyValueClass' could be declared final | 74 |
| The method 'fromStringToClass' has a Cyclomatic Complexity of 11. | 88–126 |
| The method 'fromStringToClass' has a Standard Cyclomatic Complexity of 11. | 88–126 |
| Parameter 'str' is not assigned and could be declared final | 88 |
| Local variable 'stringClass' could be declared final | 90 |
ks-server-elastic - eu/fbk/knowledgestore/elastic/SearchResponseStream.java
| Violation | Line |
|---|---|
| Parameter 'client' is not assigned and could be declared final | 45 |
| Parameter 'mapper' is not assigned and could be declared final | 45 |
| Parameter 'handler' is not assigned and could be declared final | 45 |
| Parameter 'timeout' is not assigned and could be declared final | 45 |
| Parameter 'res' is not assigned and could be declared final | 45 |
| Local variable 'hit' could be declared final | 56 |
ks-server-elastic - eu/fbk/knowledgestore/elastic/URIHandler.java
| Violation | Line |
|---|---|
| Parameter 'weakCompression' is not assigned and could be declared final | 66 |
| Parameter 'strongCompression' is not assigned and could be declared final | 66 |
| Parameter 'client' is not assigned and could be declared final | 66 |
| Local variable 'map' could be declared final | 74 |
| Parameter 'nameSpaces' is not assigned and could be declared final | 89 |
| Local variable 'hit' could be declared final | 108 |
| Avoid using if statements without curly braces | 109–110 |
| Local variable 'compressedURI' could be declared final | 112 |
| Local variable 'document' could be declared final | 113 |
| Local variable 'extendedURI' could be declared final | 114 |
| Avoid instantiating new objects inside loops | 114 |
| Local variable 'uriInteger' could be declared final | 115 |
| Avoid using if statements without curly braces | 116 |
| Local variable 'createRequest' could be declared final | 134–135 |
| Local variable 'typeName' could be declared final | 137 |
| Local variable 'mapping' could be declared final | 138–152 |
| Local variable 'createResponse' could be declared final | 157 |
| Parameter 'nameSpaces' is not assigned and could be declared final | 168 |
| Local variable 'uri' could be declared final | 169 |
| Parameter 'extendedUri' is not assigned and could be declared final | 188 |
| Parameter 'type' is not assigned and could be declared final | 188 |
| Local variable 'extended' could be declared final | 189 |
| Local variable 'source' could be declared final | 190 |
| Local variable 'indexReq' could be declared final | 195 |
| Local variable 'indexResponse' could be declared final | 197 |
| Avoid using if statements without curly braces | 199–200 |
| Local variable 'flushResponse' could be declared final | 202 |
| Local variable 'failure' could be declared final | 206 |
| Prefer StringBuffer over += for concatenating strings | 207 |
| Use block level rather than method level synchronization | 224–242 |
| Parameter 'extended' is not assigned and could be declared final | 224 |
| Avoid using if statements without curly braces | 227–228 |
| No need to call String.valueOf to append to a string. | 228 |
| Local variable 'namespace' could be declared final | 230 |
| Avoid using if statements without curly braces | 231–232 |
| No need to call String.valueOf to append to a string. | 241 |
| Parameter 'uri' is not assigned and could be declared final | 250 |
| Local variable 'nameSpace' could be declared final | 261 |
| Local variable 'encodedNotEscape' could be declared final | 263 |
| Avoid reassigning parameters such as 'compressed' | 282 |
| Use opposite operator instead of the logic complement operator. | 285 |
| Local variable 'pos' could be declared final | 292 |
| Local variable 'res' could be declared final | 294 |
| Local variable 'number' could be declared final | 299 |
| Local variable 'nameSpaceStr' could be declared final | 300 |
| Local variable 'localNameStr' could be declared final | 301 |
| Local variable 'res' could be declared final | 302 |
| Local variable 'res' could be declared final | 307 |
| Parameter 'str' is not assigned and could be declared final | 312 |
| Local variable 'request' could be declared final | 321 |
| Local variable 'response' could be declared final | 322 |
ks-server-elastic - eu/fbk/knowledgestore/elastic/Utility.java
| Violation | Line |
|---|---|
| Possible God class (WMC=124, ATFD=89, TCC=0.0) | 16–713 |
| All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 48–713 |
| The class 'Utility' has a Standard Cyclomatic Complexity of 6 (Highest = 24). | 48–713 |
| The class 'Utility' has a Modified Cyclomatic Complexity of 6 (Highest = 24). | 48–713 |
| The class 'Utility' has a Cyclomatic Complexity of 7 (Highest = 39). | 48–713 |
| Avoid unused private fields such as 'URI_ESCAPE'. | 52 |
| Parameter 'handler' is not assigned and could be declared final | 54 |
| Parameter 'uri' is not assigned and could be declared final | 54 |
| Parameter 'str' is not assigned and could be declared final | 61 |
| Parameter 'handler' is not assigned and could be declared final | 61 |
| The method 'areEquals' has a Cyclomatic Complexity of 20. | 76–160 |
| The method 'areEquals' has a Modified Cyclomatic Complexity of 17. | 76–160 |
| The method 'areEquals' has a Standard Cyclomatic Complexity of 17. | 76–160 |
| The method areEquals() has an NPath complexity of 1444 | 76–160 |
| Parameter 'exp' is not assigned and could be declared final | 76 |
| Parameter 'res' is not assigned and could be declared final | 76 |
| Local variable 'properties' could be declared final | 80 |
| Local variable 'resProperties' could be declared final | 81 |
| Local variable 'prop' could be declared final | 93 |
| Local variable 'resProp' could be declared final | 94 |
| Local variable 'expValues' could be declared final | 100 |
| Local variable 'resValues' could be declared final | 101 |
| Local variable 'expIt' could be declared final | 121 |
| Local variable 'resIt' could be declared final | 122 |
| Local variable 'expValue' could be declared final | 124 |
| Local variable 'resValue' could be declared final | 125 |
| Parameter 'expResult' is not assigned and could be declared final | 169 |
| Parameter 'result' is not assigned and could be declared final | 169 |
| The method 'literalSerializer' has a Standard Cyclomatic Complexity of 14. | 196–237 |
| The method 'literalSerializer' has a Cyclomatic Complexity of 24. | 196–237 |
| Parameter 'literal' is not assigned and could be declared final | 196 |
| Parameter 'builder' is not assigned and could be declared final | 196 |
| The method 'literalSerializer' has a Modified Cyclomatic Complexity of 14. | 196–237 |
| Local variable 'tmp' could be declared final | 217 |
| Local variable 'tmp' could be declared final | 220 |
| Local variable 'tmp' could be declared final | 226 |
| Local variable 'tmp' could be declared final | 231 |
| Parameter 'elKey' is not assigned and could be declared final | 245 |
| The method buildTermFilter() has an NPath complexity of 1040 | 245–304 |
| Parameter 'item' is not assigned and could be declared final | 245 |
| Parameter 'handler' is not assigned and could be declared final | 245 |
| Parameter 'mapper' is not assigned and could be declared final | 245 |
| The method 'buildTermFilter' has a Standard Cyclomatic Complexity of 12. | 245–304 |
| The method 'buildTermFilter' has a Modified Cyclomatic Complexity of 12. | 245–304 |
| The method 'buildTermFilter' has a Cyclomatic Complexity of 12. | 245–304 |
| Local variable 'encodedURI' could be declared final | 252 |
| Avoid reassigning parameters such as 'res' | 313 |
| Parameter 'item' is not assigned and could be declared final | 313 |
| Avoid reassigning parameters such as 'res' | 313 |
| Avoid reassigning parameters such as 'res' | 313 |
| Avoid reassigning parameters such as 'res' | 313 |
| The method 'setFromToRange' has a Cyclomatic Complexity of 39. | 313–419 |
| Avoid reassigning parameters such as 'res' | 313 |
| Avoid reassigning parameters such as 'res' | 313 |
| Parameter 'itemClass' is not assigned and could be declared final | 313 |
| The method 'setFromToRange' has a Modified Cyclomatic Complexity of 24. | 313–419 |
| Avoid reassigning parameters such as 'res' | 313 |
| Avoid reassigning parameters such as 'res' | 313 |
| Avoid reassigning parameters such as 'res' | 313 |
| Avoid reassigning parameters such as 'res' | 313 |
| The method 'setFromToRange' has a Standard Cyclomatic Complexity of 24. | 313–419 |
| Avoid really long methods. | 313–419 |
| The method setFromToRange() has an NPath complexity of 3888 | 313–419 |
| Avoid reassigning parameters such as 'res' | 313 |
| Avoid reassigning parameters such as 'res' | 313 |
| Parameter 'handler' is not assigned and could be declared final | 314 |
| Parameter 'elKey' is not assigned and could be declared final | 430 |
| Parameter 'item' is not assigned and could be declared final | 430 |
| Parameter 'handler' is not assigned and could be declared final | 430 |
| Parameter 'mapper' is not assigned and could be declared final | 430 |
| Local variable 'res' could be declared final | 434 |
| Parameter 'handler' is not assigned and could be declared final | 446 |
| Parameter 'value' is not assigned and could be declared final | 446 |
| Avoid reassigning parameters such as 'builder' | 446 |
| Avoid reassigning parameters such as 'builder' | 446 |
| Local variable 'id' could be declared final | 460 |
| Avoid reassigning parameters such as 'builder' | 478 |
| Parameter 'values' is not assigned and could be declared final | 478 |
| Parameter 'handler' is not assigned and could be declared final | 479 |
| Local variable 'obj' could be declared final | 480 |
| Parameter 'record' is not assigned and could be declared final | 494 |
| Avoid reassigning parameters such as 'builder' | 494 |
| Avoid reassigning parameters such as 'builder' | 494 |
| Parameter 'handler' is not assigned and could be declared final | 494 |
| Local variable 'property' could be declared final | 497 |
| Parameter 'record' is not assigned and could be declared final | 523 |
| Parameter 'handler' is not assigned and could be declared final | 523 |
| Parameter 'propName' is not assigned and could be declared final | 539 |
| Parameter 'value' is not assigned and could be declared final | 539 |
| Parameter 'mapper' is not assigned and could be declared final | 539 |
| Parameter 'handler' is not assigned and could be declared final | 540 |
| Local variable 'valueClass' could be declared final | 541 |
| Local variable 'valueByte' could be declared final | 548 |
| Parameter 'values' is not assigned and could be declared final | 573 |
| Parameter 'mapper' is not assigned and could be declared final | 573 |
| Parameter 'propName' is not assigned and could be declared final | 573 |
| Parameter 'handler' is not assigned and could be declared final | 574 |
| Local variable 'res' could be declared final | 575 |
| Local variable 'obj' could be declared final | 576 |
| Parameter 'handler' is not assigned and could be declared final | 589 |
| Parameter 'mapper' is not assigned and could be declared final | 589 |
| Parameter 'res' is not assigned and could be declared final | 589 |
| Parameter 'source' is not assigned and could be declared final | 589 |
| Local variable 'propStr' could be declared final | 595 |
| Local variable 'propName' could be declared final | 599 |
| Local variable 'value' could be declared final | 600 |
| Parameter 'mapper' is not assigned and could be declared final | 618 |
| Parameter 'response' is not assigned and could be declared final | 618 |
| Parameter 'handler' is not assigned and could be declared final | 618 |
| Local variable 'res' could be declared final | 629 |
| Parameter 'mapper' is not assigned and could be declared final | 664 |
| Parameter 'handler' is not assigned and could be declared final | 664 |
| Parameter 'response' is not assigned and could be declared final | 664 |
| Local variable 'res' could be declared final | 668 |
| Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access. | 699–702 |
| Parameter 'obj' is not assigned and could be declared final | 699 |
| Parameter 's' is not assigned and could be declared final | 710 |
| Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access. | 710–712 |
ks-server-hbase - eu/fbk/knowledgestore/datastore/hbase/HBaseDataStore.java
| Violation | Line |
|---|---|
| Too many static imports may lead to messy code | 1–186 |
| Private field 'serverFilterFlag' could be made final; it is only initialized in the declaration or constructor. | 47 |
| Private field 'hbaseUtils' could be made final; it is only initialized in the declaration or constructor. | 53 |
| Avoid unused private fields such as 'fileSystem'. | 56 |
| Perhaps 'fileSystem' could be replaced by a local variable. | 56 |
| Document empty method body | 107–108 |
ks-server-hbase - eu/fbk/knowledgestore/datastore/hbase/HBaseDataTransaction.java
| Violation | Line |
|---|---|
| Too many static imports may lead to messy code | 1–278 |
| Parameter 'pHbaseUtils' is not assigned and could be declared final | 57 |
| Parameter 'record' is not assigned and could be declared final | 63 |
| Local variable 'type' could be declared final | 64 |
| Parameter 'condition' is not assigned and could be declared final | 135 |
| Parameter 'type' is not assigned and could be declared final | 135 |
| Parameter 'commit' is not assigned and could be declared final | 243 |
| Avoid using if...else statements without curly braces | 246 |
| Avoid using if...else statements without curly braces | 248 |
| Parameter 'logger' is not assigned and could be declared final | 261 |
| Parameter 'hbaseUtils' is not assigned and could be declared final | 275 |
ks-server-hbase - eu/fbk/knowledgestore/datastore/hbase/HBaseScanIterator.java
| Violation | Line |
|---|---|
| Avoid using a branching statement as the last in a loop. | 132 |
ks-server-hbase - eu/fbk/knowledgestore/datastore/hbase/utils/AbstractHBaseUtils.java
| Violation | Line |
|---|---|
| Too many static imports may lead to messy code | 1–382 |
| Parameter 'properties' is not assigned and could be declared final | 57 |
| Parameter 'properties' is not assigned and could be declared final | 61 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 154 |
| Parameter 'passAll' is not assigned and could be declared final | 203 |
| Parameter 'condition' is not assigned and could be declared final | 203 |
| Parameter 'famNames' is not assigned and could be declared final | 204 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 204 |
| Parameter 'qualNames' is not assigned and could be declared final | 204 |
| Parameter 'params' is not assigned and could be declared final | 204 |
| Useless parentheses. | 205 |
| Local variable 'list' could be declared final | 205–206 |
| Avoid instantiating new objects inside loops | 208–213 |
| Local variable 'filterTmp' could be declared final | 208–213 |
| Parameter 'tableName' is not assigned and could be declared final | 229 |
| Parameter 'famName' is not assigned and could be declared final | 229 |
| Parameter 'startKey' is not assigned and could be declared final | 230 |
| Parameter 'endKey' is not assigned and could be declared final | 230 |
| Local variable 'scan' could be declared final | 232 |
| Avoid using if statements without curly braces | 235–236 |
| Avoid using if statements without curly braces | 237–238 |
| Parameter 'tableName' is not assigned and could be declared final | 250 |
| Parameter 'famName' is not assigned and could be declared final | 251 |
| Parameter 'tableName' is not assigned and could be declared final | 260 |
| Parameter 'record' is not assigned and could be declared final | 260 |
| Parameter 'quaName' is not assigned and could be declared final | 261 |
| Parameter 'famName' is not assigned and could be declared final | 261 |
| Local variable 'tTable' could be declared final | 262 |
| Local variable 'serializer' could be declared final | 266 |
| Parameter 'tableName' is not assigned and could be declared final | 284 |
| Parameter 'id' is not assigned and could be declared final | 284 |
| Local variable 'tTable' could be declared final | 286 |
| Parameter 'pLogger' is not assigned and could be declared final | 303 |
| Parameter 'tabName' is not assigned and could be declared final | 313 |
| Parameter 'colFamName' is not assigned and could be declared final | 313 |
| Avoid unnecessary comparisons in boolean expressions | 317 |
| Parameter 'hbcfg' is not assigned and could be declared final | 345 |
| Parameter 'serverFilterFlag' is not assigned and could be declared final | 349 |
| Parameter 'serializer' is not assigned and could be declared final | 360 |
| Parameter 'hbaseTableNamePrefix' is not assigned and could be declared final | 371 |
ks-server-hbase - eu/fbk/knowledgestore/datastore/hbase/utils/AvroSerializer.java
| Violation | Line |
|---|---|
| Possible God class (WMC=100, ATFD=105, TCC=0.0) | 1–449 |
| The class 'AvroSerializer' has a Cyclomatic Complexity of 4 (Highest = 15). | 54–449 |
| The class 'AvroSerializer' has a Standard Cyclomatic Complexity of 3 (Highest = 15). | 54–449 |
| The class 'AvroSerializer' has a Modified Cyclomatic Complexity of 3 (Highest = 15). | 54–449 |
| The method 'decodeLiteral' has a Standard Cyclomatic Complexity of 15. | 256–296 |
| The method 'decodeLiteral' has a Cyclomatic Complexity of 15. | 256–296 |
| The method 'decodeLiteral' has a Modified Cyclomatic Complexity of 15. | 256–296 |
| Avoid instantiating new objects inside loops | 351 |
| The method 'encodeLiteral' has a Modified Cyclomatic Complexity of 13. | 386–420 |
| The method 'encodeLiteral' has a Cyclomatic Complexity of 14. | 386–420 |
| The method 'encodeLiteral' has a Standard Cyclomatic Complexity of 13. | 386–420 |
ks-server-hbase - eu/fbk/knowledgestore/datastore/hbase/utils/HBaseFilter.java
| Violation | Line |
|---|---|
| Document empty constructor | 34–35 |
ks-server-hbase - eu/fbk/knowledgestore/datastore/hbase/utils/HBaseUtils.java
| Violation | Line |
|---|---|
| Parameter 'tableName' is not assigned and could be declared final | 43 |
| Local variable 'admin' could be declared final | 52 |
| Local variable 'resources' could be declared final | 53 |
| An empty statement (semicolon) not part of a loop | 60 |
| Document empty method body | 70–71 |
| Document empty method body | 77–78 |
| Parameter 'scan' is not assigned and could be declared final | 87 |
| Parameter 'tableName' is not assigned and could be declared final | 87 |
| Local variable 'tab' could be declared final | 89 |
| Parameter 'record' is not assigned and could be declared final | 104 |
| Parameter 'tabName' is not assigned and could be declared final | 104 |
| Parameter 'quaName' is not assigned and could be declared final | 105 |
| Parameter 'famName' is not assigned and could be declared final | 105 |
| Local variable 'hTable' could be declared final | 107 |
| Local variable 'op' could be declared final | 109 |
| Parameter 'tabName' is not assigned and could be declared final | 121 |
| Parameter 'id' is not assigned and could be declared final | 121 |
| Parameter 'quaName' is not assigned and could be declared final | 122 |
| Parameter 'famName' is not assigned and could be declared final | 122 |
| Local variable 'hTable' could be declared final | 124 |
| Local variable 'op' could be declared final | 126 |
| Parameter 'tableName' is not assigned and could be declared final | 141 |
| Parameter 'id' is not assigned and could be declared final | 141 |
| Local variable 'selTable' could be declared final | 143 |
| Local variable 'get' could be declared final | 147 |
| Local variable 'rs' could be declared final | 148 |
| Parameter 'tableName' is not assigned and could be declared final | 157 |
| Parameter 'ids' is not assigned and could be declared final | 158 |
| Local variable 'selTable' could be declared final | 160 |
| Local variable 'resGotten' could be declared final | 161 |
| Local variable 'gets' could be declared final | 162 |
| Local variable 'serializer' could be declared final | 163 |
| Local variable 'id' could be declared final | 165 |
| Avoid instantiating new objects inside loops | 166 |
| Local variable 'results' could be declared final | 168 |
| Local variable 'res' could be declared final | 171 |
| Parameter 'tableName' is not assigned and could be declared final | 186 |
| Parameter 'record' is not assigned and could be declared final | 186 |
| Parameter 'quaName' is not assigned and could be declared final | 187 |
| Parameter 'famName' is not assigned and could be declared final | 187 |
| Local variable 'hTable' could be declared final | 188 |
| Local variable 'serializer' could be declared final | 192 |
| Parameter 'id' is not assigned and could be declared final | 211 |
| Parameter 'tableName' is not assigned and could be declared final | 211 |
| Local variable 'hTable' could be declared final | 213 |
| Parameter 'objs' is not assigned and could be declared final | 226 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 226 |
| Local variable 'errors' could be declared final | 227 |
| Parameter 'condition' is not assigned and could be declared final | 247 |
| Parameter 'familyName' is not assigned and could be declared final | 247 |
| Parameter 'tableName' is not assigned and could be declared final | 247 |
| Local variable 'customConf' could be declared final | 250 |
| Local variable 'agClient' could be declared final | 262 |
| Local variable 'tName' could be declared final | 264 |
| Local variable 'scan' could be declared final | 266 |
| New exception is thrown in catch block, original stack trace may be lost | 269 |
| Document empty method body | 275–276 |
ks-server-hbase - eu/fbk/knowledgestore/datastore/hbase/utils/OmidHBaseUtils.java
| Violation | Line |
|---|---|
| Too many static imports may lead to messy code | 1–289 |
| Possible unsafe assignment to a non-final static field in a constructor. | 48 |
| Do not add empty strings | 68 |
| Do not add empty strings | 73 |
| Do not add empty strings | 81 |
| Parameter 'tableName' is not assigned and could be declared final | 127 |
| Parameter 'tabName' is not assigned and could be declared final | 146 |
| Parameter 'record' is not assigned and could be declared final | 146 |
| Parameter 'quaName' is not assigned and could be declared final | 147 |
| Parameter 'famName' is not assigned and could be declared final | 147 |
| Local variable 'tTable' could be declared final | 149 |
| Parameter 'id' is not assigned and could be declared final | 177 |
| Parameter 'tabName' is not assigned and could be declared final | 177 |
| Parameter 'quaName' is not assigned and could be declared final | 178 |
| Parameter 'famName' is not assigned and could be declared final | 178 |
| Local variable 'tTable' could be declared final | 180 |
| Parameter 'id' is not assigned and could be declared final | 201 |
| Parameter 'tableName' is not assigned and could be declared final | 201 |
| Local variable 'tTable' could be declared final | 203 |
| Local variable 'get' could be declared final | 207 |
| Local variable 'rs' could be declared final | 208 |
| Parameter 'tableName' is not assigned and could be declared final | 217 |
| Parameter 'ids' is not assigned and could be declared final | 218 |
| Local variable 'tTable' could be declared final | 220 |
| Local variable 'resGotten' could be declared final | 221 |
| Local variable 'gets' could be declared final | 222 |
| Local variable 'serializer' could be declared final | 223 |
| Local variable 'id' could be declared final | 225 |
| Avoid instantiating new objects inside loops | 226 |
| Local variable 'results' could be declared final | 229 |
| Local variable 'res' could be declared final | 231 |
| Parameter 'objs' is not assigned and could be declared final | 241 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 241 |
| Parameter 'scan' is not assigned and could be declared final | 277 |
| Parameter 'tableName' is not assigned and could be declared final | 277 |
| Local variable 'tTable' could be declared final | 279 |
ks-server-hbase - eu/fbk/knowledgestore/datastore/hbase/utils/TephraHBaseUtils.java
| Violation | Line |
|---|---|
| Too many static imports may lead to messy code | 1–312 |
| Private field 'txClient' could be made final; it is only initialized in the declaration or constructor. | 49 |
| Perhaps 'txClient' could be replaced by a local variable. | 49 |
| Avoid instantiating new objects inside loops | 84 |
| Avoid instantiating new objects inside loops | 85 |
| This call to Collection.toArray() may be optimizable | 99 |
| Avoid empty catch blocks | 113–114 |
| Avoid instantiating new objects inside loops | 242 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 257 |
ks-server-http - eu/fbk/knowledgestore/server/http/CustomConfig.java
| Violation | Line |
|---|---|
| Private field 'command' could be made final; it is only initialized in the declaration or constructor. | 9 |
| Private field 'name' could be made final; it is only initialized in the declaration or constructor. | 9 |
| Parameter 'name' is not assigned and could be declared final | 11 |
| Parameter 'command' is not assigned and could be declared final | 11 |
ks-server-http - eu/fbk/knowledgestore/server/http/HttpServer.java
| Violation | Line |
|---|---|
| Possible God class (WMC=58, ATFD=96, TCC=0.0) | 1–566 |
| The class 'HttpServer' has a Modified Cyclomatic Complexity of 3 (Highest = 11). | 45–566 |
| The class 'HttpServer' has a Standard Cyclomatic Complexity of 3 (Highest = 11). | 45–566 |
| The class 'HttpServer' has a Cyclomatic Complexity of 3 (Highest = 12). | 45–566 |
| Do not hard code the IP address | 49 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 96 |
| Avoid appending characters as strings in StringBuffer.append. | 99 |
| An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type. | 106 |
| The method 'createJettyServer' has a Standard Cyclomatic Complexity of 11. | 141–284 |
| The method 'createJettyServer' has a Cyclomatic Complexity of 11. | 141–284 |
| Avoid really long methods. | 141–284 |
| The method 'createJettyServer' has a Modified Cyclomatic Complexity of 11. | 141–284 |
| The method createJettyServer() has an NPath complexity of 2880 | 141–284 |
| Prefer StringBuffer over += for concatenating strings | 149 |
| Prefer StringBuffer over += for concatenating strings | 149 |
| This call to String.startsWith can be rewritten using String.charAt(0) | 149 |
| Unnecessary use of fully qualified name 'eu.fbk.knowledgestore.server.http.jaxrs.Resources' due to existing import 'eu.fbk.knowledgestore.server.http.jaxrs.*' | 232 |
| Local variable 'requestLog' could be declared final | 248 |
| This call to String.startsWith can be rewritten using String.charAt(0) | 258 |
| Consider simply returning the value vs storing it in local variable 'factory' | 317 |
| Consider simply returning the value vs storing it in local variable 'factory' | 343 |
| The method createWebXml() has an NPath complexity of 389 | 346–426 |
| The method 'createWebXml' has a Standard Cyclomatic Complexity of 11. | 346–426 |
| The method 'createWebXml' has a Modified Cyclomatic Complexity of 11. | 346–426 |
| The method 'createWebXml' has a Cyclomatic Complexity of 12. | 346–426 |
| Too many fields | 432–564 |
| Avoid instantiation through private constructors from outside of the constructors class. | 561 |
ks-server-http - eu/fbk/knowledgestore/server/http/KeystoreConfig.java
| Violation | Line |
|---|---|
| StringBuffer constructor is initialized with size 16, but has at least 20 characters appended. | 83 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 84 |
ks-server-http - eu/fbk/knowledgestore/server/http/SecurityConfig.java
| Violation | Line |
|---|---|
| StringBuffer constructor is initialized with size 16, but has at least 26 characters appended. | 93 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 97 |
ks-server-http - eu/fbk/knowledgestore/server/http/UIConfig.java
| Violation | Line |
|---|---|
| Possible God class (WMC=56, ATFD=31, TCC=0.0) | 1–372 |
| Unnecessary final modifier in final class | 259–285 |
| Avoid instantiation through private constructors from outside of the constructors class. | 367 |
ks-server-http - eu/fbk/knowledgestore/server/http/jaxrs/Application.java
| Violation | Line |
|---|---|
| Possible God class (WMC=95, ATFD=110, TCC=0.0033333333333333335) | 1–651 |
| Unnecessary use of fully qualified name 'javax.ws.rs.core.Application' due to existing import 'javax.ws.rs.core.*' | 51 |
| When instantiating a SimpleDateFormat object, specify a Locale | 72 |
| Avoid using redundant field initializer for 'invocationCounter' | 82 |
| Local variable 'config' could be declared final | 117 |
| Use block level rather than method level synchronization | 194–196 |
| Use block level rather than method level synchronization | 198–200 |
| Use block level rather than method level synchronization | 202–207 |
| Unnecessary use of fully qualified name 'javax.ws.rs.core.Application' due to existing import 'javax.ws.rs.core.*' | 209 |
| New exception is thrown in catch block, original stack trace may be lost | 230 |
| New exception is thrown in catch block, original stack trace may be lost | 248 |
| New exception is thrown in catch block, original stack trace may be lost | 266 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 280 |
| The class 'Filter' has a Modified Cyclomatic Complexity of 4 (Highest = 12). | 296–555 |
| The class 'Filter' has a Cyclomatic Complexity of 4 (Highest = 12). | 296–555 |
| The class 'Filter' has a Standard Cyclomatic Complexity of 4 (Highest = 12). | 296–555 |
| The method 'filter' has a Standard Cyclomatic Complexity of 12. | 302–399 |
| The method filter() has an NPath complexity of 594 | 302–399 |
| The method 'filter' has a Cyclomatic Complexity of 12. | 302–399 |
| The method 'filter' has a Modified Cyclomatic Complexity of 12. | 302–399 |
| Avoid empty catch blocks | 344–346 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 376 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 377 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 418 |
| Avoid empty catch blocks | 434–436 |
| Avoid empty catch blocks | 483–485 |
| Avoid empty catch blocks | 504–506 |
| Avoid empty catch blocks | 533–535 |
| Avoid empty catch blocks | 548–550 |
| The class 'Mapper' has a Cyclomatic Complexity of 10 (Highest = 15). | 559–649 |
| The class 'Mapper' has a Modified Cyclomatic Complexity of 9 (Highest = 12). | 559–649 |
| The class 'Mapper' has a Standard Cyclomatic Complexity of 9 (Highest = 12). | 559–649 |
| The method 'toResponse' has a Standard Cyclomatic Complexity of 12. | 583–648 |
| The method 'toResponse' has a Cyclomatic Complexity of 15. | 583–648 |
| The method 'toResponse' has a Modified Cyclomatic Complexity of 12. | 583–648 |
| The method toResponse() has an NPath complexity of 2160 | 583–648 |
ks-server-http - eu/fbk/knowledgestore/server/http/jaxrs/Crud.java
| Violation | Line |
|---|---|
| The class 'Crud' has a Standard Cyclomatic Complexity of 3 (Highest = 13). | 41–419 |
| The class 'Crud' has a Cyclomatic Complexity of 3 (Highest = 15). | 41–419 |
| The class 'Crud' has a Modified Cyclomatic Complexity of 3 (Highest = 13). | 41–419 |
| Ensure that resources like this Statement object are closed after use | 136 |
| The method 'parseURIs' has a Standard Cyclomatic Complexity of 13. | 371–417 |
| The method 'parseURIs' has a Modified Cyclomatic Complexity of 13. | 371–417 |
| The method 'parseURIs' has a Cyclomatic Complexity of 15. | 371–417 |
ks-server-http - eu/fbk/knowledgestore/server/http/jaxrs/Custom.java
| Violation | Line |
|---|---|
| Parameter 'customID' is not assigned and could be declared final | 29 |
| Local variable 'customConfig' could be declared final | 33 |
| Local variable 'command' could be declared final | 41 |
| Local variable 'source' could be declared final | 43 |
| Local variable 'processor' could be declared final | 45 |
ks-server-http - eu/fbk/knowledgestore/server/http/jaxrs/Files.java
| Violation | Line |
|---|---|
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 361 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 362 |
ks-server-http - eu/fbk/knowledgestore/server/http/jaxrs/RenderUtils.java
| Violation | Line |
|---|---|
| Possible God class (WMC=86, ATFD=54, TCC=0.0) | 1–525 |
| The class 'RenderUtils' has a Cyclomatic Complexity of 7 (Highest = 29). | 46–525 |
| The class 'RenderUtils' has a Standard Cyclomatic Complexity of 6 (Highest = 22). | 46–525 |
| The class 'RenderUtils' has a Modified Cyclomatic Complexity of 6 (Highest = 22). | 46–525 |
| The method 'render' has a Modified Cyclomatic Complexity of 18. | 83–165 |
| The method 'render' has a Cyclomatic Complexity of 18. | 83–165 |
| The method 'render' has a Standard Cyclomatic Complexity of 18. | 83–165 |
| Position literals first in String comparisons | 179 |
| The method 'renderText' has a Cyclomatic Complexity of 29. | 190–286 |
| The method renderText() has an NPath complexity of 18901515 | 190–286 |
| The method 'renderText' has a Modified Cyclomatic Complexity of 22. | 190–286 |
| The method 'renderText' has a Standard Cyclomatic Complexity of 22. | 190–286 |
| StringBuffer constructor is initialized with size 16, but has at least 99 characters appended. | 314 |
| StringBuffer constructor is initialized with size 16, but has at least 20 characters appended. | 329 |
| Avoid reassigning parameters such as 'propertyURIs' | 383 |
| The method 'renderRecordsAggregateTable' has a Cyclomatic Complexity of 10. | 418–479 |
ks-server-http - eu/fbk/knowledgestore/server/http/jaxrs/Resource.java
| Violation | Line |
|---|---|
| Possible God class (WMC=64, ATFD=24, TCC=0.0) | 1–411 |
| The class 'Resource' has a Modified Cyclomatic Complexity of 2 (Highest = 11). | 41–411 |
| This abstract class does not have any abstract methods | 41–411 |
| The class 'Resource' has a Standard Cyclomatic Complexity of 2 (Highest = 11). | 41–411 |
| The class 'Resource' has a Cyclomatic Complexity of 2 (Highest = 12). | 41–411 |
| The method 'doInit' has a Modified Cyclomatic Complexity of 11. | 170–239 |
| The method 'doInit' has a Standard Cyclomatic Complexity of 11. | 170–239 |
| The method 'doInit' has a Cyclomatic Complexity of 12. | 170–239 |
| The method doInit() has an NPath complexity of 1520 | 170–239 |
ks-server-http - eu/fbk/knowledgestore/server/http/jaxrs/Root.java
| Violation | Line |
|---|---|
| Possible God class (WMC=138, ATFD=144, TCC=0.002849002849002849) | 1–912 |
| The class 'Root' has a Cyclomatic Complexity of 6 (Highest = 16). | 48–912 |
| The class 'Root' has a Standard Cyclomatic Complexity of 5 (Highest = 16). | 48–912 |
| The class 'Root' has a Modified Cyclomatic Complexity of 5 (Highest = 16). | 48–912 |
| Prefer StringBuffer over += for concatenating strings | 67 |
| Prefer StringBuffer over += for concatenating strings | 67 |
| The method 'ui' has a Modified Cyclomatic Complexity of 11. | 92–167 |
| The method 'ui' has a Cyclomatic Complexity of 11. | 92–167 |
| The method 'ui' has a Standard Cyclomatic Complexity of 11. | 92–167 |
| An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type. | 154 |
| The method 'getParameter' has a Modified Cyclomatic Complexity of 10. | 170–203 |
| The method 'getParameter' has a Cyclomatic Complexity of 15. | 170–203 |
| The method 'getParameter' has a Standard Cyclomatic Complexity of 10. | 170–203 |
| Avoid empty catch blocks | 184–186 |
| StringBuffer constructor is initialized with size 16, but has at least 82 characters appended. | 208 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 218 |
| Avoid appending characters as strings in StringBuffer.append. | 230 |
| Avoid appending characters as strings in StringBuffer.append. | 230 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 231 |
| Avoid appending characters as strings in StringBuffer.append. | 238 |
| Avoid appending characters as strings in StringBuffer.append. | 238 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 256 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 259 |
| StringBuffer constructor is initialized with size 16, but has at least 43 characters appended. | 286 |
| These nested if statements could be combined | 309–313 |
| The method uiLookupResource() has an NPath complexity of 2856 | 317–419 |
| The method 'uiLookupResource' has a Standard Cyclomatic Complexity of 16. | 317–419 |
| Avoid really long methods. | 317–419 |
| The method 'uiLookupResource' has a Modified Cyclomatic Complexity of 16. | 317–419 |
| The method 'uiLookupResource' has a Cyclomatic Complexity of 16. | 317–419 |
| StringBuffer constructor is initialized with size 32, but has at least 33 characters appended. | 393 |
| The method uiLookupMention() has an NPath complexity of 216 | 421–481 |
| The method 'uiLookupEntity' has a Modified Cyclomatic Complexity of 11. | 483–564 |
| The method uiLookupEntity() has an NPath complexity of 1404 | 483–564 |
| The method 'uiLookupEntity' has a Cyclomatic Complexity of 12. | 483–564 |
| The method 'uiLookupEntity' has a Standard Cyclomatic Complexity of 11. | 483–564 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 531 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 531 |
| The method 'getResourceMentions' has a Standard Cyclomatic Complexity of 12. | 688–786 |
| The method getResourceMentions() has an NPath complexity of 432 | 688–786 |
| The method 'getResourceMentions' has a Cyclomatic Complexity of 12. | 688–786 |
| The method 'getResourceMentions' has a Modified Cyclomatic Complexity of 12. | 688–786 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 696 |
| Avoid instantiating new objects inside loops | 714 |
| StringBuffer constructor is initialized with size 16, but has at least 88 characters appended. | 714 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 715 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 716 |
| Avoid appending characters as strings in StringBuffer.append. | 725 |
| Local variable 'record' could be declared final | 729 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 789 |
| String.indexOf(char) is faster than String.indexOf(String). | 817 |
| Position literals first in String comparisons for EqualsIgnoreCase | 883 |
| Position literals first in String comparisons for EqualsIgnoreCase | 886 |
| Position literals first in String comparisons | 886 |
ks-server-http - eu/fbk/knowledgestore/server/http/jaxrs/Sparql.java
| Violation | Line |
|---|---|
| Position literals first in String comparisons | 94 |
| Position literals first in String comparisons | 94 |
| Position literals first in String comparisons | 97 |
ks-server-http - eu/fbk/knowledgestore/server/http/jaxrs/SparqlDelete.java
| Violation | Line |
|---|---|
| Local variable 'outcome' could be declared final | 35 |
ks-server-http - eu/fbk/knowledgestore/server/http/jaxrs/SparqlUpdate.java
| Violation | Line |
|---|---|
| Local variable 'outcome' could be declared final | 35 |
ks-server-http - eu/fbk/knowledgestore/server/http/jaxrs/TableQuery.java
| Violation | Line |
|---|---|
| Avoid reassigning parameters such as 'propertyURIs' | 104 |
ks-server-virtuoso - eu/fbk/knowledgestore/triplestore/virtuoso/VirtuosoJdbcTripleStore.java
| Violation | Line |
|---|---|
| Possible God class (WMC=130, ATFD=60, TCC=0.0) | 1–781 |
| The class 'VirtuosoJdbcTripleStore' has a Cyclomatic Complexity of 4 (Highest = 20). | 46–781 |
| The class 'VirtuosoJdbcTripleStore' has a Standard Cyclomatic Complexity of 4 (Highest = 16). | 46–781 |
| The class 'VirtuosoJdbcTripleStore' has a Modified Cyclomatic Complexity of 4 (Highest = 16). | 46–781 |
| The method 'castValue' has a Cyclomatic Complexity of 17. | 150–215 |
| The method 'castValue' has a Modified Cyclomatic Complexity of 16. | 150–215 |
| The method 'castValue' has a Standard Cyclomatic Complexity of 16. | 150–215 |
| The method 'sqlForQuery' has a Modified Cyclomatic Complexity of 13. | 217–280 |
| The method 'sqlForQuery' has a Cyclomatic Complexity of 20. | 217–280 |
| The method 'sqlForQuery' has a Standard Cyclomatic Complexity of 13. | 217–280 |
| StringBuffer constructor is initialized with size 25, but has at least 44 characters appended. | 221 |
| The class 'VirtuosoTransaction' has a Standard Cyclomatic Complexity of 4 (Highest = 10). | 325–779 |
| The class 'VirtuosoTransaction' has a Cyclomatic Complexity of 4 (Highest = 10). | 325–779 |
| The class 'VirtuosoTransaction' has a Modified Cyclomatic Complexity of 4 (Highest = 10). | 325–779 |
| The method 'get' has a Modified Cyclomatic Complexity of 10. | 362–394 |
| The method get() has an NPath complexity of 390625 | 362–394 |
| The method 'get' has a Standard Cyclomatic Complexity of 10. | 362–394 |
| The method 'get' has a Cyclomatic Complexity of 10. | 362–394 |
| StringBuffer constructor is initialized with size 16, but has at least 32 characters appended. | 368 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 369 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 370 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 371 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 372 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 373 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 374 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 375 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 376 |
| The method convert() has an NPath complexity of 625 | 385–391 |
| The method 'update' has a Standard Cyclomatic Complexity of 10. | 488–561 |
| The method 'update' has a Modified Cyclomatic Complexity of 10. | 488–561 |
| The method 'update' has a Cyclomatic Complexity of 10. | 488–561 |
| Ensure that resources like this Statement object are closed after use | 510 |
| Local variable 'stmt' could be declared final | 510 |
| Local variable 'lit' could be declared final | 519 |
| Unnecessary use of fully qualified name 'java.sql.Statement' due to existing import 'java.sql.*' | 614 |
| Last statement in finalize method should be a call to super.finalize() | 746 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 751 |
ks-server-virtuoso - eu/fbk/knowledgestore/triplestore/virtuoso/VirtuosoTripleStore.java
| Violation | Line |
|---|---|
| Perhaps 'fileSystem' could be replaced by a local variable. | 71 |
| Avoid unused private fields such as 'fileSystem'. | 71 |
| Perhaps 'markerPath' could be replaced by a local variable. | 73 |
ks-server-virtuoso - eu/fbk/knowledgestore/triplestore/virtuoso/VirtuosoTripleTransaction.java
| Violation | Line |
|---|---|
| Possible God class (WMC=64, ATFD=18, TCC=0.025) | 1–479 |
| The class 'VirtuosoTripleTransaction' has a Standard Cyclomatic Complexity of 4 (Highest = 12). | 47–479 |
| The class 'VirtuosoTripleTransaction' has a Modified Cyclomatic Complexity of 4 (Highest = 12). | 47–479 |
| The class 'VirtuosoTripleTransaction' has a Cyclomatic Complexity of 4 (Highest = 12). | 47–479 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 65 |
| The method query() has an NPath complexity of 450 | 163–231 |
| The method 'query' has a Modified Cyclomatic Complexity of 12. | 163–231 |
| The method 'query' has a Standard Cyclomatic Complexity of 12. | 163–231 |
| The method 'query' has a Cyclomatic Complexity of 12. | 163–231 |
| The method 'end' has a Standard Cyclomatic Complexity of 11. | 386–439 |
| The method 'end' has a Cyclomatic Complexity of 11. | 386–439 |
| The method 'end' has a Modified Cyclomatic Complexity of 11. | 386–439 |
| New exception is thrown in catch block, original stack trace may be lost | 406–407 |
| New exception is thrown in catch block, original stack trace may be lost | 413–414 |
| Ensure that resources like this Connection object are closed after use | 457 |
ks-server - eu/fbk/knowledgestore/datastore/CachingDataStore.java
| Violation | Line |
|---|---|
| Possible God class (WMC=54, ATFD=29, TCC=0.2692307692307692) | 1–491 |
| The class 'CachingDataTransaction' has a Cyclomatic Complexity of 4 (Highest = 17). | 193–489 |
| The class 'CachingDataTransaction' has a Standard Cyclomatic Complexity of 4 (Highest = 16). | 193–489 |
| The class 'CachingDataTransaction' has a Modified Cyclomatic Complexity of 4 (Highest = 16). | 193–489 |
| The method lookup() has an NPath complexity of 9600 | 243–336 |
| The method 'lookup' has a Modified Cyclomatic Complexity of 16. | 243–336 |
| The method 'lookup' has a Standard Cyclomatic Complexity of 16. | 243–336 |
| The method 'lookup' has a Cyclomatic Complexity of 17. | 243–336 |
| Avoid instantiating new objects inside loops | 329 |
ks-server - eu/fbk/knowledgestore/datastore/DataTransaction.java
| Violation | Line |
|---|---|
| Avoid unused imports such as 'eu.fbk.knowledgestore.vocabulary.KS' | 15 |
ks-server - eu/fbk/knowledgestore/datastore/MemoryDataStore.java
| Violation | Line |
|---|---|
| Use block level rather than method level synchronization | 91–118 |
| Use block level rather than method level synchronization | 121–125 |
| Use block level rather than method level synchronization | 128–135 |
| Use block level rather than method level synchronization | 142–170 |
| Use block level rather than method level synchronization | 245–251 |
| Use block level rather than method level synchronization | 254–260 |
| Use block level rather than method level synchronization | 263–268 |
| Use block level rather than method level synchronization | 297–305 |
ks-server - eu/fbk/knowledgestore/datastore/MySQLDataStore.java
| Violation | Line |
|---|---|
| Parameter 'host' is not assigned and could be declared final | 38 |
| Parameter 'databaseName' is not assigned and could be declared final | 38 |
| Parameter 'password' is not assigned and could be declared final | 38 |
| Parameter 'username' is not assigned and could be declared final | 38 |
| Private field 'con' could be made final; it is only initialized in the declaration or constructor. | 71 |
| Parameter 'readOnly' is not assigned and could be declared final | 82 |
| Parameter 'dbUser' is not assigned and could be declared final | 93 |
| Avoid unused method parameters such as 'dbPass'. | 93 |
| Avoid unused method parameters such as 'dbUser'. | 93 |
| Parameter 'dbPass' is not assigned and could be declared final | 93 |
| Parameter 'type' is not assigned and could be declared final | 97 |
| Parameter 'record' is not assigned and could be declared final | 107 |
| Parameter 'bytes' is not assigned and could be declared final | 124 |
| Parameter 'ids' is not assigned and could be declared final | 145 |
| Parameter 'type' is not assigned and could be declared final | 145 |
| Parameter 'properties' is not assigned and could be declared final | 145 |
| Local variable 'tableName' could be declared final | 146 |
| Local variable 'returns' could be declared final | 147 |
| Local variable 'id' could be declared final | 149 |
| Local variable 'query' could be declared final | 158 |
| Local variable 'stmt' could be declared final | 160 |
| Ensure that resources like this ResultSet object are closed after use | 163 |
| Local variable 'set' could be declared final | 163 |
| Local variable 'r' could be declared final | 166 |
| Parameter 'properties' is not assigned and could be declared final | 182 |
| Parameter 'condition' is not assigned and could be declared final | 182 |
| Parameter 'type' is not assigned and could be declared final | 182 |
| Local variable 'tableName' could be declared final | 183 |
| Local variable 'returns' could be declared final | 184 |
| Local variable 'query' could be declared final | 187 |
| Ensure that resources like this Statement object are closed after use | 190 |
| Local variable 'statement' could be declared final | 190 |
| Local variable 'resultSet' could be declared final | 191 |
| Ensure that resources like this ResultSet object are closed after use | 191 |
| Local variable 'r' could be declared final | 194 |
| Parameter 'condition' is not assigned and could be declared final | 212 |
| Parameter 'type' is not assigned and could be declared final | 212 |
| Local variable 'tableName' could be declared final | 213 |
| Local variable 'query' could be declared final | 215 |
| Ensure that resources like this Statement object are closed after use | 218 |
| Local variable 'statement' could be declared final | 218 |
| Local variable 'resultSet' could be declared final | 219 |
| Ensure that resources like this ResultSet object are closed after use | 219 |
| Parameter 'properties' is not assigned and could be declared final | 232 |
| Parameter 'conditions' is not assigned and could be declared final | 232 |
| Parameter 'ids' is not assigned and could be declared final | 232 |
| Parameter 'type' is not assigned and could be declared final | 237 |
| Parameter 'record' is not assigned and could be declared final | 237 |
| Parameter 'type' is not assigned and could be declared final | 263 |
| Parameter 'id' is not assigned and could be declared final | 263 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 264 |
| Local variable 'tableName' could be declared final | 264 |
| Local variable 'query' could be declared final | 274 |
| Local variable 'stmt' could be declared final | 276 |
| Parameter 'commit' is not assigned and could be declared final | 285 |
| Local variable 'type' could be declared final | 288 |
| Parameter 'readOnly' is not assigned and could be declared final | 304 |
ks-server - eu/fbk/knowledgestore/datastore/SolrDataStore.java
| Violation | Line |
|---|---|
| Avoid unused imports such as 'com.google.common.collect.Iterables' | 3 |
| Avoid unused imports such as 'eu.fbk.knowledgestore.vocabulary.KS' | 9 |
| Document empty constructor | 32–34 |
| Avoid unused private fields such as 'con'. | 38 |
| Parameter 'readOnly' is not assigned and could be declared final | 41 |
| Parameter 'dbUser' is not assigned and could be declared final | 47 |
| Avoid unused method parameters such as 'dbPass'. | 47 |
| Avoid unused method parameters such as 'dbUser'. | 47 |
| Parameter 'dbPass' is not assigned and could be declared final | 47 |
| Parameter 'properties' is not assigned and could be declared final | 52 |
| Parameter 'ids' is not assigned and could be declared final | 52 |
| Parameter 'type' is not assigned and could be declared final | 52 |
| Parameter 'condition' is not assigned and could be declared final | 90 |
| Parameter 'properties' is not assigned and could be declared final | 90 |
| Parameter 'type' is not assigned and could be declared final | 90 |
| Parameter 'condition' is not assigned and could be declared final | 121 |
| Parameter 'type' is not assigned and could be declared final | 121 |
| Parameter 'conditions' is not assigned and could be declared final | 142 |
| Parameter 'properties' is not assigned and could be declared final | 142 |
| Parameter 'ids' is not assigned and could be declared final | 142 |
| Parameter 'record' is not assigned and could be declared final | 147 |
| Parameter 'type' is not assigned and could be declared final | 147 |
| Parameter 'id' is not assigned and could be declared final | 154 |
| Parameter 'type' is not assigned and could be declared final | 154 |
| Parameter 'commit' is not assigned and could be declared final | 159 |
| Parameter 'readOnly' is not assigned and could be declared final | 165 |
| Document empty method body | 178–179 |
| Document empty method body | 182–183 |
ks-server - eu/fbk/knowledgestore/datastore/SynchronizedDataStore.java
| Violation | Line |
|---|---|
| Use block level rather than method level synchronization | 115–119 |
| Use block level rather than method level synchronization | 232–237 |
| Use block level rather than method level synchronization | 240–245 |
| Use block level rather than method level synchronization | 248–252 |
ks-server - eu/fbk/knowledgestore/datastore/TripleDataStore.java
| Violation | Line |
|---|---|
| Use block level rather than method level synchronization | 55–59 |
| Use block level rather than method level synchronization | 62–66 |
| Use block level rather than method level synchronization | 69–74 |
| The class 'TripleDataTransaction' has a Cyclomatic Complexity of 3 (Highest = 16). | 81–284 |
| The class 'TripleDataTransaction' has a Standard Cyclomatic Complexity of 3 (Highest = 15). | 81–284 |
| The class 'TripleDataTransaction' has a Modified Cyclomatic Complexity of 3 (Highest = 15). | 81–284 |
| The method 'query' has a Cyclomatic Complexity of 16. | 89–207 |
| Avoid really long methods. | 89–207 |
| The method 'query' has a Standard Cyclomatic Complexity of 15. | 89–207 |
| The method 'query' has a Modified Cyclomatic Complexity of 15. | 89–207 |
| The method query() has an NPath complexity of 300 | 89–207 |
| StringBuffer constructor is initialized with size 16, but has at least 47 characters appended. | 94 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 109 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 110 |
| Avoid using redundant field initializer for 'subject' | 130 |
| StringBuffer constructor is initialized with size 16, but has at least 18 characters appended. | 218 |
| Avoid appending characters as strings in StringBuffer.append. | 221 |
ks-server - eu/fbk/knowledgestore/filestore/GzippedFileStore.java
| Violation | Line |
|---|---|
| Non-static initializers are confusing | 124–126 |
ks-server - eu/fbk/knowledgestore/filestore/HadoopFileStore.java
| Violation | Line |
|---|---|
| New exception is thrown in catch block, original stack trace may be lost | 83 |
| New exception is thrown in catch block, original stack trace may be lost | 100 |
ks-server - eu/fbk/knowledgestore/filestore/MultiFileStore.java
| Violation | Line |
|---|---|
| Possible God class (WMC=125, ATFD=41, TCC=0.05) | 1–867 |
| New exception is thrown in catch block, original stack trace may be lost | 241–242 |
| Avoid instantiating new objects inside loops | 417 |
| Avoid empty catch blocks | 466–468 |
| The class 'Index' has a Cyclomatic Complexity of 5 (Highest = 11). | 474–782 |
| Avoid reassigning parameters such as 'bucket' | 510 |
| Avoid reassigning parameters such as 'bucket' | 510 |
| The method 'updateBucketForFilename' has a Cyclomatic Complexity of 11. | 606–637 |
| Avoid instantiating new objects inside loops | 659 |
| Avoid instantiating new objects inside loops | 661 |
| Returning 'data' may expose an internal array. | 800 |
ks-server - eu/fbk/knowledgestore/filestore/SynchronizedFileStore.java
| Violation | Line |
|---|---|
| Avoid instantiating new objects inside loops | 76 |
ks-server - eu/fbk/knowledgestore/runtime/Factory.java
| Violation | Line |
|---|---|
| Possible God class (WMC=103, ATFD=78, TCC=0.0) | 1–461 |
| The class 'Factory' has a Modified Cyclomatic Complexity of 8 (Highest = 23). | 48–461 |
| The class 'Factory' has a Cyclomatic Complexity of 9 (Highest = 30). | 48–461 |
| All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 48–461 |
| The class 'Factory' has a Standard Cyclomatic Complexity of 8 (Highest = 23). | 48–461 |
| The method 'instantiate' has a Cyclomatic Complexity of 24. | 57–131 |
| The method 'instantiate' has a Modified Cyclomatic Complexity of 17. | 57–131 |
| The method 'instantiate' has a Standard Cyclomatic Complexity of 17. | 57–131 |
| The method instantiate() has an NPath complexity of 6480 | 57–131 |
| Ensure that resources like this Statement object are closed after use | 62 |
| Ensure that resources like this Statement object are closed after use | 78 |
| Ensure that resources like this Statement object are closed after use | 94 |
| Ensure that resources like this Statement object are closed after use | 104 |
| The method 'instantiate' has a Cyclomatic Complexity of 30. | 138–238 |
| Avoid really long methods. | 138–238 |
| The method 'instantiate' has a Modified Cyclomatic Complexity of 23. | 138–238 |
| The method instantiate() has an NPath complexity of 1488000 | 138–238 |
| The method 'instantiate' has a Standard Cyclomatic Complexity of 23. | 138–238 |
| String.indexOf(char) is faster than String.indexOf(String). | 144 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 146 |
| New exception is thrown in catch block, original stack trace may be lost | 152 |
| Position literals first in String comparisons | 204 |
| Position literals first in String comparisons | 210 |
| When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 221 |
| Prefer StringBuffer over += for concatenating strings | 245 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 321 |
| Avoid instantiating new objects inside loops | 338 |
| Avoid empty catch blocks | 343–345 |
| The method 'convertMany' has a Standard Cyclomatic Complexity of 18. | 356–408 |
| The method 'convertMany' has a Modified Cyclomatic Complexity of 18. | 356–408 |
| The method 'convertMany' has a Cyclomatic Complexity of 18. | 356–408 |
| The method 'expand' has a Cyclomatic Complexity of 12. | 419–459 |
| Position literals first in String comparisons | 438 |
| Position literals first in String comparisons | 438 |
| Position literals first in String comparisons | 439 |
| Position literals first in String comparisons | 439 |
| Position literals first in String comparisons | 440 |
ks-server - eu/fbk/knowledgestore/runtime/Files.java
| Violation | Line |
|---|---|
| The class 'Files' has a Cyclomatic Complexity of 4 (Highest = 10). | 16–204 |
| Avoid using redundant field initializer for 'rawLocalFileSystem' | 18 |
| The method 'readWithBackup' has a Cyclomatic Complexity of 10. | 70–114 |
| The method readWithBackup() has an NPath complexity of 216 | 70–114 |
| Prefer StringBuffer over += for concatenating strings | 175 |
| Prefer StringBuffer over += for concatenating strings | 177 |
ks-server - eu/fbk/knowledgestore/runtime/Launcher.java
| Violation | Line |
|---|---|
| Possible God class (WMC=88, ATFD=62, TCC=0.08888888888888889) | 1–693 |
| The class 'Launcher' has a Standard Cyclomatic Complexity of 8 (Highest = 23). | 142–693 |
| The class 'Launcher' has a Cyclomatic Complexity of 9 (Highest = 27). | 142–693 |
| The class 'Launcher' has a Modified Cyclomatic Complexity of 8 (Highest = 23). | 142–693 |
| The method 'main' has a Modified Cyclomatic Complexity of 12. | 204–290 |
| The method 'main' has a Cyclomatic Complexity of 12. | 204–290 |
| The method 'main' has a Standard Cyclomatic Complexity of 12. | 204–290 |
| An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type. | 261 |
| Avoid really long methods. | 292–430 |
| The method 'run' has a Modified Cyclomatic Complexity of 23. | 292–430 |
| The method 'run' has a Standard Cyclomatic Complexity of 23. | 292–430 |
| The method 'run' has a Cyclomatic Complexity of 27. | 292–430 |
| The method run() has an NPath complexity of 8748 | 292–430 |
| Avoid empty catch blocks | 336–338 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 357 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 358 |
| StringBuffer (or StringBuilder).append is called 3 consecutive times with literal Strings. Use a single append with a single combined String. | 360 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 360 |
| Avoid empty catch blocks | 378–380 |
| Avoid empty catch blocks | 416–418 |
| Avoid empty catch blocks | 423–425 |
| The method 'start' has a Cyclomatic Complexity of 11. | 432–513 |
| The method 'start' has a Standard Cyclomatic Complexity of 11. | 432–513 |
| The method start() has an NPath complexity of 280 | 432–513 |
| The method 'start' has a Modified Cyclomatic Complexity of 11. | 432–513 |
| Ensure that resources like this Statement object are closed after use | 453 |
| Prefer StringBuffer over += for concatenating strings | 489 |
| The method 'status' has a Standard Cyclomatic Complexity of 20. | 533–628 |
| The method 'status' has a Cyclomatic Complexity of 22. | 533–628 |
| The method status() has an NPath complexity of 7502000 | 533–628 |
| The method 'status' has a Modified Cyclomatic Complexity of 20. | 533–628 |
| StringBuffer constructor is initialized with size 16, but has at least 92 characters appended. | 535 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 551 |
| Avoid appending characters as strings in StringBuffer.append. | 563 |
| Avoid appending characters as strings in StringBuffer.append. | 563 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 564 |
| Avoid appending characters as strings in StringBuffer.append. | 572 |
| Avoid appending characters as strings in StringBuffer.append. | 573 |
| Avoid appending characters as strings in StringBuffer.append. | 573 |
ks-server - eu/fbk/knowledgestore/runtime/SerializerAvro.java
| Violation | Line |
|---|---|
| Possible God class (WMC=100, ATFD=206, TCC=0.0) | 1–594 |
| The class 'SerializerAvro' has a Cyclomatic Complexity of 3 (Highest = 15). | 54–594 |
| The class 'SerializerAvro' has a Standard Cyclomatic Complexity of 3 (Highest = 15). | 54–594 |
| The class 'SerializerAvro' has a Modified Cyclomatic Complexity of 3 (Highest = 15). | 54–594 |
| The method 'decodeLiteral' has a Cyclomatic Complexity of 15. | 262–302 |
| The method 'decodeLiteral' has a Modified Cyclomatic Complexity of 15. | 262–302 |
| The method 'decodeLiteral' has a Standard Cyclomatic Complexity of 15. | 262–302 |
| Avoid instantiating new objects inside loops | 357 |
| The method 'encodeLiteral' has a Modified Cyclomatic Complexity of 13. | 392–426 |
| The method 'encodeLiteral' has a Standard Cyclomatic Complexity of 13. | 392–426 |
| The method 'encodeLiteral' has a Cyclomatic Complexity of 14. | 392–426 |
ks-server - eu/fbk/knowledgestore/runtime/Synchronizer.java
| Violation | Line |
|---|---|
| The method create() has an NPath complexity of 350 | 42–57 |
| Position literals first in String comparisons | 50 |
| Position literals first in String comparisons | 51 |
ks-server - eu/fbk/knowledgestore/server/Server.java
| Violation | Line |
|---|---|
| Possible God class (WMC=181, ATFD=174, TCC=0.0) | 1–1171 |
| Avoid duplicate imports such as 'com.google.common.collect.AbstractIterator' | 4 |
| Avoid using redundant field initializer for 'fileVersionCounter' | 58 |
| The class 'SessionImpl' has a Standard Cyclomatic Complexity of 5 (Highest = 24). | 128–1078 |
| The class 'SessionImpl' has a Modified Cyclomatic Complexity of 5 (Highest = 24). | 128–1078 |
| The class 'SessionImpl' has a Cyclomatic Complexity of 6 (Highest = 26). | 128–1078 |
| Avoid empty catch blocks | 224–226 |
| Avoid unused method parameters such as 'fromType'. | 269 |
| Position literals first in String comparisons | 271 |
| Position literals first in String comparisons | 271 |
| Avoid unused method parameters such as 'fromType'. | 274 |
| Position literals first in String comparisons | 277 |
| Position literals first in String comparisons | 296 |
| The method 'doUpload' has a Cyclomatic Complexity of 12. | 304–400 |
| The method 'doUpload' has a Modified Cyclomatic Complexity of 12. | 304–400 |
| The method 'doUpload' has a Standard Cyclomatic Complexity of 12. | 304–400 |
| The method doUpload() has an NPath complexity of 1841 | 304–400 |
| Prefer StringBuffer over += for concatenating strings | 348 |
| Prefer StringBuffer over += for concatenating strings | 348 |
| The method 'generateFileName' has a Cyclomatic Complexity of 14. | 402–459 |
| The method generateFileName() has an NPath complexity of 336 | 402–459 |
| The method 'generateFileName' has a Modified Cyclomatic Complexity of 11. | 402–459 |
| The method 'generateFileName' has a Standard Cyclomatic Complexity of 11. | 402–459 |
| The method doRetrieve() has an NPath complexity of 255 | 496–545 |
| The method 'doRetrieve' has a Cyclomatic Complexity of 11. | 496–545 |
| The method 'modifyChunk' has a Standard Cyclomatic Complexity of 12. | 711–804 |
| The method 'modifyChunk' has a Cyclomatic Complexity of 15. | 711–804 |
| The method 'modifyChunk' has a Modified Cyclomatic Complexity of 12. | 711–804 |
| Avoid really long methods. | 806–907 |
| The method 'modifyRecord' has a Standard Cyclomatic Complexity of 24. | 806–907 |
| The method 'modifyRecord' has a Modified Cyclomatic Complexity of 24. | 806–907 |
| The method modifyRecord() has an NPath complexity of 10004000 | 806–907 |
| The method 'modifyRecord' has a Cyclomatic Complexity of 26. | 806–907 |
| Parameter 'timeout' is not assigned and could be declared final | 975 |
| Parameter 'statements' is not assigned and could be declared final | 975 |
| Local variable 'outcome' could be declared final | 981 |
| Parameter 'timeout' is not assigned and could be declared final | 996 |
| Parameter 'statements' is not assigned and could be declared final | 996 |
| Local variable 'outcome' could be declared final | 1002 |
| The method 'doSparql' has a Cyclomatic Complexity of 10. | 1016–1070 |
| Avoid unused method parameters such as 'record'. | 1090 |
| Avoid instantiation through private constructors from outside of the constructors class. | 1166 |
ks-server - eu/fbk/knowledgestore/server/SparqlHelper.java
| Violation | Line |
|---|---|
| Possible God class (WMC=55, ATFD=31, TCC=0.0) | 1–447 |
| All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 77–447 |
| The class 'SparqlHelper' has a Cyclomatic Complexity of 4 (Highest = 10). | 77–447 |
| The class 'SparqlHelper' has a Modified Cyclomatic Complexity of 4 (Highest = 10). | 77–447 |
| The class 'SparqlHelper' has a Standard Cyclomatic Complexity of 4 (Highest = 10). | 77–447 |
| The method 'parse' has a Modified Cyclomatic Complexity of 10. | 79–124 |
| The method 'parse' has a Standard Cyclomatic Complexity of 10. | 79–124 |
| The method 'parse' has a Cyclomatic Complexity of 10. | 79–124 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 132 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 399 |
ks-server - eu/fbk/knowledgestore/triplestore/LoggingTripleStore.java
| Violation | Line |
|---|---|
| Avoid using redundant field initializer for 'count' | 128 |
| Local variable 'stmts' could be declared final | 224–225 |
| Local variable 'stmts' could be declared final | 244–245 |
ks-server - eu/fbk/knowledgestore/triplestore/RepositoryTripleStore.java
| Violation | Line |
|---|---|
| Possible God class (WMC=49, ATFD=14, TCC=0.06593406593406594) | 1–360 |
| New exception is thrown in catch block, original stack trace may be lost | 61 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 111 |
| StringBuffer constructor is initialized with size 16, but has at least 33 characters appended. | 242 |
| Avoid appending characters as strings in StringBuffer.append. | 247 |
| New exception is thrown in catch block, original stack trace may be lost | 324–325 |
ks-server - eu/fbk/knowledgestore/triplestore/SPARQLRenderer.java
| Violation | Line |
|---|---|
| Possible God class (WMC=367, ATFD=284, TCC=0.0) | 1–1670 |
| Avoid instantiation through private constructors from outside of the constructors class. | 186 |
| Avoid appending characters as strings in StringBuffer.append. | 209 |
| Avoid appending characters as strings in StringBuffer.append. | 255 |
| The class 'Rendering' has a Cyclomatic Complexity of 2 (Highest = 27). | 341–1354 |
| The class 'Rendering' has a Modified Cyclomatic Complexity of 2 (Highest = 26). | 341–1354 |
| The class 'Rendering' has a Standard Cyclomatic Complexity of 2 (Highest = 26). | 341–1354 |
| StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time). | 352 |
| The method 'emit' has a Cyclomatic Complexity of 27. | 488–564 |
| The method 'emit' has a Modified Cyclomatic Complexity of 26. | 488–564 |
| The method emit() has an NPath complexity of 97200 | 488–564 |
| The method 'emit' has a Standard Cyclomatic Complexity of 26. | 488–564 |
| This call to String.startsWith can be rewritten using String.charAt(0) | 512 |
| This call to String.startsWith can be rewritten using String.charAt(0) | 646 |
| The method 'emitPropertyPath' has a Standard Cyclomatic Complexity of 16. | 896–982 |
| The method 'emitPropertyPath' has a Cyclomatic Complexity of 17. | 896–982 |
| The method 'emitPropertyPath' has a Modified Cyclomatic Complexity of 16. | 896–982 |
| When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 1248 |
| The class 'Query' has a Modified Cyclomatic Complexity of 10 (Highest = 25). | 1364–1668 |
| The class 'Query' has a Cyclomatic Complexity of 14 (Highest = 30). | 1364–1668 |
| The class 'Query' has a Standard Cyclomatic Complexity of 10 (Highest = 25). | 1364–1668 |
| Avoid really long methods. | 1396–1515 |
| The method 'create' has a Modified Cyclomatic Complexity of 25. | 1396–1515 |
| The method 'create' has a Cyclomatic Complexity of 30. | 1396–1515 |
| The method 'create' has a Standard Cyclomatic Complexity of 25. | 1396–1515 |
| The method create() has an NPath complexity of 6630 | 1396–1515 |
| Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 1421 |
| Avoid instantiating new objects inside loops | 1457 |
| Avoid instantiating new objects inside loops | 1477 |
| The method 'extractQueryNodes' has a Cyclomatic Complexity of 30. | 1517–1580 |
| The method 'extractQueryNodes' has a Standard Cyclomatic Complexity of 14. | 1517–1580 |
| The method 'extractQueryNodes' has a Modified Cyclomatic Complexity of 14. | 1517–1580 |
| This for loop could be simplified to a while loop | 1560–1562 |
| Avoid instantiating new objects inside loops | 1609–1611 |
| Avoid instantiating new objects inside loops | 1612 |
| Prefer StringBuffer over += for concatenating strings | 1622 |
| Avoid long parameter lists. | 1637–1649 |
ks-server - eu/fbk/knowledgestore/triplestore/SynchronizedTripleStore.java
| Violation | Line |
|---|---|
| Use block level rather than method level synchronization | 119–123 |
| Use block level rather than method level synchronization | 253–259 |
| Use block level rather than method level synchronization | 262–267 |
| Use block level rather than method level synchronization | 270–274 |
| Use block level rather than method level synchronization | 277–281 |
| Use block level rather than method level synchronization | 284–288 |
ks-tool - eu/fbk/knowledgestore/tool/Dumper.java
| Violation | Line |
|---|---|
| All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 50–232 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 54 |
| Avoid using redundant field initializer for 'records' | 168 |
| Avoid using redundant field initializer for 'triples' | 170 |
| Ensure that resources like this Statement object are closed after use | 182 |
| Avoid using redundant field initializer for 'records' | 210 |
ks-tool - eu/fbk/knowledgestore/tool/TestDriver.java
| Violation | Line |
|---|---|
| Possible God class (WMC=140, ATFD=143, TCC=0.003952569169960474) | 1–1197 |
| The class 'TestDriver' has a Modified Cyclomatic Complexity of 9 (Highest = 15). | 70–1197 |
| The class 'TestDriver' has a Cyclomatic Complexity of 9 (Highest = 15). | 70–1197 |
| The class 'TestDriver' has a Standard Cyclomatic Complexity of 9 (Highest = 15). | 70–1197 |
| Perhaps 'timeout' could be replaced by a local variable. | 92 |
| The constructor 'TestDriver' has a Cyclomatic Complexity of 15. | 148–253 |
| The constructor 'TestDriver' has a Standard Cyclomatic Complexity of 15. | 148–253 |
| The constructor 'TestDriver' has a Modified Cyclomatic Complexity of 15. | 148–253 |
| Prefer StringBuffer over += for concatenating strings | 193 |
| The method 'runClients' has a Modified Cyclomatic Complexity of 10. | 302–394 |
| The method 'runClients' has a Cyclomatic Complexity of 10. | 302–394 |
| The method 'runClients' has a Standard Cyclomatic Complexity of 10. | 302–394 |
| Avoid instantiating new objects inside loops | 329–362 |
| Avoid really long methods. | 396–497 |
| Avoid instantiating new objects inside loops | 429 |
| Avoid instantiating new objects inside loops | 434 |
| Avoid instantiating new objects inside loops | 449 |
| The class 'Query' has a Cyclomatic Complexity of 3 (Highest = 11). | 499–1048 |
| The class 'Query' has a Standard Cyclomatic Complexity of 3 (Highest = 11). | 499–1048 |
| The class 'Query' has a Modified Cyclomatic Complexity of 3 (Highest = 11). | 499–1048 |
| The method 'create' has a Modified Cyclomatic Complexity of 11. | 523–564 |
| The method 'create' has a Cyclomatic Complexity of 11. | 523–564 |
| The method 'create' has a Standard Cyclomatic Complexity of 11. | 523–564 |
| String.indexOf(char) is faster than String.indexOf(String). | 529 |
| Avoid instantiating new objects inside loops | 536 |
| Avoid instantiating new objects inside loops | 550 |
| Avoid instantiating new objects inside loops | 552 |
| Avoid instantiating new objects inside loops | 554 |
| Avoid instantiating new objects inside loops | 556 |
| Avoid instantiating new objects inside loops | 558 |
| Avoid instantiating new objects inside loops | 560 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 590 |
| Avoid empty catch blocks | 610–612 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 625 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 625 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 626 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 627 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 628 |
| Avoid instantiation through private constructors from outside of the constructors class. | 654 |
| The class 'SparqlQuery' has a Standard Cyclomatic Complexity of 5 (Highest = 10). | 905–993 |
| The class 'SparqlQuery' has a Modified Cyclomatic Complexity of 4 (Highest = 10). | 905–993 |
| The class 'SparqlQuery' has a Cyclomatic Complexity of 7 (Highest = 18). | 905–993 |
| The method 'detectQueryForm' has a Cyclomatic Complexity of 18. | 922–956 |
| The method 'detectQueryForm' has a Modified Cyclomatic Complexity of 10. | 922–956 |
| The method 'detectQueryForm' has a Standard Cyclomatic Complexity of 10. | 922–956 |
| Avoid empty finally blocks | 989–990 |
| Avoid instantiating new objects inside loops | 1068 |
| Use block level rather than method level synchronization | 1072–1085 |
| Use block level rather than method level synchronization | 1087–1089 |
| Use block level rather than method level synchronization | 1091–1093 |
| Use block level rather than method level synchronization | 1096–1117 |
| Avoid appending characters as strings in StringBuffer.append. | 1131 |
| Avoid appending characters as strings in StringBuffer.append. | 1135 |
| Avoid appending characters as strings in StringBuffer.append. | 1182 |
ks-tool - eu/fbk/knowledgestore/tool/TestGenerator.java
| Violation | Line |
|---|---|
| Possible God class (WMC=119, ATFD=54, TCC=0.04736842105263158) | 1–839 |
| The class 'TestGenerator' has a Cyclomatic Complexity of 7 (Highest = 12). | 42–839 |
| The class 'TestGenerator' has a Standard Cyclomatic Complexity of 7 (Highest = 10). | 42–839 |
| The class 'TestGenerator' has a Modified Cyclomatic Complexity of 7 (Highest = 10). | 42–839 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 62 |
| The method 'run' has a Standard Cyclomatic Complexity of 10. | 148–235 |
| The method 'run' has a Cyclomatic Complexity of 10. | 148–235 |
| The method 'run' has a Modified Cyclomatic Complexity of 10. | 148–235 |
| Avoid instantiating new objects inside loops | 176 |
| The method pick() has an NPath complexity of 228 | 237–293 |
| The method 'pick' has a Cyclomatic Complexity of 12. | 237–293 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 238 |
| Avoid using redundant field initializer for 'writer' | 414 |
| Avoid instantiating new objects inside loops | 471 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 821 |
| The user-supplied array 'codes' is stored directly. | 821 |
ks-tool - eu/fbk/knowledgestore/tool/TestUtil.java
| Violation | Line |
|---|---|
| All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 19–138 |
| New exception is thrown in catch block, original stack trace may be lost | 40–41 |
| String.indexOf(char) is faster than String.indexOf(String). | 59 |
| Avoid instantiating new objects inside loops | 66 |
| Prefer StringBuffer over += for concatenating strings | 87 |
| Prefer StringBuffer over += for concatenating strings | 87 |
